Commit b8825d1d authored by Andrew Grieve's avatar Andrew Grieve Committed by Commit Bot

Add missing min_sdk_version to apk_merger.py

finalize_apk.py changed in 7d191755

Bug: 1040240
Change-Id: I70b73881098aa7b1b5f0375052d62cb7b0d61624
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992249
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: default avatarPeter Wen <wnwen@chromium.org>
Reviewed-by: default avatarNate Fischer <ntfschr@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729822}
parent 4b54b79a
...@@ -254,11 +254,13 @@ def main(): ...@@ -254,11 +254,13 @@ def main():
apksigner_jar = os.path.join( apksigner_jar = os.path.join(
os.path.dirname(args.zipalign_path), 'lib', 'apksigner.jar') os.path.dirname(args.zipalign_path), 'lib', 'apksigner.jar')
# TODO(https://crbug.com/1040240): remove the pylint suppression and pass # Official APKs are re-signed anyways, so it is not important to figure out
# the right value # the correct min_sdk_version. Use 21 since that's the lowest supported
finalize_apk.FinalizeApk( # pylint: disable=no-value-for-parameter # webview version.
apksigner_jar, args.zipalign_path, tmp_apk, new_apk, args.keystore_path, min_sdk_version = 21
args.key_password, args.key_name) finalize_apk.FinalizeApk(apksigner_jar, args.zipalign_path, tmp_apk,
new_apk, args.keystore_path, args.key_password,
args.key_name, min_sdk_version)
finally: finally:
shutil.rmtree(tmp_dir) shutil.rmtree(tmp_dir)
return 0 return 0
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment