Commit b89fda7b authored by rch's avatar rch Committed by Commit bot

Remove duplicate method comments in HttpServerProperties subclasses.

Review URL: https://codereview.chromium.org/890883004

Cr-Commit-Position: refs/heads/master@{#313988}
parent 4ee2b042
...@@ -71,97 +71,46 @@ class NET_EXPORT HttpServerPropertiesImpl ...@@ -71,97 +71,46 @@ class NET_EXPORT HttpServerPropertiesImpl
// HttpServerProperties methods: // HttpServerProperties methods:
// ----------------------------- // -----------------------------
// Gets a weak pointer for this object.
base::WeakPtr<HttpServerProperties> GetWeakPtr() override; base::WeakPtr<HttpServerProperties> GetWeakPtr() override;
// Deletes all data.
void Clear() override; void Clear() override;
// Returns true if |server| supports SPDY.
bool SupportsSpdy(const HostPortPair& server) override; bool SupportsSpdy(const HostPortPair& server) override;
// Add |server| into the persistent store.
void SetSupportsSpdy(const HostPortPair& server, bool support_spdy) override; void SetSupportsSpdy(const HostPortPair& server, bool support_spdy) override;
// Returns true if |server| has required HTTP/1.1 via HTTP/2 error code.
bool RequiresHTTP11(const HostPortPair& server) override; bool RequiresHTTP11(const HostPortPair& server) override;
// Require HTTP/1.1 on subsequent connections. Not persisted.
void SetHTTP11Required(const HostPortPair& server) override; void SetHTTP11Required(const HostPortPair& server) override;
// Modify SSLConfig to force HTTP/1.1 if necessary.
void MaybeForceHTTP11(const HostPortPair& server, void MaybeForceHTTP11(const HostPortPair& server,
SSLConfig* ssl_config) override; SSLConfig* ssl_config) override;
// Returns true if |server| has an Alternate-Protocol header.
bool HasAlternateProtocol(const HostPortPair& server) override; bool HasAlternateProtocol(const HostPortPair& server) override;
// Returns the Alternate-Protocol and port for |server|.
// HasAlternateProtocol(server) must be true.
AlternateProtocolInfo GetAlternateProtocol( AlternateProtocolInfo GetAlternateProtocol(
const HostPortPair& server) override; const HostPortPair& server) override;
// Sets the Alternate-Protocol for |server|.
void SetAlternateProtocol(const HostPortPair& server, void SetAlternateProtocol(const HostPortPair& server,
uint16 alternate_port, uint16 alternate_port,
AlternateProtocol alternate_protocol, AlternateProtocol alternate_protocol,
double probability) override; double probability) override;
// Sets the Alternate-Protocol for |server| to be BROKEN.
void SetBrokenAlternateProtocol(const HostPortPair& server) override; void SetBrokenAlternateProtocol(const HostPortPair& server) override;
// Returns true if Alternate-Protocol for |server| was recently BROKEN.
bool WasAlternateProtocolRecentlyBroken(const HostPortPair& server) override; bool WasAlternateProtocolRecentlyBroken(const HostPortPair& server) override;
// Confirms that Alternate-Protocol for |server| is working.
void ConfirmAlternateProtocol(const HostPortPair& server) override; void ConfirmAlternateProtocol(const HostPortPair& server) override;
// Clears the Alternate-Protocol for |server|.
void ClearAlternateProtocol(const HostPortPair& server) override; void ClearAlternateProtocol(const HostPortPair& server) override;
// Returns all Alternate-Protocol mappings.
const AlternateProtocolMap& alternate_protocol_map() const override; const AlternateProtocolMap& alternate_protocol_map() const override;
void SetAlternateProtocolProbabilityThreshold(double threshold) override; void SetAlternateProtocolProbabilityThreshold(double threshold) override;
// Gets a reference to the SettingsMap stored for a host.
// If no settings are stored, returns an empty SettingsMap.
const SettingsMap& GetSpdySettings( const SettingsMap& GetSpdySettings(
const HostPortPair& host_port_pair) override; const HostPortPair& host_port_pair) override;
// Saves an individual SPDY setting for a host. Returns true if SPDY setting
// is to be persisted.
bool SetSpdySetting(const HostPortPair& host_port_pair, bool SetSpdySetting(const HostPortPair& host_port_pair,
SpdySettingsIds id, SpdySettingsIds id,
SpdySettingsFlags flags, SpdySettingsFlags flags,
uint32 value) override; uint32 value) override;
// Clears all entries in |spdy_settings_map_| for a host.
void ClearSpdySettings(const HostPortPair& host_port_pair) override; void ClearSpdySettings(const HostPortPair& host_port_pair) override;
// Clears all entries in |spdy_settings_map_|.
void ClearAllSpdySettings() override; void ClearAllSpdySettings() override;
// Returns all persistent SPDY settings.
const SpdySettingsMap& spdy_settings_map() const override; const SpdySettingsMap& spdy_settings_map() const override;
// Methods for SupportsQuic.
SupportsQuic GetSupportsQuic( SupportsQuic GetSupportsQuic(
const HostPortPair& host_port_pair) const override; const HostPortPair& host_port_pair) const override;
void SetSupportsQuic(const HostPortPair& host_port_pair, void SetSupportsQuic(const HostPortPair& host_port_pair,
bool used_quic, bool used_quic,
const std::string& address) override; const std::string& address) override;
const SupportsQuicMap& supports_quic_map() const override; const SupportsQuicMap& supports_quic_map() const override;
// Methods for ServerNetworkStats.
void SetServerNetworkStats(const HostPortPair& host_port_pair, void SetServerNetworkStats(const HostPortPair& host_port_pair,
ServerNetworkStats stats) override; ServerNetworkStats stats) override;
const ServerNetworkStats* GetServerNetworkStats( const ServerNetworkStats* GetServerNetworkStats(
const HostPortPair& host_port_pair) override; const HostPortPair& host_port_pair) override;
const ServerNetworkStatsMap& server_network_stats_map() const override; const ServerNetworkStatsMap& server_network_stats_map() const override;
private: private:
......
...@@ -78,98 +78,46 @@ class NET_EXPORT HttpServerPropertiesManager : public HttpServerProperties { ...@@ -78,98 +78,46 @@ class NET_EXPORT HttpServerPropertiesManager : public HttpServerProperties {
// HttpServerProperties methods: // HttpServerProperties methods:
// ---------------------------------- // ----------------------------------
// Gets a weak pointer for this object.
base::WeakPtr<HttpServerProperties> GetWeakPtr() override; base::WeakPtr<HttpServerProperties> GetWeakPtr() override;
// Deletes all data. Works asynchronously.
void Clear() override; void Clear() override;
// Returns true if |server| supports SPDY. Should only be called from IO
// thread.
bool SupportsSpdy(const HostPortPair& server) override; bool SupportsSpdy(const HostPortPair& server) override;
// Add |server| as the SPDY server which supports SPDY protocol into the
// persisitent store. Should only be called from IO thread.
void SetSupportsSpdy(const HostPortPair& server, bool support_spdy) override; void SetSupportsSpdy(const HostPortPair& server, bool support_spdy) override;
// Returns true if |server| has required HTTP/1.1 via HTTP/2 error code.
bool RequiresHTTP11(const HostPortPair& server) override; bool RequiresHTTP11(const HostPortPair& server) override;
// Require HTTP/1.1 on subsequent connections. Not persisted.
void SetHTTP11Required(const HostPortPair& server) override; void SetHTTP11Required(const HostPortPair& server) override;
// Modify SSLConfig to force HTTP/1.1 if necessary.
void MaybeForceHTTP11(const HostPortPair& server, void MaybeForceHTTP11(const HostPortPair& server,
SSLConfig* ssl_config) override; SSLConfig* ssl_config) override;
// Returns true if |server| has an Alternate-Protocol header.
bool HasAlternateProtocol(const HostPortPair& server) override; bool HasAlternateProtocol(const HostPortPair& server) override;
// Returns the Alternate-Protocol and port for |server|.
// HasAlternateProtocol(server) must be true.
AlternateProtocolInfo GetAlternateProtocol( AlternateProtocolInfo GetAlternateProtocol(
const HostPortPair& server) override; const HostPortPair& server) override;
// Sets the Alternate-Protocol for |server|.
void SetAlternateProtocol(const HostPortPair& server, void SetAlternateProtocol(const HostPortPair& server,
uint16 alternate_port, uint16 alternate_port,
AlternateProtocol alternate_protocol, AlternateProtocol alternate_protocol,
double alternate_probability) override; double alternate_probability) override;
// Sets the Alternate-Protocol for |server| to be BROKEN.
void SetBrokenAlternateProtocol(const HostPortPair& server) override; void SetBrokenAlternateProtocol(const HostPortPair& server) override;
// Returns true if Alternate-Protocol for |server| was recently BROKEN.
bool WasAlternateProtocolRecentlyBroken(const HostPortPair& server) override; bool WasAlternateProtocolRecentlyBroken(const HostPortPair& server) override;
// Confirms that Alternate-Protocol for |server| is working.
void ConfirmAlternateProtocol(const HostPortPair& server) override; void ConfirmAlternateProtocol(const HostPortPair& server) override;
// Clears the Alternate-Protocol for |server|.
void ClearAlternateProtocol(const HostPortPair& server) override; void ClearAlternateProtocol(const HostPortPair& server) override;
// Returns all Alternate-Protocol mappings.
const AlternateProtocolMap& alternate_protocol_map() const override; const AlternateProtocolMap& alternate_protocol_map() const override;
void SetAlternateProtocolProbabilityThreshold(double threshold) override; void SetAlternateProtocolProbabilityThreshold(double threshold) override;
// Gets a reference to the SettingsMap stored for a host.
// If no settings are stored, returns an empty SettingsMap.
const SettingsMap& GetSpdySettings( const SettingsMap& GetSpdySettings(
const HostPortPair& host_port_pair) override; const HostPortPair& host_port_pair) override;
// Saves an individual SPDY setting for a host. Returns true if SPDY setting
// is to be persisted.
bool SetSpdySetting(const HostPortPair& host_port_pair, bool SetSpdySetting(const HostPortPair& host_port_pair,
SpdySettingsIds id, SpdySettingsIds id,
SpdySettingsFlags flags, SpdySettingsFlags flags,
uint32 value) override; uint32 value) override;
// Clears all SPDY settings for a host.
void ClearSpdySettings(const HostPortPair& host_port_pair) override; void ClearSpdySettings(const HostPortPair& host_port_pair) override;
// Clears all SPDY settings for all hosts.
void ClearAllSpdySettings() override; void ClearAllSpdySettings() override;
// Returns all SPDY persistent settings.
const SpdySettingsMap& spdy_settings_map() const override; const SpdySettingsMap& spdy_settings_map() const override;
// Methods for SupportsQuic.
SupportsQuic GetSupportsQuic( SupportsQuic GetSupportsQuic(
const HostPortPair& host_port_pair) const override; const HostPortPair& host_port_pair) const override;
void SetSupportsQuic(const HostPortPair& host_port_pair, void SetSupportsQuic(const HostPortPair& host_port_pair,
bool used_quic, bool used_quic,
const std::string& address) override; const std::string& address) override;
const SupportsQuicMap& supports_quic_map() const override; const SupportsQuicMap& supports_quic_map() const override;
void SetServerNetworkStats(const HostPortPair& host_port_pair, void SetServerNetworkStats(const HostPortPair& host_port_pair,
ServerNetworkStats stats) override; ServerNetworkStats stats) override;
const ServerNetworkStats* GetServerNetworkStats( const ServerNetworkStats* GetServerNetworkStats(
const HostPortPair& host_port_pair) override; const HostPortPair& host_port_pair) override;
const ServerNetworkStatsMap& server_network_stats_map() const override; const ServerNetworkStatsMap& server_network_stats_map() const override;
protected: protected:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment