Cleanup handling of |device.MODIFY_SETTING| requests
Previously this was all done in the |AssistantManagerServiceImpl|, but that class is already huge. To solve this I made the following changes: * split it out in a separate |AssistantDeviceSettingsDelegate| class. * Introduce helper |Setting| classes, 1 for each supported setting. * Add unittests for each of the supported settings. Bug: N/A Change-Id: Ia32aecb15e3200a183c72ad8e5bcfcd3b2b4dfbc Tests: new |chromeos_unittests| with filter |AssistantDeviceSettingsDelegateTest.*| Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147693 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#761041}
Showing
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
Please register or sign in to comment