Remove a few unnecessary std::move() calls.

-Wpessimizing-move missed a few calls for a while. Now it finds them again,
so clean them up.

Bug: 1010458
Change-Id: I143cc6f1421f505aeb56858182860018a75051f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835672
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702009}

android_webview/browser/js_java_interaction/js_java_configurator_host.cc

@@ -128,9 +128,9 @@ void JsJavaConfiguratorHost::NotifyFrame(
             render_frame_host,
             pending_remote.InitWithNewEndpointAndPassReceiver(),
             js_object.listener_ref_, js_object.allowed_origin_rules_));
-    js_objects.push_back(std::move(
-        mojom::JsObject::New(js_object.name_, std::move(pending_remote),
-                             js_object.allowed_origin_rules_)));
+    js_objects.push_back(mojom::JsObject::New(js_object.name_,
+                                              std::move(pending_remote),
+                                              js_object.allowed_origin_rules_));
   }
   configurator_remote->SetJsObjects(std::move(js_objects));
 }

chrome/browser/performance_manager/decorators/process_metrics_decorator_unittest.cc

@@ -134,11 +134,11 @@ TEST_F(ProcessMetricsDecoratorTest, RefreshTimer) {
   MockSystemNodeObserver sys_node_observer;
 
   graph()->AddSystemNodeObserver(&sys_node_observer);
-  auto memory_dump = base::make_optional(std::move(
+  auto memory_dump = base::make_optional(
       GenerateMemoryDump({{mock_graph()->process->process_id(),
                            kFakeResidentSetKb, kFakePrivateFootprintKb},
                           {mock_graph()->other_process->process_id(),
-                           kFakeResidentSetKb, kFakePrivateFootprintKb}})));
+                           kFakeResidentSetKb, kFakePrivateFootprintKb}}));
 
   EXPECT_CALL(*decorator(), GetMemoryDump())
       .WillOnce(testing::Return(testing::ByMove(std::move(memory_dump))));

components/policy/core/common/cloud/cloud_policy_client_unittest.cc

@@ -1473,8 +1473,8 @@ TEST_F(CloudPolicyClientTest, UploadRealtimeReport) {
   event_list.Append(std::move(event));
 
   client_->UploadRealtimeReport(
-      std::move(policy::RealtimeReportingJobConfiguration::BuildReport(
-          std::move(event_list), std::move(context))),
+      policy::RealtimeReportingJobConfiguration::BuildReport(
+          std::move(event_list), std::move(context)),
       callback);
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(

device/vr/openxr/openxr_controller.cc

@@ -232,7 +232,7 @@ std::vector<mojom::XRGamepadButtonPtr> OpenXrController::GetWebVrButtons()
     base::Optional<GamepadButton> button =
         GetButton(static_cast<OpenXrButtonType>(i));
     if (button) {
-      buttons.push_back(std::move(GetXRGamepadButtonPtr(button.value())));
+      buttons.push_back(GetXRGamepadButtonPtr(button.value()));
     } else {
       return {};
     }