Correct logic in ComponentLoader::AddChromeOsSpeechSynthesisExtensions
The logic here is incorrect. All four states below are valid: - Google tts exists, Espeak exists - Google tts doesn't exist, Espeak exists - Google tts exists, Espeak doesn't exist - Google tts doesn't exist, Espeak doesn't exist In cases where the extension doesn't exist, the expectation is that this function loads the extension. If neither extension exists, both should be loaded. R=lazyboy@chromium.org Bug: none Test: manual. Observe that this function is called sometimes when one extension exists, and the other doesn't. Verify both are always loaded after this call. Change-Id: Icd8138700876bd7414dce0d2b27fb672fb5d0846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343567Reviewed-by:Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#796109}
Showing
Please register or sign in to comment