Commit b8e55a49 authored by Robert Ma's avatar Robert Ma Committed by Commit Bot

[wpt-export] Do not crash when a patchset has no description

Bug: 1073100
Change-Id: I2cddb15ae7e5ed1d76323db11fdbb20f3da6292a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159414
Commit-Queue: Robert Ma <robertma@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Auto-Submit: Robert Ma <robertma@chromium.org>
Reviewed-by: default avatarStephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761028}
parent 2f63202b
......@@ -135,7 +135,8 @@ class GerritCL(object):
@property
def current_revision_description(self):
return self.current_revision['description']
# A patchset may have no description.
return self.current_revision.get('description', '')
@property
def status(self):
......
......@@ -35,6 +35,26 @@ class GerritCLTest(unittest.TestCase):
self.assertEqual(gerrit_cl.url,
'https://chromium-review.googlesource.com/638250')
def test_current_revision_description(self):
data = {
'change_id': 'Ib58c7125d85d2fd71af711ea8bbd2dc927ed02cb',
'subject': 'fake subject',
'_number': 638250,
'current_revision': '1',
'revisions': {
'1': {}
},
'owner': {
'email': 'test@chromium.org'
},
}
gerrit_cl = GerritCL(data, MockGerritAPI())
self.assertEqual(gerrit_cl.current_revision_description, '')
data['revisions']['1']['description'] = 'patchset 1'
gerrit_cl = GerritCL(data, MockGerritAPI())
self.assertEqual(gerrit_cl.current_revision_description, 'patchset 1')
def test_fetch_current_revision_commit(self):
host = MockHost()
host.executive = mock_git_commands(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment