Commit b8edef9a authored by Roman Arora's avatar Roman Arora Committed by Commit Bot

CrIconButton: Remove unnecessary disable-ripple property

CrIconButton already contains a noink property to disable the ripple
effect.

Bug: 1128599
Change-Id: I18b503466ec2aee427119aa1041920b0d793266f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446351
Commit-Queue: Roman Arora <romanarora@chromium.org>
Reviewed-by: default avatarJohn Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813478}
parent 2438f362
......@@ -167,13 +167,4 @@ suite('cr-icon-button', function() {
assertEquals('icon1', elements[0].icon);
assertEquals('icon2', elements[1].icon);
});
test('disable ripple property prevents showing ripple', () => {
document.body.innerHTML =
'<cr-icon-button disable-ripple></cr-icon-button>';
button = /** @type {!CrIconButtonElement} */ (
document.body.querySelector('cr-icon-button'));
button.focus();
assertFalse(button.hasRipple());
});
});
......@@ -63,11 +63,6 @@ Polymer({
observer: 'applyTabIndex_',
},
disableRipple: {
type: Boolean,
value: false,
},
ironIcon: {
type: String,
observer: 'onIronIconChanged_',
......@@ -126,7 +121,7 @@ Polymer({
/** @private */
showRipple_() {
if (!this.noink && !this.disabled && !this.disableRipple) {
if (!this.noink && !this.disabled) {
this.getRipple().showAndHoldDown();
this.rippleShowing_ = true;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment