[domarraybuffer] Change constructor params from unsigned to size_t

The internal representation of the size field in the DOMArrayBuffer is
already size_t, now we change the constructors to show that as well.

R=haraken@chromium.org

Bug: 1008840
Change-Id: I35fe71d0b3503244329e527f0df994812bc91387
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911782
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714576}

third_party/blink/renderer/core/fetch/body.cc

@@ -186,7 +186,7 @@ ScriptPromise Body::arrayBuffer(ScriptState* script_state,
       return ScriptPromise();
     }
   } else {
-    resolver->Resolve(DOMArrayBuffer::Create(0u, 1));
+    resolver->Resolve(DOMArrayBuffer::Create(size_t{0}, size_t{0}));
   }
   return promise;
 }

third_party/blink/renderer/core/typed_arrays/array_buffer/array_buffer.h

@@ -44,27 +44,27 @@ class CORE_EXPORT ArrayBuffer : public RefCounted<ArrayBuffer> {
   USING_FAST_MALLOC(ArrayBuffer);
 
  public:
-  static inline scoped_refptr<ArrayBuffer> Create(unsigned num_elements,
-                                                  unsigned element_byte_size);
+  static inline scoped_refptr<ArrayBuffer> Create(size_t num_elements,
+                                                  size_t element_byte_size);
   static inline scoped_refptr<ArrayBuffer> Create(ArrayBuffer*);
   static inline scoped_refptr<ArrayBuffer> Create(const void* source,
                                                   size_t byte_length);
   static inline scoped_refptr<ArrayBuffer> Create(ArrayBufferContents&);
 
   static inline scoped_refptr<ArrayBuffer> CreateOrNull(
-      unsigned num_elements,
-      unsigned element_byte_size);
+      size_t num_elements,
+      size_t element_byte_size);
 
   // Only for use by DOMArrayBuffer::CreateUninitializedOrNull().
   static inline scoped_refptr<ArrayBuffer> CreateUninitializedOrNull(
-      unsigned num_elements,
-      unsigned element_byte_size);
+      size_t num_elements,
+      size_t element_byte_size);
 
   static inline scoped_refptr<ArrayBuffer> CreateShared(
-      unsigned num_elements,
-      unsigned element_byte_size);
+      size_t num_elements,
+      size_t element_byte_size);
   static inline scoped_refptr<ArrayBuffer> CreateShared(const void* source,
-                                                        unsigned byte_length);
+                                                        size_t byte_length);
 
   inline void* Data();
   inline const void* Data() const;
@@ -98,16 +98,16 @@ class CORE_EXPORT ArrayBuffer : public RefCounted<ArrayBuffer> {
 
  private:
   static inline scoped_refptr<ArrayBuffer> Create(
-      unsigned num_elements,
-      unsigned element_byte_size,
+      size_t num_elements,
+      size_t element_byte_size,
       ArrayBufferContents::InitializationPolicy);
   static inline scoped_refptr<ArrayBuffer> CreateOrNull(
-      unsigned num_elements,
-      unsigned element_byte_size,
+      size_t num_elements,
+      size_t element_byte_size,
       ArrayBufferContents::InitializationPolicy);
   static inline scoped_refptr<ArrayBuffer> CreateShared(
-      unsigned num_elements,
-      unsigned element_byte_size,
+      size_t num_elements,
+      size_t element_byte_size,
       ArrayBufferContents::InitializationPolicy);
 
   inline unsigned ClampIndex(unsigned index) const;
@@ -117,8 +117,8 @@ class CORE_EXPORT ArrayBuffer : public RefCounted<ArrayBuffer> {
   bool is_detached_;
 };
 
-scoped_refptr<ArrayBuffer> ArrayBuffer::Create(unsigned num_elements,
-                                               unsigned element_byte_size) {
+scoped_refptr<ArrayBuffer> ArrayBuffer::Create(size_t num_elements,
+                                               size_t element_byte_size) {
   return Create(num_elements, element_byte_size,
                 ArrayBufferContents::kZeroInitialize);
 }
@@ -146,23 +146,22 @@ scoped_refptr<ArrayBuffer> ArrayBuffer::Create(ArrayBufferContents& contents) {
   return base::AdoptRef(new ArrayBuffer(contents));
 }
 
-scoped_refptr<ArrayBuffer> ArrayBuffer::CreateOrNull(
-    unsigned num_elements,
-    unsigned element_byte_size) {
+scoped_refptr<ArrayBuffer> ArrayBuffer::CreateOrNull(size_t num_elements,
+                                                     size_t element_byte_size) {
   return CreateOrNull(num_elements, element_byte_size,
                       ArrayBufferContents::kZeroInitialize);
 }
 
 scoped_refptr<ArrayBuffer> ArrayBuffer::CreateUninitializedOrNull(
-    unsigned num_elements,
-    unsigned element_byte_size) {
+    size_t num_elements,
+    size_t element_byte_size) {
   return CreateOrNull(num_elements, element_byte_size,
                       ArrayBufferContents::kDontInitialize);
 }
 
 scoped_refptr<ArrayBuffer> ArrayBuffer::Create(
-    unsigned num_elements,
-    unsigned element_byte_size,
+    size_t num_elements,
+    size_t element_byte_size,
     ArrayBufferContents::InitializationPolicy policy) {
   ArrayBufferContents contents(num_elements, element_byte_size,
                                ArrayBufferContents::kNotShared, policy);
@@ -172,8 +171,8 @@ scoped_refptr<ArrayBuffer> ArrayBuffer::Create(
 }
 
 scoped_refptr<ArrayBuffer> ArrayBuffer::CreateOrNull(
-    unsigned num_elements,
-    unsigned element_byte_size,
+    size_t num_elements,
+    size_t element_byte_size,
     ArrayBufferContents::InitializationPolicy policy) {
   ArrayBufferContents contents(num_elements, element_byte_size,
                                ArrayBufferContents::kNotShared, policy);
@@ -182,15 +181,14 @@ scoped_refptr<ArrayBuffer> ArrayBuffer::CreateOrNull(
   return base::AdoptRef(new ArrayBuffer(contents));
 }
 
-scoped_refptr<ArrayBuffer> ArrayBuffer::CreateShared(
-    unsigned num_elements,
-    unsigned element_byte_size) {
+scoped_refptr<ArrayBuffer> ArrayBuffer::CreateShared(size_t num_elements,
+                                                     size_t element_byte_size) {
   return CreateShared(num_elements, element_byte_size,
                       ArrayBufferContents::kZeroInitialize);
 }
 
 scoped_refptr<ArrayBuffer> ArrayBuffer::CreateShared(const void* source,
-                                                     unsigned byte_length) {
+                                                     size_t byte_length) {
   ArrayBufferContents contents(byte_length, 1, ArrayBufferContents::kShared,
                                ArrayBufferContents::kDontInitialize);
   CHECK(contents.DataShared());
@@ -200,8 +198,8 @@ scoped_refptr<ArrayBuffer> ArrayBuffer::CreateShared(const void* source,
 }
 
 scoped_refptr<ArrayBuffer> ArrayBuffer::CreateShared(
-    unsigned num_elements,
-    unsigned element_byte_size,
+    size_t num_elements,
+    size_t element_byte_size,
     ArrayBufferContents::InitializationPolicy policy) {
   ArrayBufferContents contents(num_elements, element_byte_size,
                                ArrayBufferContents::kShared, policy);

third_party/blink/renderer/core/typed_arrays/dom_array_buffer.cc

@@ -41,8 +41,8 @@ bool DOMArrayBuffer::Transfer(v8::Isolate* isolate,
                               ArrayBufferContents& result) {
   DOMArrayBuffer* to_transfer = this;
   if (!IsDetachable(isolate)) {
-    to_transfer = DOMArrayBuffer::Create(Buffer()->Data(),
-                                         Buffer()->ByteLengthAsUnsigned());
+    to_transfer =
+        DOMArrayBuffer::Create(Buffer()->Data(), Buffer()->ByteLengthAsSizeT());
   }
 
   if (!to_transfer->Buffer()->Transfer(result))
@@ -59,8 +59,8 @@ bool DOMArrayBuffer::Transfer(v8::Isolate* isolate,
 }
 
 DOMArrayBuffer* DOMArrayBuffer::CreateUninitializedOrNull(
-    unsigned num_elements,
-    unsigned element_byte_size) {
+    size_t num_elements,
+    size_t element_byte_size) {
   scoped_refptr<ArrayBuffer> buffer =
       ArrayBuffer::CreateUninitializedOrNull(num_elements, element_byte_size);
   if (!buffer)

third_party/blink/renderer/core/typed_arrays/dom_array_buffer.h

@@ -20,11 +20,10 @@ class CORE_EXPORT DOMArrayBuffer final : public DOMArrayBufferBase {
   static DOMArrayBuffer* Create(scoped_refptr<ArrayBuffer> buffer) {
     return MakeGarbageCollected<DOMArrayBuffer>(std::move(buffer));
   }
-  static DOMArrayBuffer* Create(unsigned num_elements,
-                                unsigned element_byte_size) {
+  static DOMArrayBuffer* Create(size_t num_elements, size_t element_byte_size) {
     return Create(ArrayBuffer::Create(num_elements, element_byte_size));
   }
-  static DOMArrayBuffer* Create(const void* source, unsigned byte_length) {
+  static DOMArrayBuffer* Create(const void* source, size_t byte_length) {
     return Create(ArrayBuffer::Create(source, byte_length));
   }
   static DOMArrayBuffer* Create(ArrayBufferContents& contents) {
@@ -36,8 +35,8 @@ class CORE_EXPORT DOMArrayBuffer final : public DOMArrayBufferBase {
   // Only for use by XMLHttpRequest::responseArrayBuffer,
   // Internals::serializeObject, and
   // FetchDataLoaderAsArrayBuffer::OnStateChange.
-  static DOMArrayBuffer* CreateUninitializedOrNull(unsigned num_elements,
-                                                   unsigned element_byte_size);
+  static DOMArrayBuffer* CreateUninitializedOrNull(size_t num_elements,
+                                                   size_t element_byte_size);
 
   explicit DOMArrayBuffer(scoped_refptr<ArrayBuffer> buffer)
       : DOMArrayBufferBase(std::move(buffer)) {}

third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.cc

@@ -184,8 +184,7 @@ String RTCQuicTransport::state() const {
 }
 
 DOMArrayBuffer* RTCQuicTransport::getKey() const {
-  return DOMArrayBuffer::Create(key_->Data(),
-                                key_->DeprecatedByteLengthAsUnsigned());
+  return DOMArrayBuffer::Create(key_->Data(), key_->ByteLengthAsSizeT());
 }
 
 void RTCQuicTransport::connect(ExceptionState& exception_state) {