[signin] Remove GetLandingURL

Delete the signin::GetLandingURL() function.

This function isn't used anymore since crrev.com/c/1604274.

Bug: 470893
Test: existing unit tests
Change-Id: Ida6432f052d0b1980946366de567f4f5e56f00f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606160
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660655}

chrome/browser/signin/signin_promo.cc

@@ -6,7 +6,6 @@
 
 #include "base/strings/string_number_conversions.h"
 #include "chrome/browser/browser_process.h"
-#include "chrome/browser/extensions/signin/gaia_auth_extension_loader.h"
 #include "chrome/browser/first_run/first_run.h"
 #include "chrome/browser/google/google_brand.h"
 #include "chrome/browser/profiles/profile.h"
@@ -33,34 +32,6 @@ const char kSignInPromoQueryKeyAccessPoint[] = "access_point";
 const char kSignInPromoQueryKeyAutoClose[] = "auto_close";
 const char kSignInPromoQueryKeyForceKeepData[] = "force_keep_data";
 const char kSignInPromoQueryKeyReason[] = "reason";
-const char kSignInPromoQueryKeySource[] = "source";
-const char kSigninPromoLandingURLSuccessPage[] = "success.html";
-
-GURL GetLandingURL(signin_metrics::AccessPoint access_point) {
-  GURL url(extensions::kGaiaAuthExtensionOrigin);
-  GURL::Replacements replacements;
-  replacements.SetPathStr(kSigninPromoLandingURLSuccessPage);
-  url = url.ReplaceComponents(replacements);
-
-  url = net::AppendQueryParameter(
-      url, kSignInPromoQueryKeyAccessPoint,
-      base::NumberToString(static_cast<int>(access_point)));
-
-  // TODO(gogerald): right now, gaia server needs to distinguish the source from
-  // signin_metrics::SOURCE_START_PAGE, signin_metrics::SOURCE_SETTINGS and
-  // the others to show advanced sync settings, remove them after
-  // switching to Minute Maid sign in flow.
-  signin_metrics::Source source = signin_metrics::SOURCE_OTHERS;
-  if (access_point == signin_metrics::AccessPoint::ACCESS_POINT_START_PAGE) {
-    source = signin_metrics::SOURCE_START_PAGE;
-  } else if (access_point ==
-             signin_metrics::AccessPoint::ACCESS_POINT_SETTINGS) {
-    source = signin_metrics::SOURCE_SETTINGS;
-  }
-  url = net::AppendQueryParameter(url, signin::kSignInPromoQueryKeySource,
-                                  base::NumberToString(source));
-  return GURL(url);
-}
 
 #if !defined(OS_CHROMEOS)
 GURL GetEmbeddedPromoURL(signin_metrics::AccessPoint access_point,

chrome/browser/signin/signin_promo.h

@@ -8,7 +8,6 @@
 #include <string>
 
 #include "build/build_config.h"
-#include "chrome/browser/ui/profile_chooser_constants.h"
 #include "components/signin/core/browser/signin_metrics.h"
 
 class GURL;
@@ -24,11 +23,6 @@ extern const char kSignInPromoQueryKeyAccessPoint[];
 extern const char kSignInPromoQueryKeyAutoClose[];
 extern const char kSignInPromoQueryKeyForceKeepData[];
 extern const char kSignInPromoQueryKeyReason[];
-extern const char kSignInPromoQueryKeySource[];
-extern const char kSigninPromoLandingURLSuccessPage[];
-
-// Gets the sign in landing page URL.
-GURL GetLandingURL(signin_metrics::AccessPoint access_point);
 
 #if !defined(OS_CHROMEOS)
 // These functions are only used to unlock the profile from the desktop user

chrome/browser/signin/signin_promo_unittest.cc

@@ -37,25 +37,6 @@ TEST(SigninPromoTest, TestReauthURL) {
 }
 #endif  // !defined(OS_CHROMEOS)
 
-TEST(SigninPromoTest, TestLandingURL) {
-  GURL expected_url_1(
-      "chrome-extension://mfffpogegjflfpflabcdkioaeobkgjik/"
-      "success.html?access_point=1&source=13");
-  EXPECT_EQ(expected_url_1,
-            GetLandingURL(signin_metrics::AccessPoint::ACCESS_POINT_NTP_LINK));
-  GURL expected_url_2(
-      "chrome-extension://mfffpogegjflfpflabcdkioaeobkgjik/"
-      "success.html?access_point=0&source=0");
-  EXPECT_EQ(
-      expected_url_2,
-      GetLandingURL(signin_metrics::AccessPoint::ACCESS_POINT_START_PAGE));
-  GURL expected_url_3(
-      "chrome-extension://mfffpogegjflfpflabcdkioaeobkgjik/"
-      "success.html?access_point=3&source=3");
-  EXPECT_EQ(expected_url_3,
-            GetLandingURL(signin_metrics::AccessPoint::ACCESS_POINT_SETTINGS));
-}
-
 TEST(SigninPromoTest, SigninURLForDice) {
   EXPECT_EQ(
       "https://accounts.google.com/signin/chrome/sync?ssp=1&"