Commit b91f0a04 authored by Colin Blundell's avatar Colin Blundell Committed by Commit Bot

Remove //components/resources dep from //weblayer:weblayer_lib

//components/resources is a group target that both generates the headers
via grit and also generates the pakfile. The only reason that this direct
dependency would be needed from the weblayer_lib target was if the files in
weblayer_lib were including the grit-generated headers from
//components/resources (making sure that the necessary resources are
packaged in a given app is not the responsibility of weblayer_lib).
However, they're not.

Note however that //weblayer:weblayer_lib already has indirect
dependencies on //components/resources (e.g., via
//components/security_interstitials/content:security_interstitials_page),
so this change impacts only logical clarity.

Change-Id: I3898aa6d7bcc772af39983b8c1e9c164cbade752
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906211Reviewed-by: default avatarJohn Abd-El-Malek <jam@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714432}
parent ec87d172
......@@ -118,7 +118,6 @@ jumbo_static_library("weblayer_lib") {
"//cc",
"//components/crash/content/app",
"//components/crash/content/browser",
"//components/resources",
"//components/security_interstitials/content:security_interstitial_page",
"//components/security_interstitials/content/renderer:security_interstitial_page_controller",
"//components/security_interstitials/core",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment