Commit b944e5d8 authored by Tanmoy Mollik's avatar Tanmoy Mollik Committed by Commit Bot

[Android] Remove force promo state update in BookmarkPromoRender tests

Updating the promo state forcefully is not required for these tests.
This cl does not change the behavior of the tests. It changes how the
environment is set up.

This cl also enables testPersonalizedSigninPromoInBookmarkPage test.

Bug: 1123478, 1133426
Change-Id: I4382f857ca1e91676404fce1a1c6e76c315e4493
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517684Reviewed-by: default avatarMarc Treib <treib@chromium.org>
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824830}
parent a4b8aca4
...@@ -22,7 +22,6 @@ import org.chromium.base.test.params.ParameterAnnotations; ...@@ -22,7 +22,6 @@ import org.chromium.base.test.params.ParameterAnnotations;
import org.chromium.base.test.params.ParameterizedRunner; import org.chromium.base.test.params.ParameterizedRunner;
import org.chromium.base.test.util.CommandLineFlags; import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.DisableIf; import org.chromium.base.test.util.DisableIf;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature; import org.chromium.base.test.util.Feature;
import org.chromium.chrome.R; import org.chromium.chrome.R;
import org.chromium.chrome.browser.flags.ChromeSwitches; import org.chromium.chrome.browser.flags.ChromeSwitches;
...@@ -82,7 +81,6 @@ public class BookmarkPersonalizedPromoRenderTest { ...@@ -82,7 +81,6 @@ public class BookmarkPersonalizedPromoRenderTest {
public void setUp() { public void setUp() {
// Native side needs to loaded before signing in test account. // Native side needs to loaded before signing in test account.
mActivityTestRule.startMainActivityOnBlankPage(); mActivityTestRule.startMainActivityOnBlankPage();
mAccountManagerTestRule.addTestAccountThenSigninAndEnableSync();
TestThreadUtils.runOnUiThreadBlocking(() -> { TestThreadUtils.runOnUiThreadBlocking(() -> {
BookmarkModel bookmarkModel = new BookmarkModel(Profile.getLastUsedRegularProfile()); BookmarkModel bookmarkModel = new BookmarkModel(Profile.getLastUsedRegularProfile());
bookmarkModel.loadFakePartnerBookmarkShimForTesting(); bookmarkModel.loadFakePartnerBookmarkShimForTesting();
...@@ -102,13 +100,12 @@ public class BookmarkPersonalizedPromoRenderTest { ...@@ -102,13 +100,12 @@ public class BookmarkPersonalizedPromoRenderTest {
@Test @Test
@MediumTest @MediumTest
@DisabledTest(message = "crbug.com/1136534")
@Feature("RenderTest") @Feature("RenderTest")
@ParameterAnnotations.UseMethodParameter(NightModeTestUtils.NightModeParams.class) @ParameterAnnotations.UseMethodParameter(NightModeTestUtils.NightModeParams.class)
public void testPersonalizedSigninPromoInBookmarkPage(boolean nightModeEnabled) public void testPersonalizedSigninPromoInBookmarkPage(boolean nightModeEnabled)
throws Exception { throws Exception {
BookmarkPromoHeader.forcePromoStateForTests( mAccountManagerTestRule.addAccount(mAccountManagerTestRule.createProfileDataFromName(
BookmarkPromoHeader.PromoState.PROMO_SIGNIN_PERSONALIZED); AccountManagerTestRule.TEST_ACCOUNT_EMAIL));
mBookmarkTestRule.showBookmarkManager(mActivityTestRule.getActivity()); mBookmarkTestRule.showBookmarkManager(mActivityTestRule.getActivity());
mRenderTestRule.render(getPersonalizedPromoView(), "bookmark_personalized_signin_promo"); mRenderTestRule.render(getPersonalizedPromoView(), "bookmark_personalized_signin_promo");
} }
...@@ -118,8 +115,7 @@ public class BookmarkPersonalizedPromoRenderTest { ...@@ -118,8 +115,7 @@ public class BookmarkPersonalizedPromoRenderTest {
@Feature("RenderTest") @Feature("RenderTest")
@ParameterAnnotations.UseMethodParameter(NightModeTestUtils.NightModeParams.class) @ParameterAnnotations.UseMethodParameter(NightModeTestUtils.NightModeParams.class)
public void testPersonalizedSyncPromoInBookmarkPage(boolean nightModeEnabled) throws Exception { public void testPersonalizedSyncPromoInBookmarkPage(boolean nightModeEnabled) throws Exception {
BookmarkPromoHeader.forcePromoStateForTests( mAccountManagerTestRule.addTestAccountThenSignin();
BookmarkPromoHeader.PromoState.PROMO_SYNC_PERSONALIZED);
mBookmarkTestRule.showBookmarkManager(mActivityTestRule.getActivity()); mBookmarkTestRule.showBookmarkManager(mActivityTestRule.getActivity());
mRenderTestRule.render(getPersonalizedPromoView(), "bookmark_personalized_sync_promo"); mRenderTestRule.render(getPersonalizedPromoView(), "bookmark_personalized_sync_promo");
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment