Commit b967bfd4 authored by Frank Tang's avatar Frank Tang Committed by Commit Bot

Reland "Roll ICU to fix sr-ME problem"

This reverts commit 06c8dc37.

Reason for revert: Retry after fixed win clang bugs

Binary-Size: Increase is temporary.


Original change's description:
> Revert "Roll ICU to fix sr-ME problem"
>
> This reverts commit e8aa67c5.
>
> Reason for revert: Breaking win32-archive-rel
> https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/14063?
>
> TBR=dvallet@chromium.org
> NOTRY=true
> NOTREECHECKS=true
> NOPRESUBMIT=true
>
> Change-Id: If0576038e2d07cf3e3ad5e5c35a64ff0007ee174
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248392
> Commit-Queue: calamity <calamity@chromium.org>
> Reviewed-by: calamity <calamity@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#779634}

TBR=calamity@chromium.org,jshin@chromium.org,dvallet@chromium.org,claudiomagni@chromium.org,ftang@chromium.org

# Not skipping CQ checks because this is a reland.


Roll ICU to fix sr-ME problem

Include consistent locale script/region variants by using filterType
language.

Change expectation in locale_util_unittest since now icu will return
it-IT and de-DE in the available locales after we include all the
script/region variants.
Correct expectation in currency_formatter_unittest and remove comments.

https://chromium.googlesource.com/chromium/deps/icu.git/+log/9e7dae8..79326efe

79326ef Make visibility_hidden configuration only pass -fvisibility=hidden on Linux/Android/MacOS
d3f776e Add back curr/en_* in android_small
bbf7f88 Append a postfix to the icu target outputs on fuchsia (where target output is hardcoded)
7852ffc Use filterType: language
8d29692 Allow building icuuc/icui18n with -fvisibility=hidden

Size will be reduced once we land ICU 68.1 which I reduced the break
iterator data size.

Binary-Size: Increase is temporary.
Bug: v8:10599, v8:10601, 863749, 739812
Change-Id: Icb1ed09ca3679f60c8c77bf8e1f346f323b5e6bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252026
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: default avatarFrank Tang <ftang@chromium.org>
Reviewed-by: default avatarMartin Kustermann <kustermann@google.com>
Cr-Commit-Position: refs/heads/master@{#780101}
parent ce6dc05c
...@@ -1011,7 +1011,7 @@ deps = { ...@@ -1011,7 +1011,7 @@ deps = {
Var('chromium_git') + '/chromium/deps/hunspell_dictionaries.git' + '@' + '6fdad5388130757e1efb58a14b8e7f9494625691', Var('chromium_git') + '/chromium/deps/hunspell_dictionaries.git' + '@' + '6fdad5388130757e1efb58a14b8e7f9494625691',
'src/third_party/icu': 'src/third_party/icu':
Var('chromium_git') + '/chromium/deps/icu.git' + '@' + '9e7dae8c9a3f3b41afdf1a9f5e78f0299fb93e4e', Var('chromium_git') + '/chromium/deps/icu.git' + '@' + '79326efe26e5440f530963704c3c0ff965b3a4ac',
'src/third_party/icu4j': { 'src/third_party/icu4j': {
'packages': [ 'packages': [
......
...@@ -217,18 +217,15 @@ TEST_F(LocaleUtilTest, ConvertToActualUILocale) { ...@@ -217,18 +217,15 @@ TEST_F(LocaleUtilTest, ConvertToActualUILocale) {
EXPECT_TRUE(is_ui); EXPECT_TRUE(is_ui);
EXPECT_EQ("nb", locale); EXPECT_EQ("nb", locale);
//---------------------------------------------------------------------------
// Languages that have their base language is a UI language.
//---------------------------------------------------------------------------
locale = "it-IT"; locale = "it-IT";
is_ui = language::ConvertToActualUILocale(&locale); is_ui = language::ConvertToActualUILocale(&locale);
EXPECT_TRUE(is_ui); EXPECT_TRUE(is_ui);
EXPECT_EQ("it", locale); EXPECT_EQ("it-IT", locale);
locale = "de-DE"; locale = "de-DE";
is_ui = language::ConvertToActualUILocale(&locale); is_ui = language::ConvertToActualUILocale(&locale);
EXPECT_TRUE(is_ui); EXPECT_TRUE(is_ui);
EXPECT_EQ("de", locale); EXPECT_EQ("de-DE", locale);
//--------------------------------------------------------------------------- //---------------------------------------------------------------------------
// Languages that cannot be used as display UI. // Languages that cannot be used as display UI.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment