[iOS] Update the toolbars in BVC's viewWillAppear

This CL changes how the broadcasted value of toolbar height is done.
The value is now broadcasted when the view will become visible instead
of when it did become visible.
Using this, the toolbar insets are updated when the view will become
visible, allowing a smoother animation when the screen has been rotated
in background.

Bug: 908796
Change-Id: I49e42fa9246ff76fc702243a3f6571cb81ab912c
Reviewed-on: https://chromium-review.googlesource.com/c/1356588Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613045}

ios/chrome/browser/ui/browser_view_controller.mm

@@ -1067,6 +1067,7 @@ applicationCommandEndpoint:(id<ApplicationCommands>)applicationCommandEndpoint
     return;
 
   _visible = visible;
+  [self updateBroadcastState];
 }
 
 - (void)setViewVisible:(BOOL)viewVisible {
@@ -1075,7 +1076,6 @@ applicationCommandEndpoint:(id<ApplicationCommands>)applicationCommandEndpoint
   _viewVisible = viewVisible;
   self.visible = viewVisible;
   [self updateDialogPresenterActiveState];
-  [self updateBroadcastState];
 }
 
 - (void)setBroadcasting:(BOOL)broadcasting {
@@ -1639,6 +1639,7 @@ applicationCommandEndpoint:(id<ApplicationCommands>)applicationCommandEndpoint
   self.viewVisible = YES;
   [self updateDialogPresenterActiveState];
   [self updateBroadcastState];
+  [_toolbarUIUpdater updateState];
 
   // |viewDidAppear| can be called after |browserState| is destroyed. Since
   // |presentBubblesIfEligible| requires that |self.browserState| is not NULL,
@@ -1745,10 +1746,7 @@ applicationCommandEndpoint:(id<ApplicationCommands>)applicationCommandEndpoint
     self.currentWebState->GetWebViewProxy().contentInset = contentPadding;
   }
 
-  if (self.traitCollection.preferredContentSizeCategory !=
-      previousTraitCollection.preferredContentSizeCategory) {
-    [_toolbarUIUpdater updateState];
-  }
+  [_toolbarUIUpdater updateState];
 
   // If the device's size class has changed from RegularXRegular to another and
   // vice-versa, the find bar should switch between regular mode and compact
@@ -2442,7 +2440,12 @@ applicationCommandEndpoint:(id<ApplicationCommands>)applicationCommandEndpoint
 
     // Make new content visible, resizing it first as the orientation may
     // have changed from the last time it was displayed.
-    [self viewForTab:tab].frame = self.contentArea.bounds;
+    if (base::FeatureList::IsEnabled(
+            web::features::kBrowserContainerFullscreen)) {
+      [_toolbarUIUpdater updateState];
+    } else {
+      [self viewForTab:tab].frame = self.contentArea.bounds;
+    }
     NewTabPageTabHelper* NTPHelper =
         NewTabPageTabHelper::FromWebState(tab.webState);
     if (NTPHelper && NTPHelper->IsActive()) {
@@ -2527,7 +2530,7 @@ applicationCommandEndpoint:(id<ApplicationCommands>)applicationCommandEndpoint
 }
 
 - (void)updateBroadcastState {
-  self.broadcasting = self.active && self.viewVisible;
+  self.broadcasting = self.active && self.visible;
 }
 
 - (void)updateDialogPresenterActiveState {