Commit b9a230ea authored by hichris123's avatar hichris123 Committed by Commit bot

Revert of Re-enable some HistoryApiTests (patchset #1 id:1 of...

Revert of Re-enable some HistoryApiTests (patchset #1 id:1 of https://codereview.chromium.org/926283003/)

Reason for revert:
All of these tests are still flaky, so reverting it will re-disable the tests.

Original issue's description:
> Re-enable some HistoryApiTests
>
> Currently HistoryApiTest.Delete, HistoryApiTest.GetVisits, and HistoryApiTest.SearchAfterAdd are disabled. These do not flake or time out locally nor on the try bots, so this CL re-enables them.
>
> BUG=88318, 79074, 76170
>
> Committed: https://crrev.com/f1c7ab473515bf887dcf628f9c004c3114a5f862
> Cr-Commit-Position: refs/heads/master@{#316680}

TBR=rdevlin.cronin@chromium.org
BUG=88318, 79074, 76170

Review URL: https://codereview.chromium.org/943413003

Cr-Commit-Position: refs/heads/master@{#317670}
parent 63f25bef
...@@ -34,7 +34,13 @@ IN_PROC_BROWSER_TEST_F(HistoryApiTest, DISABLED_TimedSearch) { ...@@ -34,7 +34,13 @@ IN_PROC_BROWSER_TEST_F(HistoryApiTest, DISABLED_TimedSearch) {
ASSERT_TRUE(RunExtensionSubtest("history", "timed_search.html")) << message_; ASSERT_TRUE(RunExtensionSubtest("history", "timed_search.html")) << message_;
} }
IN_PROC_BROWSER_TEST_F(HistoryApiTest, Delete) { #if defined(OS_WIN)
// Flaky on Windows: crbug.com/88318
#define MAYBE_Delete DISABLED_Delete
#else
#define MAYBE_Delete Delete
#endif
IN_PROC_BROWSER_TEST_F(HistoryApiTest, MAYBE_Delete) {
ASSERT_TRUE(StartEmbeddedTestServer()); ASSERT_TRUE(StartEmbeddedTestServer());
ASSERT_TRUE(RunExtensionSubtest("history", "delete.html")) << message_; ASSERT_TRUE(RunExtensionSubtest("history", "delete.html")) << message_;
} }
...@@ -47,12 +53,21 @@ IN_PROC_BROWSER_TEST_F(HistoryApiTest, DeleteProhibited) { ...@@ -47,12 +53,21 @@ IN_PROC_BROWSER_TEST_F(HistoryApiTest, DeleteProhibited) {
message_; message_;
} }
IN_PROC_BROWSER_TEST_F(HistoryApiTest, GetVisits) { // See crbug.com/79074
IN_PROC_BROWSER_TEST_F(HistoryApiTest, DISABLED_GetVisits) {
ASSERT_TRUE(StartEmbeddedTestServer()); ASSERT_TRUE(StartEmbeddedTestServer());
ASSERT_TRUE(RunExtensionSubtest("history", "get_visits.html")) << message_; ASSERT_TRUE(RunExtensionSubtest("history", "get_visits.html")) << message_;
} }
IN_PROC_BROWSER_TEST_F(HistoryApiTest, SearchAfterAdd) { #if defined(OS_WIN)
// Searching for a URL right after adding it fails on win XP.
// Fix this as part of crbug/76170.
#define MAYBE_SearchAfterAdd DISABLED_SearchAfterAdd
#else
#define MAYBE_SearchAfterAdd SearchAfterAdd
#endif
IN_PROC_BROWSER_TEST_F(HistoryApiTest, MAYBE_SearchAfterAdd) {
ASSERT_TRUE(StartEmbeddedTestServer()); ASSERT_TRUE(StartEmbeddedTestServer());
ASSERT_TRUE(RunExtensionSubtest("history", "search_after_add.html")) ASSERT_TRUE(RunExtensionSubtest("history", "search_after_add.html"))
<< message_; << message_;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment