[MD settings] ripple on mouse down in side nav

This CL changes the ripple to trigger on mouse down rather than mouse
up. This better matches other uses of paper-ripple.

BUG=645190
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2341593002
Cr-Commit-Position: refs/heads/master@{#419331}

chrome/browser/resources/settings/settings_menu/settings_menu.html

@@ -77,7 +77,7 @@
       }
 
       .page-menu div {
-        -webkit-margin-start: 24px;
+        -webkit-padding-start: 24px;
         align-items: center;
         display: flex;
         font-size: 13px;
@@ -138,9 +138,10 @@
       <paper-submenu class="page-menu" id="advancedPage" actionable
           opened="{{advancedOpened_}}"
           hidden="[[!pageVisibility.advancedSettings]]">
-        <div class="menu-trigger" on-tap="ripple_">
+        <div class="menu-trigger">
           <span>$i18n{advancedPageTitle}</span>
           <iron-icon icon="[[arrowState_(advancedOpened_)]]"></iron-icon>
+          <paper-ripple></paper-ripple>
         </div>
         <paper-menu attr-for-selected="data-path" class="menu-content"
             id="advancedMenu" selected="[[currentRoute.path]]">

chrome/browser/resources/settings/settings_menu/settings_menu.js

@@ -66,20 +66,6 @@ Polymer({
     }
   },
 
-  /**
-   * @param {!Event} event
-   * @private
-   */
-  ripple_: function(event) {
-    var ripple = document.createElement('paper-ripple');
-    ripple.addEventListener('transitionend', function() {
-      ripple.remove();
-    });
-    event.currentTarget.appendChild(ripple);
-    ripple.downAction();
-    ripple.upAction();
-  },
-
   /**
    * @param {!Event} event
    * @private