Commit b9b4b337 authored by Jack Lynch's avatar Jack Lynch Committed by Commit Bot

DevTools: More descriptive Watch button labels

This change adds more descriptive aria-labels for the add/refresh buttons.


Screenshot: https://gyazo.com/6e5092a5b059c9fecb38141a0f9823a5

Bug: 963183
Change-Id: I31b81f1204393b7061c69bfd0a34c16dc564ac07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646644
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
Reviewed-by: default avatarJoel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679799}
parent 68d7fe45
......@@ -43,9 +43,9 @@ Sources.WatchExpressionsSidebarPane = class extends UI.ThrottledWidget {
this._watchExpressions = [];
this._watchExpressionsSetting = Common.settings.createLocalSetting('watchExpressions', []);
this._addButton = new UI.ToolbarButton(Common.UIString('Add expression'), 'largeicon-add');
this._addButton = new UI.ToolbarButton(ls`Add watch expression`, 'largeicon-add');
this._addButton.addEventListener(UI.ToolbarButton.Events.Click, this._addButtonClicked.bind(this));
this._refreshButton = new UI.ToolbarButton(Common.UIString('Refresh'), 'largeicon-refresh');
this._refreshButton = new UI.ToolbarButton(ls`Refresh watch expressions`, 'largeicon-refresh');
this._refreshButton.addEventListener(UI.ToolbarButton.Events.Click, this.update, this);
this.contentElement.classList.add('watch-expressions');
......
......@@ -114,9 +114,6 @@
<message name="IDS_DEVTOOLS_3831f64f248899a06a6bbc8b82fccfdf" desc="Text in Breakpoint Edit Dialog of the Sources panel">
Log message, e.g. &apos;x is&apos;, x
</message>
<message name="IDS_DEVTOOLS_38b6dddcf45b3d2c9fc86ce4dd2592ba" desc="Tooltip text that appears when hovering over the largeicon add button in the Watch Expressions Sidebar Pane of the Sources panel">
Add expression
</message>
<message name="IDS_DEVTOOLS_3a4c2017c43ba6b63be4576d17893645" desc="Text in Debugger Plugin of the Sources panel">
Source map found, but ignored for blackboxed file.
</message>
......@@ -477,6 +474,9 @@
<message name="IDS_DEVTOOLS_f0a47f037ca7a988466a647277ef1134" desc="Text in Debugger Paused Message of the Sources panel">
Paused on assertion
</message>
<message name="IDS_DEVTOOLS_f156b89abea73d4db0bf1b212d198c41" desc="Tooltip/screen reader label of a button in the Sources panel that refreshes all watch expressions.">
Refresh watch expressions
</message>
<message name="IDS_DEVTOOLS_f20658650d987d31063b593c05980397" desc="Title of the sources watch">
Watch
</message>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment