Commit b9d71ced authored by ewannpv's avatar ewannpv Committed by Commit Bot

Updates location bar & toolbar icons

- Adds new security indicator icons that are more visually balanced with the origin label.
- Adds new share icon that is more consistent in weight to the other toolbar icons, and who’s scale is feels more appropriate inside the Omnibox.
- Adds new toolbar icons that distinguish from Safari and are more GM2 compliant.

Before:
https://drive.google.com/a/google.com/file/d/1eAM4B9XFHt6iZx6c9Swks_7Qj9lL4FIF/view?usp=sharing

After:
https://drive.google.com/a/google.com/file/d/1Zxbv1RYuBuzjDrxSKS_QJ7ZOVQUHarNo/view?usp=sharing

Bug: 1035850

Change-Id: I70cac1b64833fd9921bbc9db868862aedd797391
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974090Reviewed-by: default avatarSylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726388}
parent ae510970
...@@ -52,7 +52,6 @@ imageset("omnibox_voice") { ...@@ -52,7 +52,6 @@ imageset("omnibox_voice") {
imageset("location_bar_share") { imageset("location_bar_share") {
sources = [ sources = [
"location_bar_share.imageset/Contents.json", "location_bar_share.imageset/Contents.json",
"location_bar_share.imageset/location_bar_share.png",
"location_bar_share.imageset/location_bar_share@2x.png", "location_bar_share.imageset/location_bar_share@2x.png",
"location_bar_share.imageset/location_bar_share@3x.png", "location_bar_share.imageset/location_bar_share@3x.png",
] ]
...@@ -79,7 +78,6 @@ imageset("location_bar_offline") { ...@@ -79,7 +78,6 @@ imageset("location_bar_offline") {
imageset("location_bar_secure") { imageset("location_bar_secure") {
sources = [ sources = [
"location_bar_secure.imageset/Contents.json", "location_bar_secure.imageset/Contents.json",
"location_bar_secure.imageset/location_bar_secure.png",
"location_bar_secure.imageset/location_bar_secure@2x.png", "location_bar_secure.imageset/location_bar_secure@2x.png",
"location_bar_secure.imageset/location_bar_secure@3x.png", "location_bar_secure.imageset/location_bar_secure@3x.png",
] ]
......
{ {
"images": [ "images": [
{
"idiom": "universal",
"scale": "1x",
"filename": "location_bar_secure.png"
},
{ {
"idiom": "universal", "idiom": "universal",
"scale": "2x", "scale": "2x",
......
{ {
"images": [ "images": [
{
"idiom": "universal",
"scale": "1x",
"filename": "location_bar_share.png"
},
{ {
"idiom": "universal", "idiom": "universal",
"scale": "2x", "scale": "2x",
......
...@@ -90,7 +90,6 @@ imageset("toolbar_share") { ...@@ -90,7 +90,6 @@ imageset("toolbar_share") {
imageset("toolbar_back") { imageset("toolbar_back") {
sources = [ sources = [
"toolbar_back.imageset/Contents.json", "toolbar_back.imageset/Contents.json",
"toolbar_back.imageset/toolbar_back.png",
"toolbar_back.imageset/toolbar_back@2x.png", "toolbar_back.imageset/toolbar_back@2x.png",
"toolbar_back.imageset/toolbar_back@3x.png", "toolbar_back.imageset/toolbar_back@3x.png",
] ]
...@@ -108,7 +107,6 @@ imageset("toolbar_switcher") { ...@@ -108,7 +107,6 @@ imageset("toolbar_switcher") {
imageset("toolbar_forward") { imageset("toolbar_forward") {
sources = [ sources = [
"toolbar_forward.imageset/Contents.json", "toolbar_forward.imageset/Contents.json",
"toolbar_forward.imageset/toolbar_forward.png",
"toolbar_forward.imageset/toolbar_forward@2x.png", "toolbar_forward.imageset/toolbar_forward@2x.png",
"toolbar_forward.imageset/toolbar_forward@3x.png", "toolbar_forward.imageset/toolbar_forward@3x.png",
] ]
......
{ {
"images": [ "images": [
{
"idiom": "universal",
"scale": "1x",
"filename": "toolbar_back.png"
},
{ {
"idiom": "universal", "idiom": "universal",
"scale": "2x", "scale": "2x",
......
{ {
"images": [ "images": [
{
"idiom": "universal",
"scale": "1x",
"filename": "toolbar_forward.png"
},
{ {
"idiom": "universal", "idiom": "universal",
"scale": "2x", "scale": "2x",
......
...@@ -16,7 +16,7 @@ const CGFloat kNTPBackgroundColorBrightnessIncognito = 34.0 / 255.0; ...@@ -16,7 +16,7 @@ const CGFloat kNTPBackgroundColorBrightnessIncognito = 34.0 / 255.0;
const CGFloat kTopButtonsBottomMargin = 3.0f; const CGFloat kTopButtonsBottomMargin = 3.0f;
const CGFloat kBottomButtonsBottomMargin = 2.0f; const CGFloat kBottomButtonsBottomMargin = 2.0f;
const CGFloat kAdaptiveToolbarMargin = 4.0f; const CGFloat kAdaptiveToolbarMargin = 10.0f;
const CGFloat kAdaptiveToolbarStackViewSpacing = 11.0f; const CGFloat kAdaptiveToolbarStackViewSpacing = 11.0f;
const CGFloat kProgressBarHeight = 2.0f; const CGFloat kProgressBarHeight = 2.0f;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment