Commit b9eb1a9c authored by Mohamed Heikal's avatar Mohamed Heikal Committed by Commit Bot

Use AtomicOutput in process_native_prebuilt.py

eu-strip's output keeps mode from source file which might not be
writable thus it fails to override its output on the next run.
AtomicOutput fixes the issue. Also it is good practice anyways.

Change-Id: I7b3574dac55cc44e6d0572704f26e42969331ddc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458786
Auto-Submit: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: default avatarSam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814841}
parent f3572798
...@@ -20,14 +20,17 @@ def main(args): ...@@ -20,14 +20,17 @@ def main(args):
parser.add_argument('--unstripped-output-path', required=True, help='') parser.add_argument('--unstripped-output-path', required=True, help='')
options = parser.parse_args(args) options = parser.parse_args(args)
cmd = [ # eu-strip's output keeps mode from source file which might not be writable
options.strip_path, # thus it fails to override its output on the next run. AtomicOutput fixes
options.input_path, # the issue.
'-o', with build_utils.AtomicOutput(options.stripped_output_path) as out:
options.stripped_output_path, cmd = [
] options.strip_path,
options.input_path,
build_utils.CheckOutput(cmd) '-o',
out.name,
]
build_utils.CheckOutput(cmd)
shutil.copyfile(options.input_path, options.unstripped_output_path) shutil.copyfile(options.input_path, options.unstripped_output_path)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment