Commit b9f360a1 authored by Paul Irish's avatar Paul Irish Committed by Commit Bot

DevTools: Roll Lighthouse to 4.1.0

Changelog: https://github.com/googlechrome/lighthouse/compare/v4.0.0...v4.1.0

Change-Id: Ief76c7c2d0fb4b44e9332b91c2a6bb99f46a9d2e
Bug: 772558
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506382
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: default avatarErik Luo <luoe@chromium.org>
Auto-Submit: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638298}
parent 648ae960
...@@ -208,7 +208,7 @@ class ReportRenderer { ...@@ -208,7 +208,7 @@ class ReportRenderer {
// Fireworks // Fireworks
const scoresAll100 = report.reportCategories.every(cat => cat.score === 1); const scoresAll100 = report.reportCategories.every(cat => cat.score === 1);
if (scoresAll100 && !this._dom.isDevTools()) { if (!this._dom.isDevTools() && scoresAll100) {
headerContainer.classList.add('score100'); headerContainer.classList.add('score100');
this._dom.find('.lh-header', headerContainer).addEventListener('click', _ => { this._dom.find('.lh-header', headerContainer).addEventListener('click', _ => {
headerContainer.classList.toggle('fireworks-paused'); headerContainer.classList.toggle('fireworks-paused');
......
...@@ -30,7 +30,7 @@ class ReportUIFeatures { ...@@ -30,7 +30,7 @@ class ReportUIFeatures {
* @param {DOM} dom * @param {DOM} dom
*/ */
constructor(dom) { constructor(dom) {
/** @type {LH.ReportResult} */ /** @type {LH.Result} */
this.json; // eslint-disable-line no-unused-expressions this.json; // eslint-disable-line no-unused-expressions
/** @type {DOM} */ /** @type {DOM} */
this._dom = dom; this._dom = dom;
...@@ -80,7 +80,7 @@ class ReportUIFeatures { ...@@ -80,7 +80,7 @@ class ReportUIFeatures {
/** /**
* Adds export button, print, and other functionality to the report. The method * Adds export button, print, and other functionality to the report. The method
* should be called whenever the report needs to be re-rendered. * should be called whenever the report needs to be re-rendered.
* @param {LH.ReportResult} report * @param {LH.Result} report
*/ */
initFeatures(report) { initFeatures(report) {
if (this._dom.isDevTools()) return; if (this._dom.isDevTools()) return;
...@@ -358,7 +358,7 @@ class ReportUIFeatures { ...@@ -358,7 +358,7 @@ class ReportUIFeatures {
/** /**
* Opens a new tab to the online viewer and sends the local page's JSON results * Opens a new tab to the online viewer and sends the local page's JSON results
* to the online viewer using postMessage. * to the online viewer using postMessage.
* @param {LH.ReportResult} reportJson * @param {LH.Result} reportJson
* @param {string} viewerPath * @param {string} viewerPath
* @protected * @protected
*/ */
......
...@@ -24,15 +24,14 @@ Initializing… ...@@ -24,15 +24,14 @@ Initializing…
Running beforePass methods Running beforePass methods
Retrieving setup: Scripts Retrieving setup: Scripts
Retrieving setup: CSSUsage Retrieving setup: CSSUsage
Retrieving setup: Viewport
Retrieving setup: ViewportDimensions Retrieving setup: ViewportDimensions
Retrieving setup: ThemeColor
Retrieving setup: Manifest Retrieving setup: Manifest
Retrieving setup: RuntimeExceptions Retrieving setup: RuntimeExceptions
Retrieving setup: ChromeConsoleMessages Retrieving setup: ChromeConsoleMessages
Retrieving setup: ImageUsage
Retrieving setup: Accessibility Retrieving setup: Accessibility
Retrieving setup: ImageElements
Retrieving setup: LinkElements Retrieving setup: LinkElements
Retrieving setup: MetaElements
Retrieving setup: AnchorsWithNoRelNoopener Retrieving setup: AnchorsWithNoRelNoopener
Retrieving setup: AppCacheManifest Retrieving setup: AppCacheManifest
Retrieving setup: Doctype Retrieving setup: Doctype
...@@ -42,10 +41,8 @@ Retrieving setup: OptimizedImages ...@@ -42,10 +41,8 @@ Retrieving setup: OptimizedImages
Retrieving setup: PasswordInputsWithPreventedPaste Retrieving setup: PasswordInputsWithPreventedPaste
Retrieving setup: ResponseCompression Retrieving setup: ResponseCompression
Retrieving setup: TagsBlockingFirstPaint Retrieving setup: TagsBlockingFirstPaint
Retrieving setup: MetaDescription
Retrieving setup: FontSize Retrieving setup: FontSize
Retrieving setup: CrawlableLinks Retrieving setup: CrawlableLinks
Retrieving setup: MetaRobots
Retrieving setup: Hreflang Retrieving setup: Hreflang
Retrieving setup: EmbeddedContent Retrieving setup: EmbeddedContent
Retrieving setup: Canonical Retrieving setup: Canonical
...@@ -55,15 +52,14 @@ Getting browser version ...@@ -55,15 +52,14 @@ Getting browser version
Running pass methods Running pass methods
Retrieving in-page: Scripts Retrieving in-page: Scripts
Retrieving in-page: CSSUsage Retrieving in-page: CSSUsage
Retrieving in-page: Viewport
Retrieving in-page: ViewportDimensions Retrieving in-page: ViewportDimensions
Retrieving in-page: ThemeColor
Retrieving in-page: Manifest Retrieving in-page: Manifest
Retrieving in-page: RuntimeExceptions Retrieving in-page: RuntimeExceptions
Retrieving in-page: ChromeConsoleMessages Retrieving in-page: ChromeConsoleMessages
Retrieving in-page: ImageUsage
Retrieving in-page: Accessibility Retrieving in-page: Accessibility
Retrieving in-page: ImageElements
Retrieving in-page: LinkElements Retrieving in-page: LinkElements
Retrieving in-page: MetaElements
Retrieving in-page: AnchorsWithNoRelNoopener Retrieving in-page: AnchorsWithNoRelNoopener
Retrieving in-page: AppCacheManifest Retrieving in-page: AppCacheManifest
Retrieving in-page: Doctype Retrieving in-page: Doctype
...@@ -73,10 +69,8 @@ Retrieving in-page: OptimizedImages ...@@ -73,10 +69,8 @@ Retrieving in-page: OptimizedImages
Retrieving in-page: PasswordInputsWithPreventedPaste Retrieving in-page: PasswordInputsWithPreventedPaste
Retrieving in-page: ResponseCompression Retrieving in-page: ResponseCompression
Retrieving in-page: TagsBlockingFirstPaint Retrieving in-page: TagsBlockingFirstPaint
Retrieving in-page: MetaDescription
Retrieving in-page: FontSize Retrieving in-page: FontSize
Retrieving in-page: CrawlableLinks Retrieving in-page: CrawlableLinks
Retrieving in-page: MetaRobots
Retrieving in-page: Hreflang Retrieving in-page: Hreflang
Retrieving in-page: EmbeddedContent Retrieving in-page: EmbeddedContent
Retrieving in-page: Canonical Retrieving in-page: Canonical
...@@ -86,15 +80,14 @@ Retrieving devtoolsLog & network records ...@@ -86,15 +80,14 @@ Retrieving devtoolsLog & network records
Running afterPass methods Running afterPass methods
Retrieving: Scripts Retrieving: Scripts
Retrieving: CSSUsage Retrieving: CSSUsage
Retrieving: Viewport
Retrieving: ViewportDimensions Retrieving: ViewportDimensions
Retrieving: ThemeColor
Retrieving: Manifest Retrieving: Manifest
Retrieving: RuntimeExceptions Retrieving: RuntimeExceptions
Retrieving: ChromeConsoleMessages Retrieving: ChromeConsoleMessages
Retrieving: ImageUsage
Retrieving: Accessibility Retrieving: Accessibility
Retrieving: ImageElements
Retrieving: LinkElements Retrieving: LinkElements
Retrieving: MetaElements
Retrieving: AnchorsWithNoRelNoopener Retrieving: AnchorsWithNoRelNoopener
Retrieving: AppCacheManifest Retrieving: AppCacheManifest
Retrieving: Doctype Retrieving: Doctype
...@@ -104,10 +97,8 @@ Retrieving: OptimizedImages ...@@ -104,10 +97,8 @@ Retrieving: OptimizedImages
Retrieving: PasswordInputsWithPreventedPaste Retrieving: PasswordInputsWithPreventedPaste
Retrieving: ResponseCompression Retrieving: ResponseCompression
Retrieving: TagsBlockingFirstPaint Retrieving: TagsBlockingFirstPaint
Retrieving: MetaDescription
Retrieving: FontSize Retrieving: FontSize
Retrieving: CrawlableLinks Retrieving: CrawlableLinks
Retrieving: MetaRobots
Retrieving: Hreflang Retrieving: Hreflang
Retrieving: EmbeddedContent Retrieving: EmbeddedContent
Retrieving: Canonical Retrieving: Canonical
...@@ -282,7 +273,7 @@ Generating results... ...@@ -282,7 +273,7 @@ Generating results...
=============== Lighthouse Results =============== =============== Lighthouse Results ===============
URL: http://127.0.0.1:8000/devtools/resources/inspected-page.html URL: http://127.0.0.1:8000/devtools/resources/inspected-page.html
Version: 4.0.0 Version: 4.1.0
accesskeys: manual accesskeys: manual
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment