Revert "Remove NotEnumerable from Writable Streams WebIDL"

This reverts commit a2505c5b.

Reason for revert: Broken bots, possibly caused by CQ collision. See https://crbug.com/1140836

Original change's description:
> Remove NotEnumerable from Writable Streams WebIDL
>
> According to https://github.com/whatwg/streams/pull/1035, all methods
> and accessors are now enumerable, per Web IDL defaults, instead of
> non-enumerable, per ECMAScript defaults. Hence, 'NotEnumerable' can
> be removed from the Streams WebIDL files. This CL specifically
> removes them from writable streams.
>
> Bug: 1093862
> Change-Id: I935a9f8726b3cb1dc4efb5b4d6db71384c8efe37
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485664
> Reviewed-by: Adam Rice <ricea@chromium.org>
> Commit-Queue: Nidhi Jaju <nidhijaju@google.com>
> Cr-Commit-Position: refs/heads/master@{#819181}

TBR=ricea@chromium.org,nidhijaju@google.com

Change-Id: I3f49640931f5968e1127664f6d755525dcdb9543
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1093862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489062Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819225}

third_party/blink/renderer/core/streams/writable_stream.idl

@@ -7,9 +7,9 @@
     Exposed=(Window,Worker,Worklet)
 ] interface WritableStream {
     [CallWith=ScriptState, RaisesException, MeasureAs=WritableStreamConstructor] constructor(optional any underlyingSink, optional any strategy);
-    readonly attribute boolean locked;
-    [RaisesException, CallWith=ScriptState] Promise<void> abort(
+    [NotEnumerable] readonly attribute boolean locked;
+    [RaisesException, CallWith=ScriptState, NotEnumerable] Promise<void> abort(
         optional any reason);
-    [RaisesException, CallWith=ScriptState] Promise<void> close();
-    [RaisesException, CallWith=ScriptState] WritableStreamDefaultWriter getWriter();
+    [RaisesException, CallWith=ScriptState, NotEnumerable] Promise<void> close();
+    [RaisesException, CallWith=ScriptState, NotEnumerable] WritableStreamDefaultWriter getWriter();
 };

third_party/blink/renderer/core/streams/writable_stream_default_controller.idl

@@ -6,5 +6,5 @@
 
 // https://streams.spec.whatwg.org/#ws-default-controller-class-definition
 interface WritableStreamDefaultController {
-    [CallWith=ScriptState] void error(optional any e);
+    [CallWith=ScriptState, NotEnumerable] void error(optional any e);
 };

third_party/blink/renderer/core/streams/writable_stream_default_writer.idl

@@ -9,17 +9,17 @@
     Exposed=(Window,Worker,Worklet)
 ] interface WritableStreamDefaultWriter {
     [CallWith=ScriptState, RaisesException] constructor(WritableStream stream);
-    [CallWith=ScriptState] readonly attribute Promise<void>
+    [CallWith=ScriptState, NotEnumerable] readonly attribute Promise<void>
         closed;
-    [RaisesException, CallWith=ScriptState] readonly attribute
+    [RaisesException, CallWith=ScriptState, NotEnumerable] readonly attribute
         any desiredSize;
-    [CallWith=ScriptState] readonly attribute Promise<void>
+    [CallWith=ScriptState, NotEnumerable] readonly attribute Promise<void>
         ready;
 
-    [CallWith=ScriptState, RaisesException] Promise<void> abort(
+    [CallWith=ScriptState, RaisesException, NotEnumerable] Promise<void> abort(
         optional any reason);
-    [CallWith=ScriptState, RaisesException] Promise<void> close();
+    [CallWith=ScriptState, RaisesException, NotEnumerable] Promise<void> close();
     [CallWith=ScriptState, NotEnumerable] void releaseLock();
-    [CallWith=ScriptState, RaisesException] Promise<void> write(
+    [CallWith=ScriptState, RaisesException, NotEnumerable] Promise<void> write(
         optional any chunk);
 };

third_party/blink/web_tests/external/wpt/streams/idlharness.any-expected.txt

@@ -124,10 +124,10 @@ PASS WritableStream interface object name
 PASS WritableStream interface: existence and properties of interface prototype object
 PASS WritableStream interface: existence and properties of interface prototype object's "constructor" property
 PASS WritableStream interface: existence and properties of interface prototype object's @@unscopables property
-PASS WritableStream interface: attribute locked
-PASS WritableStream interface: operation abort(optional any)
-PASS WritableStream interface: operation close()
-PASS WritableStream interface: operation getWriter()
+FAIL WritableStream interface: attribute locked assert_true: property should be enumerable expected true got false
+FAIL WritableStream interface: operation abort(optional any) assert_true: property should be enumerable expected true got false
+FAIL WritableStream interface: operation close() assert_true: property should be enumerable expected true got false
+FAIL WritableStream interface: operation getWriter() assert_true: property should be enumerable expected true got false
 PASS WritableStream must be primary interface of new WritableStream()
 PASS Stringification of new WritableStream()
 PASS WritableStream interface: new WritableStream() must inherit property "locked" with the proper type
@@ -141,13 +141,13 @@ PASS WritableStreamDefaultWriter interface object name
 PASS WritableStreamDefaultWriter interface: existence and properties of interface prototype object
 PASS WritableStreamDefaultWriter interface: existence and properties of interface prototype object's "constructor" property
 PASS WritableStreamDefaultWriter interface: existence and properties of interface prototype object's @@unscopables property
-PASS WritableStreamDefaultWriter interface: attribute closed
-PASS WritableStreamDefaultWriter interface: attribute desiredSize
-PASS WritableStreamDefaultWriter interface: attribute ready
-PASS WritableStreamDefaultWriter interface: operation abort(optional any)
-PASS WritableStreamDefaultWriter interface: operation close()
+FAIL WritableStreamDefaultWriter interface: attribute closed assert_true: property should be enumerable expected true got false
+FAIL WritableStreamDefaultWriter interface: attribute desiredSize assert_true: property should be enumerable expected true got false
+FAIL WritableStreamDefaultWriter interface: attribute ready assert_true: property should be enumerable expected true got false
+FAIL WritableStreamDefaultWriter interface: operation abort(optional any) assert_true: property should be enumerable expected true got false
+FAIL WritableStreamDefaultWriter interface: operation close() assert_true: property should be enumerable expected true got false
 FAIL WritableStreamDefaultWriter interface: operation releaseLock() assert_true: property should be enumerable expected true got false
-PASS WritableStreamDefaultWriter interface: operation write(optional any)
+FAIL WritableStreamDefaultWriter interface: operation write(optional any) assert_true: property should be enumerable expected true got false
 PASS WritableStreamDefaultWriter must be primary interface of (new WritableStream()).getWriter()
 PASS Stringification of (new WritableStream()).getWriter()
 PASS WritableStreamDefaultWriter interface: (new WritableStream()).getWriter() must inherit property "closed" with the proper type

third_party/blink/web_tests/external/wpt/streams/idlharness.any.serviceworker-expected.txt

@@ -124,10 +124,10 @@ PASS WritableStream interface object name
 PASS WritableStream interface: existence and properties of interface prototype object
 PASS WritableStream interface: existence and properties of interface prototype object's "constructor" property
 PASS WritableStream interface: existence and properties of interface prototype object's @@unscopables property
-PASS WritableStream interface: attribute locked
-PASS WritableStream interface: operation abort(optional any)
-PASS WritableStream interface: operation close()
-PASS WritableStream interface: operation getWriter()
+FAIL WritableStream interface: attribute locked assert_true: property should be enumerable expected true got false
+FAIL WritableStream interface: operation abort(optional any) assert_true: property should be enumerable expected true got false
+FAIL WritableStream interface: operation close() assert_true: property should be enumerable expected true got false
+FAIL WritableStream interface: operation getWriter() assert_true: property should be enumerable expected true got false
 PASS WritableStream must be primary interface of new WritableStream()
 PASS Stringification of new WritableStream()
 PASS WritableStream interface: new WritableStream() must inherit property "locked" with the proper type
@@ -141,13 +141,13 @@ PASS WritableStreamDefaultWriter interface object name
 PASS WritableStreamDefaultWriter interface: existence and properties of interface prototype object
 PASS WritableStreamDefaultWriter interface: existence and properties of interface prototype object's "constructor" property
 PASS WritableStreamDefaultWriter interface: existence and properties of interface prototype object's @@unscopables property
-PASS WritableStreamDefaultWriter interface: attribute closed
-PASS WritableStreamDefaultWriter interface: attribute desiredSize
-PASS WritableStreamDefaultWriter interface: attribute ready
-PASS WritableStreamDefaultWriter interface: operation abort(optional any)
-PASS WritableStreamDefaultWriter interface: operation close()
+FAIL WritableStreamDefaultWriter interface: attribute closed assert_true: property should be enumerable expected true got false
+FAIL WritableStreamDefaultWriter interface: attribute desiredSize assert_true: property should be enumerable expected true got false
+FAIL WritableStreamDefaultWriter interface: attribute ready assert_true: property should be enumerable expected true got false
+FAIL WritableStreamDefaultWriter interface: operation abort(optional any) assert_true: property should be enumerable expected true got false
+FAIL WritableStreamDefaultWriter interface: operation close() assert_true: property should be enumerable expected true got false
 FAIL WritableStreamDefaultWriter interface: operation releaseLock() assert_true: property should be enumerable expected true got false
-PASS WritableStreamDefaultWriter interface: operation write(optional any)
+FAIL WritableStreamDefaultWriter interface: operation write(optional any) assert_true: property should be enumerable expected true got false
 PASS WritableStreamDefaultWriter must be primary interface of (new WritableStream()).getWriter()
 PASS Stringification of (new WritableStream()).getWriter()
 PASS WritableStreamDefaultWriter interface: (new WritableStream()).getWriter() must inherit property "closed" with the proper type

third_party/blink/web_tests/external/wpt/streams/idlharness.any.sharedworker-expected.txt

@@ -124,10 +124,10 @@ PASS WritableStream interface object name
 PASS WritableStream interface: existence and properties of interface prototype object
 PASS WritableStream interface: existence and properties of interface prototype object's "constructor" property
 PASS WritableStream interface: existence and properties of interface prototype object's @@unscopables property
-PASS WritableStream interface: attribute locked
-PASS WritableStream interface: operation abort(optional any)
-PASS WritableStream interface: operation close()
-PASS WritableStream interface: operation getWriter()
+FAIL WritableStream interface: attribute locked assert_true: property should be enumerable expected true got false
+FAIL WritableStream interface: operation abort(optional any) assert_true: property should be enumerable expected true got false
+FAIL WritableStream interface: operation close() assert_true: property should be enumerable expected true got false
+FAIL WritableStream interface: operation getWriter() assert_true: property should be enumerable expected true got false
 PASS WritableStream must be primary interface of new WritableStream()
 PASS Stringification of new WritableStream()
 PASS WritableStream interface: new WritableStream() must inherit property "locked" with the proper type
@@ -141,13 +141,13 @@ PASS WritableStreamDefaultWriter interface object name
 PASS WritableStreamDefaultWriter interface: existence and properties of interface prototype object
 PASS WritableStreamDefaultWriter interface: existence and properties of interface prototype object's "constructor" property
 PASS WritableStreamDefaultWriter interface: existence and properties of interface prototype object's @@unscopables property
-PASS WritableStreamDefaultWriter interface: attribute closed
-PASS WritableStreamDefaultWriter interface: attribute desiredSize
-PASS WritableStreamDefaultWriter interface: attribute ready
-PASS WritableStreamDefaultWriter interface: operation abort(optional any)
-PASS WritableStreamDefaultWriter interface: operation close()
+FAIL WritableStreamDefaultWriter interface: attribute closed assert_true: property should be enumerable expected true got false
+FAIL WritableStreamDefaultWriter interface: attribute desiredSize assert_true: property should be enumerable expected true got false
+FAIL WritableStreamDefaultWriter interface: attribute ready assert_true: property should be enumerable expected true got false
+FAIL WritableStreamDefaultWriter interface: operation abort(optional any) assert_true: property should be enumerable expected true got false
+FAIL WritableStreamDefaultWriter interface: operation close() assert_true: property should be enumerable expected true got false
 FAIL WritableStreamDefaultWriter interface: operation releaseLock() assert_true: property should be enumerable expected true got false
-PASS WritableStreamDefaultWriter interface: operation write(optional any)
+FAIL WritableStreamDefaultWriter interface: operation write(optional any) assert_true: property should be enumerable expected true got false
 PASS WritableStreamDefaultWriter must be primary interface of (new WritableStream()).getWriter()
 PASS Stringification of (new WritableStream()).getWriter()
 PASS WritableStreamDefaultWriter interface: (new WritableStream()).getWriter() must inherit property "closed" with the proper type

third_party/blink/web_tests/external/wpt/streams/idlharness.any.worker-expected.txt

@@ -124,10 +124,10 @@ PASS WritableStream interface object name
 PASS WritableStream interface: existence and properties of interface prototype object
 PASS WritableStream interface: existence and properties of interface prototype object's "constructor" property
 PASS WritableStream interface: existence and properties of interface prototype object's @@unscopables property
-PASS WritableStream interface: attribute locked
-PASS WritableStream interface: operation abort(optional any)
-PASS WritableStream interface: operation close()
-PASS WritableStream interface: operation getWriter()
+FAIL WritableStream interface: attribute locked assert_true: property should be enumerable expected true got false
+FAIL WritableStream interface: operation abort(optional any) assert_true: property should be enumerable expected true got false
+FAIL WritableStream interface: operation close() assert_true: property should be enumerable expected true got false
+FAIL WritableStream interface: operation getWriter() assert_true: property should be enumerable expected true got false
 PASS WritableStream must be primary interface of new WritableStream()
 PASS Stringification of new WritableStream()
 PASS WritableStream interface: new WritableStream() must inherit property "locked" with the proper type
@@ -141,13 +141,13 @@ PASS WritableStreamDefaultWriter interface object name
 PASS WritableStreamDefaultWriter interface: existence and properties of interface prototype object
 PASS WritableStreamDefaultWriter interface: existence and properties of interface prototype object's "constructor" property
 PASS WritableStreamDefaultWriter interface: existence and properties of interface prototype object's @@unscopables property
-PASS WritableStreamDefaultWriter interface: attribute closed
-PASS WritableStreamDefaultWriter interface: attribute desiredSize
-PASS WritableStreamDefaultWriter interface: attribute ready
-PASS WritableStreamDefaultWriter interface: operation abort(optional any)
-PASS WritableStreamDefaultWriter interface: operation close()
+FAIL WritableStreamDefaultWriter interface: attribute closed assert_true: property should be enumerable expected true got false
+FAIL WritableStreamDefaultWriter interface: attribute desiredSize assert_true: property should be enumerable expected true got false
+FAIL WritableStreamDefaultWriter interface: attribute ready assert_true: property should be enumerable expected true got false
+FAIL WritableStreamDefaultWriter interface: operation abort(optional any) assert_true: property should be enumerable expected true got false
+FAIL WritableStreamDefaultWriter interface: operation close() assert_true: property should be enumerable expected true got false
 FAIL WritableStreamDefaultWriter interface: operation releaseLock() assert_true: property should be enumerable expected true got false
-PASS WritableStreamDefaultWriter interface: operation write(optional any)
+FAIL WritableStreamDefaultWriter interface: operation write(optional any) assert_true: property should be enumerable expected true got false
 PASS WritableStreamDefaultWriter must be primary interface of (new WritableStream()).getWriter()
 PASS Stringification of (new WritableStream()).getWriter()
 PASS WritableStreamDefaultWriter interface: (new WritableStream()).getWriter() must inherit property "closed" with the proper type