Commit ba2146cd authored by chrisgao@chromium.org's avatar chrisgao@chromium.org

[chromedriver] Fix error due to remove of chrome/test/pylib/common.

Also fix some pylint warnings.

BUG=none
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/17428004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207900 0039d316-1c4b-4281-b951-d872f2087c98
parent a635f36b
...@@ -6,13 +6,9 @@ ...@@ -6,13 +6,9 @@
import os import os
import platform import platform
import sys
import urllib import urllib
_THIS_DIR = os.path.abspath(os.path.dirname(__file__)) import util
sys.path.insert(0, os.path.join(_THIS_DIR, os.pardir, 'pylib'))
from common import util
CHROME_27_REVISION = '190466' CHROME_27_REVISION = '190466'
CHROME_28_REVISION = '198276' CHROME_28_REVISION = '198276'
......
...@@ -11,11 +11,9 @@ tests in various environments. ...@@ -11,11 +11,9 @@ tests in various environments.
import os import os
import sys import sys
_THIS_DIR = os.path.abspath(os.path.dirname(__file__)) import util
sys.path.insert(0, os.path.join(_THIS_DIR, os.pardir, 'pylib'))
from common import util _THIS_DIR = os.path.abspath(os.path.dirname(__file__))
if util.IsLinux(): if util.IsLinux():
sys.path.insert(0, os.path.join(_THIS_DIR, os.pardir, os.pardir, os.pardir, sys.path.insert(0, os.path.join(_THIS_DIR, os.pardir, os.pardir, os.pardir,
...@@ -78,7 +76,7 @@ class BaseTestEnvironment(object): ...@@ -78,7 +76,7 @@ class BaseTestEnvironment(object):
class DesktopTestEnvironment(BaseTestEnvironment): class DesktopTestEnvironment(BaseTestEnvironment):
"""Manages the environment java tests require to run on Desktop.""" """Manages the environment java tests require to run on Desktop."""
#override # override
def GetOS(self): def GetOS(self):
return util.GetPlatformName() return util.GetPlatformName()
...@@ -91,7 +89,7 @@ class AndroidTestEnvironment(DesktopTestEnvironment): ...@@ -91,7 +89,7 @@ class AndroidTestEnvironment(DesktopTestEnvironment):
self._adb = None self._adb = None
self._forwarder = None self._forwarder = None
#override # override
def GlobalSetUp(self): def GlobalSetUp(self):
os.putenv('TEST_HTTP_PORT', str(ANDROID_TEST_HTTP_PORT)) os.putenv('TEST_HTTP_PORT', str(ANDROID_TEST_HTTP_PORT))
os.putenv('TEST_HTTPS_PORT', str(ANDROID_TEST_HTTPS_PORT)) os.putenv('TEST_HTTPS_PORT', str(ANDROID_TEST_HTTPS_PORT))
...@@ -102,13 +100,13 @@ class AndroidTestEnvironment(DesktopTestEnvironment): ...@@ -102,13 +100,13 @@ class AndroidTestEnvironment(DesktopTestEnvironment):
(ANDROID_TEST_HTTPS_PORT, ANDROID_TEST_HTTPS_PORT)], (ANDROID_TEST_HTTPS_PORT, ANDROID_TEST_HTTPS_PORT)],
valgrind_tools.BaseTool(), '127.0.0.1') valgrind_tools.BaseTool(), '127.0.0.1')
#override # override
def GlobalTearDown(self): def GlobalTearDown(self):
if self._adb is not None: if self._adb is not None:
forwarder.Forwarder.KillDevice(self._adb, valgrind_tools.BaseTool()) forwarder.Forwarder.KillDevice(self._adb, valgrind_tools.BaseTool())
if self._forwarder is not None: if self._forwarder is not None:
self._forwarder.Close() self._forwarder.Close()
#override # override
def GetOS(self): def GetOS(self):
return 'android' return 'android'
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment