Skip to content

GitLab

T
tangled
Commit ba226b50 authored by Xianzhu Wang's avatar Xianzhu Wang Committed by Commit Bot
Browse files
Options

Deflake media/video-layer-crash.html 

Previously the test flakily failed because of the video might be empty
when the test ended.

Convert the test into a testharness test to avoid the flakiness.
As this test just ensures it doesn't crash, we just expect the test
finishes without crash.

Bug: 1082820
Change-Id: I846b8cb2f66641759f8a349ef864747c1b95cb1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204830
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: default avatarThomas Guilbert <tguilbert@chromium.org>
Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769896}
parent 8e1531f8
Hide whitespace changes
Inline Side-by-side
Showing with 9 additions and 5 deletions
third_party/blink/web_tests/TestExpectations
View file @ ba226b50
......@@ -5912,9 +5912,6 @@ crbug.com/984467 [ Mac Debug ] virtual/gpu/fast/canvas/canvas-composite-stroke-a
crbug.com/1078863 [ Mac ] fast/speech/scripted/speechrecognition-restart-onend.html [ Pass Timeout ]
crbug.com/1071915 fast/hidpi/image-srcset-png-canvas.html [ Pass Failure ]
# Sheriff 2020-05-14
crbug.com/1082820 [ Win ] media/video-layer-crash.html [ Pass Failure ]
# Sheriff 2020-05-18
crbug.com/1084256 [ Linux ] http/tests/misc/insert-iframe-into-xml-document-before-xsl-transform.html [ Pass Failure ]
crbug.com/1084276 [ Mac ] http/tests/security/offscreencanvas-placeholder-read-blocked-no-crossorigin.html [ Pass Failure ]
third_party/blink/web_tests/media/video-layer-crash.html
View file @ ba226b50
<html>
<head>
<script src="../resources/testharness.js"></script>
<script src="../resources/testharnessreport.js"></script>
<script src="media-file.js"></script>
<script src="video-paint-test.js"></script>
<style>
......@@ -13,8 +15,13 @@
&nbsp;<video style="transform:skew(20deg)"></video><br>
<script>
setSrcByTagName('video', 'content/test.ogv');
document.body.removeChild(document.getElementById('one')); document.body.offsetLeft;
init();
document.body.removeChild(document.getElementById('one'));
document.body.offsetLeft;
async_test(t => {
waitForMultipleEvents("canplaythrough", 2, () => {
t.done();
});
});
</script>
</body>
</html>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment