Commit ba260a81 authored by Utkarsh Patankar's avatar Utkarsh Patankar Committed by Chromium LUCI CQ

Enable minimum_chrome_version manifest key for themes

Bug: 1152517
Change-Id: I586c06b5e42d8735c3f7fec3fed69bce7e126561
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558079Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
Reviewed-by: default avatarGayane Petrosyan <gayane@chromium.org>
Commit-Queue: Utkarsh Patankar <utkpat@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#833185}
parent 766bad50
...@@ -167,7 +167,7 @@ ...@@ -167,7 +167,7 @@
"minimum_chrome_version": { "minimum_chrome_version": {
"channel": "stable", "channel": "stable",
"extension_types": [ "extension_types": [
"extension", "legacy_packaged_app", "hosted_app", "platform_app" "extension", "legacy_packaged_app", "hosted_app", "platform_app", "theme"
] ]
}, },
"natively_connectable": { "natively_connectable": {
......
...@@ -156,6 +156,9 @@ TEST_F(InitValueManifestTest, InitFromValueValid) { ...@@ -156,6 +156,9 @@ TEST_F(InitValueManifestTest, InitFromValueValid) {
// Test a hosted app with a requirements section. // Test a hosted app with a requirements section.
Testcase("init_valid_app_requirements.json"), Testcase("init_valid_app_requirements.json"),
// Test a theme with a minimum_chrome_version.
Testcase("init_valid_theme_minimum_chrome.json"),
// Verify empty permission settings are considered valid. // Verify empty permission settings are considered valid.
Testcase("init_valid_permissions_empty.json"), Testcase("init_valid_permissions_empty.json"),
......
{
"name": "Minimum Version Theme",
"manifest_version": 2,
"version": "1",
"theme": {
"colors": {
"frame": [100, 100, 100]
}
},
"minimum_chrome_version": "1.0.0.1"
}
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment