Commit ba2dc675 authored by Aran Gilman's avatar Aran Gilman Committed by Commit Bot

Use aria-labelledby instead of <label for=...>

Bug: 1027612
Change-Id: Ia1837c29aa0532f72f2493b6c84459e5d1b988a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931139
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: default avatarWei-Yin Chen (陳威尹) <wychen@chromium.org>
Auto-Submit: Aran Gilman <gilmanmh@google.com>
Cr-Commit-Position: refs/heads/master@{#722384}
parent 93ca6f19
...@@ -33,10 +33,10 @@ found in the LICENSE file. ...@@ -33,10 +33,10 @@ found in the LICENSE file.
</div> </div>
<div id="settings-fields"> <div id="settings-fields">
<div class="setting"> <div class="setting">
<label for="font-family-selection" class="screen-reader-only"> <label id="font-family-label" class="screen-reader-only">
Font Style Font Style
</label> </label>
<select id="font-family-selection" name="font-family"> <select id="font-family-selection" aria-labelledby="font-family-label" name="font-family">
<option value="sans-serif" selected>Sans-serif font</option> <option value="sans-serif" selected>Sans-serif font</option>
<option value="serif">Serif font</option> <option value="serif">Serif font</option>
<option value="monospace">Monospace font</option> <option value="monospace">Monospace font</option>
...@@ -49,37 +49,41 @@ found in the LICENSE file. ...@@ -49,37 +49,41 @@ found in the LICENSE file.
</legend> </legend>
<ul> <ul>
<li class="theme-option"> <li class="theme-option">
<label for="theme-option-light" class="screen-reader-only"> <label id="theme-option-light-label" class="screen-reader-only">
Light Light
</label> </label>
<input type="radio" name="theme" value="light" <input type="radio" name="theme" value="light"
id="theme-option-light" class="light" checked/> aria-labelledby="theme-option-light-label"
id="theme-option-light" class="light" checked>
<div class="checkmark"><i class="material-icons">check_circle</i></div> <div class="checkmark"><i class="material-icons">check_circle</i></div>
</li> </li>
<li class="theme-option"> <li class="theme-option">
<label for="theme-option-sepia" class="screen-reader-only"> <label id="theme-option-sepia-label" class="screen-reader-only">
Sepia Sepia
</label> </label>
<input type="radio" name="theme" value="sepia" <input type="radio" name="theme" value="sepia"
id="theme-option-sepia" class="sepia"/> aria-labelledby="theme-option-sepia-label"
id="theme-option-sepia" class="sepia">
<div class="checkmark"><i class="material-icons">check_circle</i></div> <div class="checkmark"><i class="material-icons">check_circle</i></div>
</li> </li>
<li class="theme-option"> <li class="theme-option">
<label for="theme-option-dark" class="screen-reader-only"> <label id="theme-option-dark-label" class="screen-reader-only">
Dark Dark
</label> </label>
<input type="radio" name="theme" value="dark" <input type="radio" name="theme" value="dark"
id="theme-option-dark" class="dark"/> aria-labelledby="theme-option-dark-label"
id="theme-option-dark" class="dark">
<div class="checkmark"><i class="material-icons">check_circle</i></div> <div class="checkmark"><i class="material-icons">check_circle</i></div>
</li> </li>
</ul> </ul>
</fieldset> </fieldset>
</div> </div>
<div class="setting" id="font-size-wrapper"> <div class="setting" id="font-size-wrapper">
<label for="font-size-selection" class="screen-reader-only"> <label id="font-size-label" class="screen-reader-only">
Font Size Font Size
</label> </label>
<input id="font-size-selection" <input aria-labelledby="font-size-label"
id="font-size-selection"
type="range" type="range"
name="font-size" name="font-size"
list="tickmarks" list="tickmarks"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment