[Media History] Use unique index names

Index names are at the DB level and some of them
are duplicated so this prefixes them all with
the table name.

BUG=1024351

Change-Id: I9e8ba700625e9d2c42f2fbeaab3ba216f450f0a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129898Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755094}

chrome/browser/media/history/media_history_feed_items_table.cc

@@ -158,7 +158,7 @@ sql::InitStatus MediaHistoryFeedItemsTable::CreateTableIfNonExistent() {
 
   if (success) {
     success = DB()->Execute(
-        "CREATE INDEX IF NOT EXISTS media_feed_item_feed_id_index ON "
+        "CREATE INDEX IF NOT EXISTS mediaFeedItem_feed_id_index ON "
         "mediaFeedItem (feed_id)");
   }
 

chrome/browser/media/history/media_history_feeds_table.cc

@@ -65,7 +65,7 @@ sql::InitStatus MediaHistoryFeedsTable::CreateTableIfNonExistent() {
   if (success) {
     success = DB()->Execute(
         base::StringPrintf(
-            "CREATE INDEX IF NOT EXISTS media_feed_origin_id_index ON "
+            "CREATE INDEX IF NOT EXISTS mediaFeed_origin_id_index ON "
             "%s (origin_id)",
             kTableName)
             .c_str());

chrome/browser/media/history/media_history_images_table.cc

@@ -40,7 +40,7 @@ sql::InitStatus MediaHistoryImagesTable::CreateTableIfNonExistent() {
   if (success) {
     success = DB()->Execute(
         base::StringPrintf(
-            "CREATE INDEX IF NOT EXISTS playback_origin_id_index ON "
+            "CREATE INDEX IF NOT EXISTS mediaImage_playback_origin_id_index ON "
             "%s (playback_origin_id)",
             kTableName)
             .c_str());
@@ -48,10 +48,10 @@ sql::InitStatus MediaHistoryImagesTable::CreateTableIfNonExistent() {
 
   if (success) {
     success = DB()->Execute(
-        base::StringPrintf(
-            "CREATE UNIQUE INDEX IF NOT EXISTS image_origin_url_index ON "
-            "%s (playback_origin_id, url)",
-            kTableName)
+        base::StringPrintf("CREATE UNIQUE INDEX IF NOT EXISTS "
+                           "mediaImage_playback_origin_id_url_index ON "
+                           "%s (playback_origin_id, url)",
+                           kTableName)
             .c_str());
   }
 

chrome/browser/media/history/media_history_playback_table.cc

@@ -43,9 +43,10 @@ sql::InitStatus MediaHistoryPlaybackTable::CreateTableIfNonExistent() {
 
   if (success) {
     success = DB()->Execute(
-        base::StringPrintf("CREATE INDEX IF NOT EXISTS origin_id_index ON "
-                           "%s (origin_id)",
-                           kTableName)
+        base::StringPrintf(
+            "CREATE INDEX IF NOT EXISTS playback_origin_id_index ON "
+            "%s (origin_id)",
+            kTableName)
             .c_str());
   }
 

chrome/browser/media/history/media_history_session_images_table.cc

@@ -48,26 +48,28 @@ sql::InitStatus MediaHistorySessionImagesTable::CreateTableIfNonExistent() {
 
   if (success) {
     success = DB()->Execute(
-        base::StringPrintf("CREATE INDEX IF NOT EXISTS session_id_index ON "
-                           "%s (session_id)",
-                           kTableName)
+        base::StringPrintf(
+            "CREATE INDEX IF NOT EXISTS sessionImage_session_id_index ON "
+            "%s (session_id)",
+            kTableName)
             .c_str());
   }
 
   if (success) {
     success = DB()->Execute(
-        base::StringPrintf("CREATE INDEX IF NOT EXISTS image_id_index ON "
-                           "%s (image_id)",
-                           kTableName)
+        base::StringPrintf(
+            "CREATE INDEX IF NOT EXISTS sessionImage_image_id_index ON "
+            "%s (image_id)",
+            kTableName)
             .c_str());
   }
 
   if (success) {
     success = DB()->Execute(
-        base::StringPrintf(
-            "CREATE UNIQUE INDEX IF NOT EXISTS session_image_index ON "
-            "%s (session_id, image_id, width, height)",
-            kTableName)
+        base::StringPrintf("CREATE UNIQUE INDEX IF NOT EXISTS "
+                           "sessionImage_session_image_index ON "
+                           "%s (session_id, image_id, width, height)",
+                           kTableName)
             .c_str());
   }
 

chrome/browser/media/history/media_history_session_table.cc

@@ -51,9 +51,10 @@ sql::InitStatus MediaHistorySessionTable::CreateTableIfNonExistent() {
 
   if (success) {
     success = DB()->Execute(
-        base::StringPrintf("CREATE INDEX IF NOT EXISTS origin_id_index ON "
-                           "%s (origin_id)",
-                           kTableName)
+        base::StringPrintf(
+            "CREATE INDEX IF NOT EXISTS playbackSession_origin_id_index ON "
+            "%s (origin_id)",
+            kTableName)
             .c_str());
   }