Commit ba38d536 authored by thakis's avatar thakis Committed by Commit bot

clang/win: Fix style plugin warnings in component debug builds.

std::iterators are classes in debug builds in MSVC, so outline
a destructor in a class that has many iterator members in net/.

Make the copy constructor of TilingSetRasterQueueAll private.
Without this, an implicit copy constructor is generated with the
ms abi because the class is marked dllexport, and the implicit
copy constructor needs a copy constructor for TilingIterator
which the plugin also wants to have out-of-line. Making the
outer dllexported class not copyable should fix this.

BUG=467287,483986

Review URL: https://codereview.chromium.org/1131023004

Cr-Commit-Position: refs/heads/master@{#329435}
parent 8ccffadd
...@@ -198,6 +198,8 @@ class CC_EXPORT TilingSetRasterQueueAll { ...@@ -198,6 +198,8 @@ class CC_EXPORT TilingSetRasterQueueAll {
// ideal pending high res. // ideal pending high res.
base::StackVector<IterationStage, 6> stages_; base::StackVector<IterationStage, 6> stages_;
TilingIterator iterators_[NUM_ITERATORS]; TilingIterator iterators_[NUM_ITERATORS];
DISALLOW_COPY_AND_ASSIGN(TilingSetRasterQueueAll);
}; };
} // namespace cc } // namespace cc
......
...@@ -20,6 +20,9 @@ HttpAuthChallengeTokenizer::HttpAuthChallengeTokenizer( ...@@ -20,6 +20,9 @@ HttpAuthChallengeTokenizer::HttpAuthChallengeTokenizer(
Init(begin, end); Init(begin, end);
} }
HttpAuthChallengeTokenizer::~HttpAuthChallengeTokenizer() {
}
HttpUtil::NameValuePairsIterator HttpAuthChallengeTokenizer::param_pairs() HttpUtil::NameValuePairsIterator HttpAuthChallengeTokenizer::param_pairs()
const { const {
return HttpUtil::NameValuePairsIterator(params_begin_, params_end_, ','); return HttpUtil::NameValuePairsIterator(params_begin_, params_end_, ',');
......
...@@ -24,6 +24,7 @@ class NET_EXPORT_PRIVATE HttpAuthChallengeTokenizer { ...@@ -24,6 +24,7 @@ class NET_EXPORT_PRIVATE HttpAuthChallengeTokenizer {
public: public:
HttpAuthChallengeTokenizer(std::string::const_iterator begin, HttpAuthChallengeTokenizer(std::string::const_iterator begin,
std::string::const_iterator end); std::string::const_iterator end);
~HttpAuthChallengeTokenizer();
// Get the original text. // Get the original text.
std::string challenge_text() const { std::string challenge_text() const {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment