Commit ba834b78 authored by Ehimare Okoyomon's avatar Ehimare Okoyomon Committed by Commit Bot

[Android] Fix Website Settings strings

Screenshot: https://crbug.com/1136533#c1
Bug: 1136533
Change-Id: I6140f9e49a723afd0dd4ae22b059784b2cf73d2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461308
Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org>
Reviewed-by: default avatarClark DuVall <cduvall@chromium.org>
Reviewed-by: default avatarChristian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816123}
parent 108d547b
...@@ -843,9 +843,9 @@ public class SingleWebsiteSettings extends SiteSettingsPreferenceFragment ...@@ -843,9 +843,9 @@ public class SingleWebsiteSettings extends SiteSettingsPreferenceFragment
*/ */
private void setUpPreferenceCommon(Preference preference) { private void setUpPreferenceCommon(Preference preference) {
int contentType = getContentSettingsTypeFromPreferenceKey(preference.getKey()); int contentType = getContentSettingsTypeFromPreferenceKey(preference.getKey());
int explanationResourceId = ContentSettingsResources.getExplanation(contentType); int titleResourceId = ContentSettingsResources.getTitle(contentType);
if (explanationResourceId != 0) { if (titleResourceId != 0) {
preference.setTitle(explanationResourceId); preference.setTitle(titleResourceId);
} }
if (!preference.isEnabled()) { if (!preference.isEnabled()) {
preference.setIcon( preference.setIcon(
......
...@@ -289,9 +289,6 @@ ...@@ -289,9 +289,6 @@
<message name="IDS_WEBSITE_SETTINGS_CATEGORY_CAMERA_ASK" desc="Summary text explaining that sites need to ask for permission before accessing the camera and that it is the recommended setting."> <message name="IDS_WEBSITE_SETTINGS_CATEGORY_CAMERA_ASK" desc="Summary text explaining that sites need to ask for permission before accessing the camera and that it is the recommended setting.">
Ask first before allowing sites to use your camera (recommended) Ask first before allowing sites to use your camera (recommended)
</message> </message>
<message name="IDS_CAMERA_PERMISSION_TITLE" desc="Title text to be shown when the user has allowed/denied video access for the website [CHAR-LIMIT=32]">
Access your camera
</message>
<message name="IDS_ANDROID_CAMERA_PERMISSION_OFF" desc="The message to show when the camera permission needs to be turned on not just in Chrome, but also in Android settings."> <message name="IDS_ANDROID_CAMERA_PERMISSION_OFF" desc="The message to show when the camera permission needs to be turned on not just in Chrome, but also in Android settings.">
To let <ph name="APP_NAME">%1$s<ex>Chrome</ex></ph> access your camera, also turn on camera in <ph name="BEGIN_LINK">&lt;link&gt;</ph>Android Settings<ph name="END_LINK">&lt;/link&gt;</ph>. To let <ph name="APP_NAME">%1$s<ex>Chrome</ex></ph> access your camera, also turn on camera in <ph name="BEGIN_LINK">&lt;link&gt;</ph>Android Settings<ph name="END_LINK">&lt;/link&gt;</ph>.
</message> </message>
...@@ -345,9 +342,6 @@ ...@@ -345,9 +342,6 @@
</message> </message>
<!-- Idle Detection --> <!-- Idle Detection -->
<message name="IDS_IDLE_DETECTION_PERMISSION_TITLE" desc="Title for the permission of detecting user activity [CHAR-LIMIT=32]">
User presence
</message>
<message name="IDS_WEBSITE_SETTINGS_CATEGORY_IDLE_DETECTION_ASK" desc="The description for the option to allow sites to ask for permission to access your activity state"> <message name="IDS_WEBSITE_SETTINGS_CATEGORY_IDLE_DETECTION_ASK" desc="The description for the option to allow sites to ask for permission to access your activity state">
Ask when a site wants to know when you're present Ask when a site wants to know when you're present
</message> </message>
...@@ -369,9 +363,6 @@ ...@@ -369,9 +363,6 @@
<!-- Location --> <!-- Location -->
<message name="IDS_GEOLOCATION_PERMISSION_TITLE" desc="Title for the permission of accessing the current location of a device [CHAR-LIMIT=32]">
Location access
</message>
<message name="IDS_WEBSITE_SETTINGS_CATEGORY_LOCATION_ASK" desc="Summary text explaining that sites need to ask for permission before knowing location and that it is the recommended setting."> <message name="IDS_WEBSITE_SETTINGS_CATEGORY_LOCATION_ASK" desc="Summary text explaining that sites need to ask for permission before knowing location and that it is the recommended setting.">
Ask before allowing sites to know your location (recommended) Ask before allowing sites to know your location (recommended)
</message> </message>
...@@ -390,9 +381,6 @@ ...@@ -390,9 +381,6 @@
<!-- Microphone --> <!-- Microphone -->
<message name="IDS_MIC_PERMISSION_TITLE" desc="Title text to be shown when the user has allowed/denied voice access for the website [CHAR-LIMIT=32]">
Access your microphone
</message>
<message name="IDS_WEBSITE_SETTINGS_CATEGORY_MIC_ASK" desc="Summary text explaining that sites need to ask for permission before accessing the microphone and that it is the recommended setting."> <message name="IDS_WEBSITE_SETTINGS_CATEGORY_MIC_ASK" desc="Summary text explaining that sites need to ask for permission before accessing the microphone and that it is the recommended setting.">
Ask first before allowing sites to use your microphone (recommended) Ask first before allowing sites to use your microphone (recommended)
</message> </message>
......
...@@ -29,7 +29,8 @@ import java.util.Locale; ...@@ -29,7 +29,8 @@ import java.util.Locale;
/** Tests that translations work correctly for Java strings inside bundles. */ /** Tests that translations work correctly for Java strings inside bundles. */
@RunWith(WebLayerJUnit4ClassRunner.class) @RunWith(WebLayerJUnit4ClassRunner.class)
public class BundleLanguageTest { public class BundleLanguageTest {
private static final String WEBLAYER_SPECIFIC_STRING = "string/geolocation_permission_title"; private static final String WEBLAYER_SPECIFIC_STRING =
"string/infobar_missing_location_permission_text";
private static final String SHARED_STRING = "string/color_picker_dialog_title"; private static final String SHARED_STRING = "string/color_picker_dialog_title";
@Rule @Rule
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment