Commit bab525e8 authored by Maxim Kolosovskiy's avatar Maxim Kolosovskiy Committed by Commit Bot

[Password Manager] Correct strings for "Change password" buttons

UI mocks: https://docs.google.com/presentation/d/1jsRsqvW8ZasT2iJGu-_8ebY3bPDe6ic8x8touqeNjuo/edit#slide=id.g8de4a3b916_55_6

Screenshot: https://screenshot.googleplex.com/97hV2heWU15

TODO: Add the icon for the regular change button.
https://screenshot.googleplex.com/XzOB9tPeV2X

Bug: 1086114, 1092444
Change-Id: I7164bf6f6f01a3bdc2cde3bfacc5817774661611
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336608
Commit-Queue: Maxim Kolosovskiy  <kolos@chromium.org>
Reviewed-by: default avatarFriedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794937}
parent ca70d161
...@@ -46,7 +46,7 @@ ...@@ -46,7 +46,7 @@
android:layout_marginTop="@dimen/compromised_credential_row_button_margin_top" android:layout_marginTop="@dimen/compromised_credential_row_button_margin_top"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:text="@string/password_check_credential_row_change_button_with_script_caption" android:text="@string/password_check_credential_row_change_button_caption"
android:drawablePadding="3dp" android:drawablePadding="3dp"
android:drawableStart="@drawable/ic_autofill_assistant_white_24dp" android:drawableStart="@drawable/ic_autofill_assistant_white_24dp"
style="@style/FilledButton.Flat" /> style="@style/FilledButton.Flat" />
...@@ -64,7 +64,7 @@ ...@@ -64,7 +64,7 @@
android:layout_marginTop="@dimen/compromised_credential_row_button_margin_top" android:layout_marginTop="@dimen/compromised_credential_row_button_margin_top"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:text="@string/password_check_credential_row_change_button_caption" android:text="@string/password_check_credential_row_change_manually_button_caption"
style="@style/TextButton"/> style="@style/TextButton"/>
</LinearLayout> </LinearLayout>
......
...@@ -172,11 +172,11 @@ ...@@ -172,11 +172,11 @@
<release allow_pseudo="false" seq="1"> <release allow_pseudo="false" seq="1">
<messages fallback_to_english="true"> <messages fallback_to_english="true">
<!-- Password Check --> <!-- Password Check -->
<message name="IDS_PASSWORD_CHECK_CREDENTIAL_ROW_CHANGE_BUTTON_CAPTION" desc="Caption for the button that links to a site where the user can change a compromised credential."> <message name="IDS_PASSWORD_CHECK_CREDENTIAL_ROW_CHANGE_BUTTON_CAPTION" desc="Caption for the primary button in the list of compromised credentials.">
Change password Change password
</message> </message>
<message name="IDS_PASSWORD_CHECK_CREDENTIAL_ROW_CHANGE_BUTTON_WITH_SCRIPT_CAPTION" desc="Caption for the button that starts a script that changes a compromised credential."> <message name="IDS_PASSWORD_CHECK_CREDENTIAL_ROW_CHANGE_MANUALLY_BUTTON_CAPTION" desc="Caption for the secondary button in the list of compromised credentials.">
Change password automatically Change manually
</message> </message>
<message name="IDS_PASSWORD_CHECK_CREDENTIAL_ROW_REASON_LEAKED" desc="Small description explaining that a credential is compromised because it was part of a data breach."> <message name="IDS_PASSWORD_CHECK_CREDENTIAL_ROW_REASON_LEAKED" desc="Small description explaining that a credential is compromised because it was part of a data breach.">
Found in data breach Found in data breach
......
662ab4bd4aec81ac0ef54848efad843452a0a601 df1bef149012e65d706ee2324b4dbf0ae78eb74c
\ No newline at end of file \ No newline at end of file
...@@ -174,8 +174,7 @@ public class PasswordCheckViewTest { ...@@ -174,8 +174,7 @@ public class PasswordCheckViewTest {
// Change button with script. // Change button with script.
assertNotNull(getCredentialChangeButtonWithScriptAt(0)); assertNotNull(getCredentialChangeButtonWithScriptAt(0));
assertThat(getCredentialChangeButtonWithScriptAt(0).getText(), assertThat(getCredentialChangeButtonWithScriptAt(0).getText(),
is(getString( is(getString(R.string.password_check_credential_row_change_button_caption)));
R.string.password_check_credential_row_change_button_with_script_caption)));
// Explanation for change button with script. // Explanation for change button with script.
assertNotNull(getCredentialChangeButtonWithScriptExplanationAt(0)); assertNotNull(getCredentialChangeButtonWithScriptExplanationAt(0));
...@@ -185,7 +184,8 @@ public class PasswordCheckViewTest { ...@@ -185,7 +184,8 @@ public class PasswordCheckViewTest {
// Change button without script. // Change button without script.
assertNotNull(getCredentialChangeButtonAt(0)); assertNotNull(getCredentialChangeButtonAt(0));
assertThat(getCredentialChangeButtonAt(0).getText(), assertThat(getCredentialChangeButtonAt(0).getText(),
is(getString(R.string.password_check_credential_row_change_button_caption))); is(getString(
R.string.password_check_credential_row_change_manually_button_caption)));
} }
@Test @Test
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment