Commit bac094f7 authored by Min Qin's avatar Min Qin Committed by Commit Bot

Convert some DCHECK to CHECK to find cases that download file is not

properly deleted


BUG=1028666

Change-Id: I59b60a897a5f2529d4e61d8632aebe421dbc71b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933738Reviewed-by: default avatarXing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719294}
parent 527f983b
...@@ -446,7 +446,7 @@ DownloadItemImpl::~DownloadItemImpl() { ...@@ -446,7 +446,7 @@ DownloadItemImpl::~DownloadItemImpl() {
// Should always have been nuked before now, at worst in // Should always have been nuked before now, at worst in
// DownloadManager shutdown. // DownloadManager shutdown.
DCHECK(!download_file_); CHECK(!download_file_);
CHECK(!is_updating_observers_); CHECK(!is_updating_observers_);
for (auto& observer : observers_) for (auto& observer : observers_)
...@@ -1447,7 +1447,7 @@ void DownloadItemImpl::Start( ...@@ -1447,7 +1447,7 @@ void DownloadItemImpl::Start(
URLLoaderFactoryProvider::URLLoaderFactoryProviderPtr URLLoaderFactoryProvider::URLLoaderFactoryProviderPtr
url_loader_factory_provider) { url_loader_factory_provider) {
DCHECK_CALLED_ON_VALID_THREAD(thread_checker_); DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
DCHECK(!download_file_); CHECK(!download_file_);
DVLOG(20) << __func__ << "() this=" << DebugString(true); DVLOG(20) << __func__ << "() this=" << DebugString(true);
RecordDownloadCountWithSource(START_COUNT, download_source_); RecordDownloadCountWithSource(START_COUNT, download_source_);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment