Commit bac2056e authored by chinsenj's avatar chinsenj Committed by Chromium LUCI CQ

cros: Fix DeskNameView ChromeVox behavior.

Currently, the ChromeVox behavior is broken. It doesn't echo typed text,
nor does it read out typed text.

This CL fixes ChromeVox behavior by calling
Textfield::GetAccessibleNodeData() in
DeskNameView::GetAccessibleNodeData().

Test: manual
Bug: 1166732, 1166693
Change-Id: I54306c8b3ea02000aef7663ace32ffd314d5c235
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632045Reviewed-by: default avatarAhmed Fakhry <afakhry@chromium.org>
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844118}
parent 458476e8
...@@ -117,7 +117,7 @@ bool DeskNameView::SkipDefaultKeyEventProcessing(const ui::KeyEvent& event) { ...@@ -117,7 +117,7 @@ bool DeskNameView::SkipDefaultKeyEventProcessing(const ui::KeyEvent& event) {
} }
void DeskNameView::GetAccessibleNodeData(ui::AXNodeData* node_data) { void DeskNameView::GetAccessibleNodeData(ui::AXNodeData* node_data) {
node_data->role = ax::mojom::Role::kTextField; Textfield::GetAccessibleNodeData(node_data);
// When Bento is enabled and the user creates a new desk, |full_text_| will be // When Bento is enabled and the user creates a new desk, |full_text_| will be
// empty but the accesssible name for |this| will be the default desk name. // empty but the accesssible name for |this| will be the default desk name.
node_data->SetName(full_text_.empty() ? GetAccessibleName() : full_text_); node_data->SetName(full_text_.empty() ? GetAccessibleName() : full_text_);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment