Commit bace3d79 authored by John Chen's avatar John Chen Committed by Commit Bot

[ChromeDriver] Avoid unnecessary Status object

Creating an error Status object is expensive, as it generates a stack
trace. Avoid creating such object until it is needed.

Bug: 997414
Change-Id: I694981761135a987f3bd767617eaf0206ce62af5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769580Reviewed-by: default avatarCaleb Rouleau <crouleau@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690423}
parent 0975ee25
......@@ -79,9 +79,6 @@ Status ParseBrowserString(bool has_android_package,
return Status(kOk);
}
const Status error =
Status(kUnknownError, "unrecognized Chrome version: " + browser_string);
int build_no = 0;
if (base::StartsWith(browser_string, kVersionPrefix,
base::CompareCase::SENSITIVE) ||
......@@ -125,7 +122,8 @@ Status ParseBrowserString(bool has_android_package,
return Status(kOk);
}
return error;
return Status(kUnknownError,
"unrecognized Chrome version: " + browser_string);
}
Status ParseBrowserVersionString(const std::string& browser_version,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment