Commit bb26cfc5 authored by Fredrik Söderqvist's avatar Fredrik Söderqvist Committed by Commit Bot

Fold SVGImage::completion_state()

Since SVGImage::PopulatePaintRecordForCurrentFrameForContainer() is
downstream of both of the PaintImageForCurrentFrame() implementations,
just let it set the completion state and don't expose this state
publicly on SVGImage.

Change-Id: Icb3a4a1aa263a04098cb6358f5d7bbb9923e37a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526427
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: default avatarStephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825566}
parent 3bc0f85f
...@@ -421,8 +421,7 @@ void SVGImage::DrawForContainer(cc::PaintCanvas* canvas, ...@@ -421,8 +421,7 @@ void SVGImage::DrawForContainer(cc::PaintCanvas* canvas,
} }
PaintImage SVGImage::PaintImageForCurrentFrame() { PaintImage SVGImage::PaintImageForCurrentFrame() {
auto builder = auto builder = CreatePaintImageBuilder();
CreatePaintImageBuilder().set_completion_state(completion_state());
PopulatePaintRecordForCurrentFrameForContainer(builder, Size(), 1, NullURL()); PopulatePaintRecordForCurrentFrameForContainer(builder, Size(), 1, NullURL());
return builder.TakePaintImage(); return builder.TakePaintImage();
} }
...@@ -485,6 +484,10 @@ void SVGImage::PopulatePaintRecordForCurrentFrameForContainer( ...@@ -485,6 +484,10 @@ void SVGImage::PopulatePaintRecordForCurrentFrameForContainer(
const IntSize& zoomed_container_size, const IntSize& zoomed_container_size,
float zoom, float zoom,
const KURL& url) { const KURL& url) {
builder.set_completion_state(
load_state_ == LoadState::kLoadCompleted
? PaintImage::CompletionState::DONE
: PaintImage::CompletionState::PARTIALLY_DONE);
if (!page_) if (!page_)
return; return;
......
...@@ -77,12 +77,6 @@ class CORE_EXPORT SVGImage final : public Image { ...@@ -77,12 +77,6 @@ class CORE_EXPORT SVGImage final : public Image {
void ResetAnimation() override; void ResetAnimation() override;
void RestoreAnimation(); void RestoreAnimation();
PaintImage::CompletionState completion_state() const {
return load_state_ == LoadState::kLoadCompleted
? PaintImage::CompletionState::DONE
: PaintImage::CompletionState::PARTIALLY_DONE;
}
// Does the SVG image/document contain any animations? // Does the SVG image/document contain any animations?
bool MaybeAnimated() override; bool MaybeAnimated() override;
......
...@@ -70,8 +70,7 @@ bool SVGImageForContainer::ApplyShader(cc::PaintFlags& flags, ...@@ -70,8 +70,7 @@ bool SVGImageForContainer::ApplyShader(cc::PaintFlags& flags,
} }
PaintImage SVGImageForContainer::PaintImageForCurrentFrame() { PaintImage SVGImageForContainer::PaintImageForCurrentFrame() {
auto builder = CreatePaintImageBuilder().set_completion_state( auto builder = CreatePaintImageBuilder();
image_->completion_state());
image_->PopulatePaintRecordForCurrentFrameForContainer(builder, Size(), zoom_, image_->PopulatePaintRecordForCurrentFrameForContainer(builder, Size(), zoom_,
url_); url_);
return builder.TakePaintImage(); return builder.TakePaintImage();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment