Commit bb3cacb5 authored by mef@chromium.org's avatar mef@chromium.org

Revert 255602 "Cast: Cap max receiver log size per rtcp packet t..."

Broke 
RtcpReceiverReportWithOversizedFrameLog and
RtcpReceiverReportWithTooManyLogFrames tests
> Cast: Cap max receiver log size per rtcp packet to 200 bytes.
> 
> This is a short term fix to hopefully reduce the effects of packets
> queueing up on the receiver side. Previously we try fill up the RTCP
> packet with as many receiver log as possible so we can have redundancy.
> The redundancy that has been observed was more than 30 per message, and
> we don't need this much redundancy. 200 is a good number where each
> log message will be sent with redundancy of around 2-3, without losing
> too many (< 1%) messages, assuming default rtcp interval settings.
> That's fine because we don't need the logs to be completely reliable.
> 
> 
> BUG=349265
> 
> Review URL: https://codereview.chromium.org/189423002

TBR=imcheng@chromium.org

Review URL: https://codereview.chromium.org/190723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255611 0039d316-1c4b-4281-b951-d872f2087c98
parent 0ee0f645
...@@ -23,12 +23,6 @@ namespace { ...@@ -23,12 +23,6 @@ namespace {
// 12 bits. // 12 bits.
const int64 kMaxWireFormatTimeDeltaMs = GG_INT64_C(0xfff); const int64 kMaxWireFormatTimeDeltaMs = GG_INT64_C(0xfff);
// We limit the size of receiver logs to avoid queuing up packets. We also
// do not need the amount of redundancy that results from filling up every
// RTCP packet with log messages. This number should give a redundancy of
// about 2-3 per log message.
const size_t kMaxReceiverLogBytes = 200;
// Converts a log event type to an integer value. // Converts a log event type to an integer value.
// NOTE: We have only allocated 4 bits to represent the type of event over the // NOTE: We have only allocated 4 bits to represent the type of event over the
// wire. Therefore, this function can only return values from 0 to 15. // wire. Therefore, this function can only return values from 0 to 15.
...@@ -88,8 +82,7 @@ bool BuildRtcpReceiverLogMessage( ...@@ -88,8 +82,7 @@ bool BuildRtcpReceiverLogMessage(
size_t* number_of_frames, size_t* number_of_frames,
size_t* total_number_of_messages_to_send, size_t* total_number_of_messages_to_send,
size_t* rtcp_log_size) { size_t* rtcp_log_size) {
size_t remaining_space = size_t remaining_space = kMaxIpPacketSize - start_size;
std::min(kMaxReceiverLogBytes, kMaxIpPacketSize - start_size);
if (remaining_space < kRtcpCastLogHeaderSize + kRtcpReceiverFrameLogSize + if (remaining_space < kRtcpCastLogHeaderSize + kRtcpReceiverFrameLogSize +
kRtcpReceiverEventLogSize) { kRtcpReceiverEventLogSize) {
return false; return false;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment