Expose Webauthn's getTransports.

getTransports is now included in the W3C draft for Webauthn[1]. Thus
this change enables it by default by removing its individual flag
protection.

(See [2] for where this was added originally.)

[1] https://github.com/w3c/webauthn/commit/11d549048ac5e462a4f9f44499032302adb29800
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1180083

Change-Id: Iee6209ac0c75fe2537bcb6f9edd0f8bc974e6d15
Reviewed-on: https://chromium-review.googlesource.com/c/1471630Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634506}

content/child/runtime_features.cc

@@ -335,12 +335,6 @@ void SetIndividualRuntimeFeatures(
   WebRuntimeFeatures::EnableWebAuth(
       base::FeatureList::IsEnabled(features::kWebAuth));
 
-  // TODO(yashard): Remove |enable_experimental_web_platform_features| flag
-  // since the feature should have been enabled when it is set to experimental
-  WebRuntimeFeatures::EnableWebAuthGetTransports(
-      base::FeatureList::IsEnabled(features::kWebAuthGetTransports) ||
-      enable_experimental_web_platform_features);
-
   WebRuntimeFeatures::EnableClientPlaceholdersForServerLoFi(
       base::GetFieldTrialParamValue("PreviewsClientLoFi",
                                     "replace_server_placeholders") != "false");

content/public/common/content_features.cc

@@ -575,11 +575,6 @@ const base::Feature kWebAuthCable {
 #endif
 };
 
-// Controls whether AuthenticatorAttestationResponse contains a getTransports
-// member to return the set of transports supported by an authenticator.
-const base::Feature kWebAuthGetTransports{"WebAuthenticationGetTransports",
-                                          base::FEATURE_DISABLED_BY_DEFAULT};
-
 // If WebGL Image Chromium is allowed, this feature controls whether it is
 // enabled.
 const base::Feature kWebGLImageChromium{"WebGLImageChromium",

content/public/common/content_features.h

@@ -130,7 +130,6 @@ CONTENT_EXPORT extern const base::Feature kWebAssemblyTrapHandler;
 CONTENT_EXPORT extern const base::Feature kWebAuth;
 CONTENT_EXPORT extern const base::Feature kWebAuthBle;
 CONTENT_EXPORT extern const base::Feature kWebAuthCable;
-CONTENT_EXPORT extern const base::Feature kWebAuthGetTransports;
 CONTENT_EXPORT extern const base::Feature kWebContentsOcclusion;
 CONTENT_EXPORT extern const base::Feature kWebGLImageChromium;
 CONTENT_EXPORT extern const base::Feature kWebPayments;

third_party/blink/public/platform/web_runtime_features.h

@@ -179,7 +179,6 @@ class WebRuntimeFeatures {
   BLINK_PLATFORM_EXPORT static void EnableUserActivationV2(bool);
   BLINK_PLATFORM_EXPORT static void EnableV8IdleTasks(bool);
   BLINK_PLATFORM_EXPORT static void EnableWebAuth(bool);
-  BLINK_PLATFORM_EXPORT static void EnableWebAuthGetTransports(bool);
   BLINK_PLATFORM_EXPORT static void EnableWebBluetooth(bool);
   BLINK_PLATFORM_EXPORT static void EnableWebBluetoothScanning(bool);
   BLINK_PLATFORM_EXPORT static void EnableWebGL2ComputeContext(bool);

third_party/blink/renderer/modules/credentialmanager/authenticator_attestation_response.idl

@@ -10,5 +10,5 @@
     Exposed=Window
 ] interface AuthenticatorAttestationResponse : AuthenticatorResponse {
     [SameObject] readonly attribute ArrayBuffer attestationObject;
-    [RuntimeEnabled=WebAuthGetTransports] sequence<AuthenticatorTransport> getTransports();
+    sequence<AuthenticatorTransport> getTransports();
 };

third_party/blink/renderer/platform/exported/web_runtime_features.cc

@@ -564,10 +564,6 @@ void WebRuntimeFeatures::EnableWebAuth(bool enable) {
   RuntimeEnabledFeatures::SetWebAuthEnabled(enable);
 }
 
-void WebRuntimeFeatures::EnableWebAuthGetTransports(bool enable) {
-  RuntimeEnabledFeatures::SetWebAuthGetTransportsEnabled(enable);
-}
-
 void WebRuntimeFeatures::EnableClientPlaceholdersForServerLoFi(bool enable) {
   RuntimeEnabledFeatures::SetClientPlaceholdersForServerLoFiEnabled(enable);
 }

third_party/blink/renderer/platform/runtime_enabled_features.json5

@@ -1429,10 +1429,6 @@
       name: "WebAuth",
       status: "experimental",
     },
-    {
-      name: "WebAuthGetTransports",
-      status: "experimental",
-    },
     // WebBluetooth is enabled by default on Android, ChromeOS and Mac.
     // It is also supported in Windows 10 which is handled in runtime_features.cc
     {

third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt

@@ -223,6 +223,7 @@ interface AuthenticatorAttestationResponse : AuthenticatorResponse
     attribute @@toStringTag
     getter attestationObject
     method constructor
+    method getTransports
 interface AuthenticatorResponse
     attribute @@toStringTag
     getter clientDataJSON