Verify presence of just "Process Internals" substring in page contents.
Before this CL, the test would look for "Process Model Internals" substring in page contents. This substring is present, but is populated dynamically in the "Frame Trees" pane: - WebContents: Process Model Internals, 1 frame. To make the test less dependent on when the dynamic text is added, this CL starts looking instead for "Process Internals" substring which is statically present in //content/browser/resources/process/process_internals.html Additionally, after this CL the test inspects page contents via gMock, rather than via innerHTML.search API. Hopefully, the change in this CL will make test failures easier to diagnose in the future (i.e. gMock should display mismatched |page_contents|). Before this CL, the test failure would just say that |innerHTML.search| API returned -1. Bug: 1107995 Change-Id: I83e5f45563a780b5dc8919e36ad71b2e171ac2ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317852 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#791956}
Showing
Please register or sign in to comment