Commit bb5ffca6 authored by Bettina's avatar Bettina Committed by Commit Bot

Show modal warning for saved password for low rep.

Previously, we filtered out low reputation sites from
the modal warnings shown for phished svaed passwords.
However, low reputation and phished sites should be both
shown as warnings.

Bug: 1026000
Change-Id: I425198650c387bdccbb72769c45d054f91075e57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921654Reviewed-by: default avatarVarun Khaneja <vakh@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716369}
parent eb58d0ea
......@@ -172,13 +172,6 @@ bool PasswordProtectionService::ShouldShowModalWarning(
return false;
}
if (password_type.account_type() ==
ReusedPasswordAccountType::SAVED_PASSWORD &&
base::FeatureList::IsEnabled(
safe_browsing::kPasswordProtectionForSavedPasswords)) {
return verdict_type == LoginReputationClientResponse::PHISHING;
}
return (verdict_type == LoginReputationClientResponse::PHISHING ||
verdict_type == LoginReputationClientResponse::LOW_REPUTATION) &&
IsWarningEnabled(password_type);
......
......@@ -1154,6 +1154,10 @@ TEST_P(PasswordProtectionServiceTest, VerifyShouldShowModalWarning) {
EXPECT_TRUE(password_protection_service_->ShouldShowModalWarning(
LoginReputationClientRequest::PASSWORD_REUSE_EVENT,
reused_password_account_type, LoginReputationClientResponse::PHISHING));
EXPECT_TRUE(password_protection_service_->ShouldShowModalWarning(
LoginReputationClientRequest::PASSWORD_REUSE_EVENT,
reused_password_account_type,
LoginReputationClientResponse::LOW_REPUTATION));
}
{
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment