Commit bb680d5a authored by Tetsui Ohkubo's avatar Tetsui Ohkubo Committed by Commit Bot

Rename TrayDetailsView to TrayDetailedView.

This CL renames TrayDetailsView to TrayDetailedView, as in other places
it's always called "detailed view" e.g. CreateDetailedView(),
NetworkStateListDetailedView, CastDetailedView,
AccessibilityDetailedView, etc.

TEST=ash_unittests
BUG=none

Change-Id: I84bc2fc7ade4bc71d9907427c35501f21f9da3a6
Reviewed-on: https://chromium-review.googlesource.com/1068888Reviewed-by: default avatarSteven Bennetts <stevenjb@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560870}
parent ff2bbe73
...@@ -844,8 +844,8 @@ component("ash") { ...@@ -844,8 +844,8 @@ component("ash") {
"system/tray/tray_constants.h", "system/tray/tray_constants.h",
"system/tray/tray_container.cc", "system/tray/tray_container.cc",
"system/tray/tray_container.h", "system/tray/tray_container.h",
"system/tray/tray_details_view.cc", "system/tray/tray_detailed_view.cc",
"system/tray/tray_details_view.h", "system/tray/tray_detailed_view.h",
"system/tray/tray_event_filter.cc", "system/tray/tray_event_filter.cc",
"system/tray/tray_event_filter.h", "system/tray/tray_event_filter.h",
"system/tray/tray_image_item.cc", "system/tray/tray_image_item.cc",
...@@ -1772,7 +1772,7 @@ test("ash_unittests") { ...@@ -1772,7 +1772,7 @@ test("ash_unittests") {
"system/tracing_notification_controller_unittest.cc", "system/tracing_notification_controller_unittest.cc",
"system/tray/size_range_layout_unittest.cc", "system/tray/size_range_layout_unittest.cc",
"system/tray/system_tray_unittest.cc", "system/tray/system_tray_unittest.cc",
"system/tray/tray_details_view_unittest.cc", "system/tray/tray_detailed_view_unittest.cc",
"system/tray/tray_event_filter_unittest.cc", "system/tray/tray_event_filter_unittest.cc",
"system/tray/tray_info_label_unittest.cc", "system/tray/tray_info_label_unittest.cc",
"system/tray/tri_view_unittest.cc", "system/tray/tri_view_unittest.cc",
......
...@@ -58,7 +58,7 @@ namespace ash { ...@@ -58,7 +58,7 @@ namespace ash {
namespace tray { namespace tray {
AudioDetailedView::AudioDetailedView(SystemTrayItem* owner) AudioDetailedView::AudioDetailedView(SystemTrayItem* owner)
: TrayDetailsView(owner) { : TrayDetailedView(owner) {
CreateItems(); CreateItems();
Update(); Update();
} }
......
...@@ -7,7 +7,7 @@ ...@@ -7,7 +7,7 @@
#include <map> #include <map>
#include "ash/system/tray/tray_details_view.h" #include "ash/system/tray/tray_detailed_view.h"
#include "base/macros.h" #include "base/macros.h"
#include "chromeos/audio/audio_device.h" #include "chromeos/audio/audio_device.h"
...@@ -18,7 +18,7 @@ struct VectorIcon; ...@@ -18,7 +18,7 @@ struct VectorIcon;
namespace ash { namespace ash {
namespace tray { namespace tray {
class AudioDetailedView : public TrayDetailsView { class AudioDetailedView : public TrayDetailedView {
public: public:
explicit AudioDetailedView(SystemTrayItem* owner); explicit AudioDetailedView(SystemTrayItem* owner);
...@@ -36,7 +36,7 @@ class AudioDetailedView : public TrayDetailsView { ...@@ -36,7 +36,7 @@ class AudioDetailedView : public TrayDetailsView {
void UpdateScrollableList(); void UpdateScrollableList();
void UpdateAudioDevices(); void UpdateAudioDevices();
// TrayDetailsView: // TrayDetailedView:
void HandleViewClicked(views::View* view) override; void HandleViewClicked(views::View* view) override;
typedef std::map<views::View*, chromeos::AudioDevice> AudioDeviceMap; typedef std::map<views::View*, chromeos::AudioDevice> AudioDeviceMap;
......
...@@ -21,7 +21,7 @@ ...@@ -21,7 +21,7 @@
#include "ash/system/tray/system_tray_controller.h" #include "ash/system/tray/system_tray_controller.h"
#include "ash/system/tray/system_tray_notifier.h" #include "ash/system/tray/system_tray_notifier.h"
#include "ash/system/tray/tray_constants.h" #include "ash/system/tray/tray_constants.h"
#include "ash/system/tray/tray_details_view.h" #include "ash/system/tray/tray_detailed_view.h"
#include "ash/system/tray/tray_info_label.h" #include "ash/system/tray/tray_info_label.h"
#include "ash/system/tray/tray_item_more.h" #include "ash/system/tray/tray_item_more.h"
#include "ash/system/tray/tray_popup_item_style.h" #include "ash/system/tray/tray_popup_item_style.h"
...@@ -183,10 +183,10 @@ class BluetoothDefaultView : public TrayItemMore { ...@@ -183,10 +183,10 @@ class BluetoothDefaultView : public TrayItemMore {
DISALLOW_COPY_AND_ASSIGN(BluetoothDefaultView); DISALLOW_COPY_AND_ASSIGN(BluetoothDefaultView);
}; };
class BluetoothDetailedView : public TrayDetailsView { class BluetoothDetailedView : public TrayDetailedView {
public: public:
BluetoothDetailedView(SystemTrayItem* owner, LoginStatus login) BluetoothDetailedView(SystemTrayItem* owner, LoginStatus login)
: TrayDetailsView(owner), : TrayDetailedView(owner),
login_(login), login_(login),
toggle_(nullptr), toggle_(nullptr),
settings_(nullptr), settings_(nullptr),
...@@ -379,7 +379,7 @@ class BluetoothDetailedView : public TrayDetailsView { ...@@ -379,7 +379,7 @@ class BluetoothDetailedView : public TrayDetailsView {
} }
} }
// TrayDetailsView: // TrayDetailedView:
void HandleViewClicked(views::View* view) override { void HandleViewClicked(views::View* view) override {
TrayBluetoothHelper* helper = Shell::Get()->tray_bluetooth_helper(); TrayBluetoothHelper* helper = Shell::Get()->tray_bluetooth_helper();
if (!helper->GetBluetoothEnabled()) if (!helper->GetBluetoothEnabled())
......
...@@ -18,7 +18,7 @@ ...@@ -18,7 +18,7 @@
#include "ash/system/tray/hover_highlight_view.h" #include "ash/system/tray/hover_highlight_view.h"
#include "ash/system/tray/system_tray.h" #include "ash/system/tray/system_tray.h"
#include "ash/system/tray/tray_constants.h" #include "ash/system/tray/tray_constants.h"
#include "ash/system/tray/tray_details_view.h" #include "ash/system/tray/tray_detailed_view.h"
#include "ash/system/tray/tray_item_more.h" #include "ash/system/tray/tray_item_more.h"
#include "ash/system/tray/tray_item_view.h" #include "ash/system/tray/tray_item_view.h"
#include "base/strings/utf_string_conversions.h" #include "base/strings/utf_string_conversions.h"
...@@ -334,7 +334,7 @@ CastTrayView::~CastTrayView() = default; ...@@ -334,7 +334,7 @@ CastTrayView::~CastTrayView() = default;
// This view displays a list of cast receivers that can be clicked on and casted // This view displays a list of cast receivers that can be clicked on and casted
// to. It is activated by clicking on the chevron inside of // to. It is activated by clicking on the chevron inside of
// |CastSelectDefaultView|. // |CastSelectDefaultView|.
class CastDetailedView : public TrayDetailsView { class CastDetailedView : public TrayDetailedView {
public: public:
CastDetailedView(SystemTrayItem* owner, CastDetailedView(SystemTrayItem* owner,
const std::vector<mojom::SinkAndRoutePtr>& sinks_and_routes); const std::vector<mojom::SinkAndRoutePtr>& sinks_and_routes);
...@@ -353,7 +353,7 @@ class CastDetailedView : public TrayDetailsView { ...@@ -353,7 +353,7 @@ class CastDetailedView : public TrayDetailsView {
void UpdateReceiverListFromCachedData(); void UpdateReceiverListFromCachedData();
// TrayDetailsView: // TrayDetailedView:
void HandleViewClicked(views::View* view) override; void HandleViewClicked(views::View* view) override;
// A mapping from the receiver id to the receiver/activity data. // A mapping from the receiver id to the receiver/activity data.
...@@ -367,7 +367,7 @@ class CastDetailedView : public TrayDetailsView { ...@@ -367,7 +367,7 @@ class CastDetailedView : public TrayDetailsView {
CastDetailedView::CastDetailedView( CastDetailedView::CastDetailedView(
SystemTrayItem* owner, SystemTrayItem* owner,
const std::vector<mojom::SinkAndRoutePtr>& sinks_routes) const std::vector<mojom::SinkAndRoutePtr>& sinks_routes)
: TrayDetailsView(owner) { : TrayDetailedView(owner) {
CreateItems(); CreateItems();
UpdateReceiverList(sinks_routes); UpdateReceiverList(sinks_routes);
} }
......
...@@ -32,7 +32,7 @@ bool IsSameScaleFactor(double new_value) { ...@@ -32,7 +32,7 @@ bool IsSameScaleFactor(double new_value) {
} // namespace } // namespace
ScaleDetailedView::ScaleDetailedView(SystemTrayItem* owner) ScaleDetailedView::ScaleDetailedView(SystemTrayItem* owner)
: TrayDetailsView(owner) { : TrayDetailedView(owner) {
CreateScrollableList(); CreateScrollableList();
CreateTitleRow(IDS_ASH_STATUS_TRAY_SCALE); CreateTitleRow(IDS_ASH_STATUS_TRAY_SCALE);
UpdateScrollableList(); UpdateScrollableList();
......
...@@ -5,7 +5,7 @@ ...@@ -5,7 +5,7 @@
#ifndef ASH_SYSTEM_DISPLAY_SCALE_SCALE_DETAILED_VIEW_H_ #ifndef ASH_SYSTEM_DISPLAY_SCALE_SCALE_DETAILED_VIEW_H_
#define ASH_SYSTEM_DISPLAY_SCALE_SCALE_DETAILED_VIEW_H_ #define ASH_SYSTEM_DISPLAY_SCALE_SCALE_DETAILED_VIEW_H_
#include "ash/system/tray/tray_details_view.h" #include "ash/system/tray/tray_detailed_view.h"
#include "base/macros.h" #include "base/macros.h"
namespace views { namespace views {
...@@ -17,7 +17,7 @@ class HoverHighlightView; ...@@ -17,7 +17,7 @@ class HoverHighlightView;
namespace tray { namespace tray {
class ScaleDetailedView : public TrayDetailsView { class ScaleDetailedView : public TrayDetailedView {
public: public:
explicit ScaleDetailedView(SystemTrayItem* owner); explicit ScaleDetailedView(SystemTrayItem* owner);
...@@ -30,7 +30,7 @@ class ScaleDetailedView : public TrayDetailsView { ...@@ -30,7 +30,7 @@ class ScaleDetailedView : public TrayDetailsView {
void UpdateScrollableList(); void UpdateScrollableList();
// TrayDetailsView: // TrayDetailedView:
void HandleViewClicked(views::View* view) override; void HandleViewClicked(views::View* view) override;
std::map<views::View*, double> view_to_scale_; std::map<views::View*, double> view_to_scale_;
......
...@@ -16,7 +16,7 @@ ...@@ -16,7 +16,7 @@
#include "ash/system/tray/system_tray_controller.h" #include "ash/system/tray/system_tray_controller.h"
#include "ash/system/tray/system_tray_notifier.h" #include "ash/system/tray/system_tray_notifier.h"
#include "ash/system/tray/tray_constants.h" #include "ash/system/tray/tray_constants.h"
#include "ash/system/tray/tray_details_view.h" #include "ash/system/tray/tray_detailed_view.h"
#include "ash/system/tray/tray_item_more.h" #include "ash/system/tray/tray_item_more.h"
#include "ash/system/tray/tray_item_view.h" #include "ash/system/tray/tray_item_view.h"
#include "ash/system/tray/tray_popup_item_style.h" #include "ash/system/tray/tray_popup_item_style.h"
......
...@@ -14,7 +14,7 @@ ...@@ -14,7 +14,7 @@
#include "ash/system/tray/actionable_view.h" #include "ash/system/tray/actionable_view.h"
#include "ash/system/tray/system_menu_button.h" #include "ash/system/tray/system_menu_button.h"
#include "ash/system/tray/tray_constants.h" #include "ash/system/tray/tray_constants.h"
#include "ash/system/tray/tray_details_view.h" #include "ash/system/tray/tray_detailed_view.h"
#include "ash/system/tray/tray_popup_item_style.h" #include "ash/system/tray/tray_popup_item_style.h"
#include "ash/system/tray/tray_popup_utils.h" #include "ash/system/tray/tray_popup_utils.h"
#include "ash/system/tray/tri_view.h" #include "ash/system/tray/tri_view.h"
...@@ -182,7 +182,7 @@ class KeyboardStatusRow : public views::View { ...@@ -182,7 +182,7 @@ class KeyboardStatusRow : public views::View {
}; };
ImeListView::ImeListView(SystemTrayItem* owner) ImeListView::ImeListView(SystemTrayItem* owner)
: TrayDetailsView(owner), : TrayDetailedView(owner),
last_item_selected_with_keyboard_(false), last_item_selected_with_keyboard_(false),
should_focus_ime_after_selection_with_keyboard_(false), should_focus_ime_after_selection_with_keyboard_(false),
current_ime_view_(nullptr) {} current_ime_view_(nullptr) {}
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
#include <vector> #include <vector>
#include "ash/ash_export.h" #include "ash/ash_export.h"
#include "ash/system/tray/tray_details_view.h" #include "ash/system/tray/tray_detailed_view.h"
#include "ui/views/controls/button/button.h" #include "ui/views/controls/button/button.h"
namespace ash { namespace ash {
...@@ -23,7 +23,7 @@ class KeyboardStatusRow; ...@@ -23,7 +23,7 @@ class KeyboardStatusRow;
// Base class used to represent a selecatable list of available IMEs. // Base class used to represent a selecatable list of available IMEs.
// Optionally shows a toggle which is used to enable or disable the invocation // Optionally shows a toggle which is used to enable or disable the invocation
// of the virtual keyboard. // of the virtual keyboard.
class ImeListView : public TrayDetailsView { class ImeListView : public TrayDetailedView {
public: public:
enum SingleImeBehavior { enum SingleImeBehavior {
// Shows the IME menu if there's only one IME in system. // Shows the IME menu if there's only one IME in system.
...@@ -69,7 +69,7 @@ class ImeListView : public TrayDetailsView { ...@@ -69,7 +69,7 @@ class ImeListView : public TrayDetailsView {
return should_focus_ime_after_selection_with_keyboard_; return should_focus_ime_after_selection_with_keyboard_;
} }
// TrayDetailsView: // TrayDetailedView:
void HandleViewClicked(views::View* view) override; void HandleViewClicked(views::View* view) override;
void HandleButtonPressed(views::Button* sender, void HandleButtonPressed(views::Button* sender,
const ui::Event& event) override; const ui::Event& event) override;
......
...@@ -173,7 +173,7 @@ NetworkStateListDetailedView::NetworkStateListDetailedView( ...@@ -173,7 +173,7 @@ NetworkStateListDetailedView::NetworkStateListDetailedView(
SystemTrayItem* owner, SystemTrayItem* owner,
ListType list_type, ListType list_type,
LoginStatus login) LoginStatus login)
: TrayDetailsView(owner), : TrayDetailedView(owner),
list_type_(list_type), list_type_(list_type),
login_(login), login_(login),
info_button_(nullptr), info_button_(nullptr),
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
#include <string> #include <string>
#include "ash/login_status.h" #include "ash/login_status.h"
#include "ash/system/tray/tray_details_view.h" #include "ash/system/tray/tray_detailed_view.h"
#include "base/macros.h" #include "base/macros.h"
#include "base/memory/weak_ptr.h" #include "base/memory/weak_ptr.h"
...@@ -23,7 +23,7 @@ namespace tray { ...@@ -23,7 +23,7 @@ namespace tray {
// Exported for tests. // Exported for tests.
class ASH_EXPORT NetworkStateListDetailedView class ASH_EXPORT NetworkStateListDetailedView
: public TrayDetailsView, : public TrayDetailedView,
public base::SupportsWeakPtr<NetworkStateListDetailedView> { public base::SupportsWeakPtr<NetworkStateListDetailedView> {
public: public:
~NetworkStateListDetailedView() override; ~NetworkStateListDetailedView() override;
...@@ -54,7 +54,7 @@ class ASH_EXPORT NetworkStateListDetailedView ...@@ -54,7 +54,7 @@ class ASH_EXPORT NetworkStateListDetailedView
private: private:
class InfoBubble; class InfoBubble;
// TrayDetailsView: // TrayDetailedView:
void HandleViewClicked(views::View* view) override; void HandleViewClicked(views::View* view) override;
void HandleButtonPressed(views::Button* sender, void HandleButtonPressed(views::Button* sender,
const ui::Event& event) override; const ui::Event& event) override;
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
#include "ash/system/tray/tray_details_view.h" #include "ash/system/tray/tray_detailed_view.h"
#include "ash/ash_view_ids.h" #include "ash/ash_view_ids.h"
#include "ash/public/cpp/ash_features.h" #include "ash/public/cpp/ash_features.h"
...@@ -166,9 +166,8 @@ class ScrollContentsView : public views::View { ...@@ -166,9 +166,8 @@ class ScrollContentsView : public views::View {
previous_header = &header; previous_header = &header;
header_view->SetY(header.natural_offset); header_view->SetY(header.natural_offset);
} else { } else {
if (previous_header && if (previous_header && previous_header->view->y() <=
previous_header->view->y() <= scroll_offset + header_view->height()) {
scroll_offset + header_view->height()) {
// Lower header displacing the header above. // Lower header displacing the header above.
draw_separator_below = true; draw_separator_below = true;
header_view->SetY(previous_header->view->y() - header_view->height()); header_view->SetY(previous_header->view->y() - header_view->height());
...@@ -239,11 +238,10 @@ const int kTitleRowPaddingBottom = ...@@ -239,11 +238,10 @@ const int kTitleRowPaddingBottom =
} // namespace } // namespace
//////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////
// TrayDetailsView: // TrayDetailedView:
TrayDetailsView::TrayDetailsView(SystemTrayItem* owner) TrayDetailedView::TrayDetailedView(SystemTrayItem* owner)
: owner_(owner), : owner_(owner),
box_layout_(nullptr), box_layout_(nullptr),
scroller_(nullptr), scroller_(nullptr),
...@@ -259,14 +257,14 @@ TrayDetailsView::TrayDetailsView(SystemTrayItem* owner) ...@@ -259,14 +257,14 @@ TrayDetailsView::TrayDetailsView(SystemTrayItem* owner)
this, ui::NativeTheme::kColorId_BubbleBackground)); this, ui::NativeTheme::kColorId_BubbleBackground));
} }
TrayDetailsView::~TrayDetailsView() = default; TrayDetailedView::~TrayDetailedView() = default;
void TrayDetailsView::OnViewClicked(views::View* sender) { void TrayDetailedView::OnViewClicked(views::View* sender) {
HandleViewClicked(sender); HandleViewClicked(sender);
} }
void TrayDetailsView::ButtonPressed(views::Button* sender, void TrayDetailedView::ButtonPressed(views::Button* sender,
const ui::Event& event) { const ui::Event& event) {
if (sender == back_button_) { if (sender == back_button_) {
TransitionToDefaultView(); TransitionToDefaultView();
return; return;
...@@ -275,7 +273,7 @@ void TrayDetailsView::ButtonPressed(views::Button* sender, ...@@ -275,7 +273,7 @@ void TrayDetailsView::ButtonPressed(views::Button* sender,
HandleButtonPressed(sender, event); HandleButtonPressed(sender, event);
} }
void TrayDetailsView::CreateTitleRow(int string_id) { void TrayDetailedView::CreateTitleRow(int string_id) {
DCHECK(!tri_view_); DCHECK(!tri_view_);
tri_view_ = TrayPopupUtils::CreateDefaultRowView(); tri_view_ = TrayPopupUtils::CreateDefaultRowView();
...@@ -307,7 +305,7 @@ void TrayDetailsView::CreateTitleRow(int string_id) { ...@@ -307,7 +305,7 @@ void TrayDetailsView::CreateTitleRow(int string_id) {
Layout(); Layout();
} }
void TrayDetailsView::CreateScrollableList() { void TrayDetailedView::CreateScrollableList() {
DCHECK(!scroller_); DCHECK(!scroller_);
scroll_content_ = new ScrollContentsView(); scroll_content_ = new ScrollContentsView();
scroller_ = new views::ScrollView; scroller_ = new views::ScrollView;
...@@ -324,7 +322,7 @@ void TrayDetailsView::CreateScrollableList() { ...@@ -324,7 +322,7 @@ void TrayDetailsView::CreateScrollableList() {
box_layout_->SetFlexForView(scroller_, 1); box_layout_->SetFlexForView(scroller_, 1);
} }
HoverHighlightView* TrayDetailsView::AddScrollListItem( HoverHighlightView* TrayDetailedView::AddScrollListItem(
const gfx::VectorIcon& icon, const gfx::VectorIcon& icon,
const base::string16& text) { const base::string16& text) {
HoverHighlightView* item = new HoverHighlightView(this); HoverHighlightView* item = new HoverHighlightView(this);
...@@ -336,7 +334,7 @@ HoverHighlightView* TrayDetailsView::AddScrollListItem( ...@@ -336,7 +334,7 @@ HoverHighlightView* TrayDetailsView::AddScrollListItem(
return item; return item;
} }
HoverHighlightView* TrayDetailsView::AddScrollListCheckableItem( HoverHighlightView* TrayDetailedView::AddScrollListCheckableItem(
const gfx::VectorIcon& icon, const gfx::VectorIcon& icon,
const base::string16& text, const base::string16& text,
bool checked) { bool checked) {
...@@ -345,13 +343,13 @@ HoverHighlightView* TrayDetailsView::AddScrollListCheckableItem( ...@@ -345,13 +343,13 @@ HoverHighlightView* TrayDetailsView::AddScrollListCheckableItem(
return item; return item;
} }
HoverHighlightView* TrayDetailsView::AddScrollListCheckableItem( HoverHighlightView* TrayDetailedView::AddScrollListCheckableItem(
const base::string16& text, const base::string16& text,
bool checked) { bool checked) {
return AddScrollListCheckableItem(gfx::kNoneIcon, text, checked); return AddScrollListCheckableItem(gfx::kNoneIcon, text, checked);
} }
void TrayDetailsView::SetupConnectedScrollListItem(HoverHighlightView* view) { void TrayDetailedView::SetupConnectedScrollListItem(HoverHighlightView* view) {
DCHECK(view->is_populated()); DCHECK(view->is_populated());
view->SetSubText( view->SetSubText(
...@@ -361,15 +359,15 @@ void TrayDetailsView::SetupConnectedScrollListItem(HoverHighlightView* view) { ...@@ -361,15 +359,15 @@ void TrayDetailsView::SetupConnectedScrollListItem(HoverHighlightView* view) {
style.SetupLabel(view->sub_text_label()); style.SetupLabel(view->sub_text_label());
} }
void TrayDetailsView::SetupConnectingScrollListItem(HoverHighlightView* view) { void TrayDetailedView::SetupConnectingScrollListItem(HoverHighlightView* view) {
DCHECK(view->is_populated()); DCHECK(view->is_populated());
view->SetSubText( view->SetSubText(
l10n_util::GetStringUTF16(IDS_ASH_STATUS_TRAY_NETWORK_STATUS_CONNECTING)); l10n_util::GetStringUTF16(IDS_ASH_STATUS_TRAY_NETWORK_STATUS_CONNECTING));
} }
TriView* TrayDetailsView::AddScrollListSubHeader(const gfx::VectorIcon& icon, TriView* TrayDetailedView::AddScrollListSubHeader(const gfx::VectorIcon& icon,
int text_id) { int text_id) {
TriView* header = TrayPopupUtils::CreateSubHeaderRowView(!icon.is_empty()); TriView* header = TrayPopupUtils::CreateSubHeaderRowView(!icon.is_empty());
TrayPopupUtils::ConfigureAsStickyHeader(header); TrayPopupUtils::ConfigureAsStickyHeader(header);
...@@ -391,11 +389,11 @@ TriView* TrayDetailsView::AddScrollListSubHeader(const gfx::VectorIcon& icon, ...@@ -391,11 +389,11 @@ TriView* TrayDetailsView::AddScrollListSubHeader(const gfx::VectorIcon& icon,
return header; return header;
} }
TriView* TrayDetailsView::AddScrollListSubHeader(int text_id) { TriView* TrayDetailedView::AddScrollListSubHeader(int text_id) {
return AddScrollListSubHeader(gfx::kNoneIcon, text_id); return AddScrollListSubHeader(gfx::kNoneIcon, text_id);
} }
void TrayDetailsView::Reset() { void TrayDetailedView::Reset() {
RemoveAllChildViews(true); RemoveAllChildViews(true);
scroller_ = nullptr; scroller_ = nullptr;
scroll_content_ = nullptr; scroll_content_ = nullptr;
...@@ -404,7 +402,7 @@ void TrayDetailsView::Reset() { ...@@ -404,7 +402,7 @@ void TrayDetailsView::Reset() {
tri_view_ = nullptr; tri_view_ = nullptr;
} }
void TrayDetailsView::ShowProgress(double value, bool visible) { void TrayDetailedView::ShowProgress(double value, bool visible) {
DCHECK(tri_view_); DCHECK(tri_view_);
if (!progress_bar_) { if (!progress_bar_) {
progress_bar_ = new views::ProgressBar(kTitleRowProgressBarHeight); progress_bar_ = new views::ProgressBar(kTitleRowProgressBarHeight);
...@@ -417,7 +415,7 @@ void TrayDetailsView::ShowProgress(double value, bool visible) { ...@@ -417,7 +415,7 @@ void TrayDetailsView::ShowProgress(double value, bool visible) {
child_at(kTitleRowSeparatorIndex)->SetVisible(!visible); child_at(kTitleRowSeparatorIndex)->SetVisible(!visible);
} }
views::Button* TrayDetailsView::CreateSettingsButton( views::Button* TrayDetailedView::CreateSettingsButton(
int setting_accessible_name_id) { int setting_accessible_name_id) {
SystemMenuButton* button = new SystemMenuButton(this, kSystemMenuSettingsIcon, SystemMenuButton* button = new SystemMenuButton(this, kSystemMenuSettingsIcon,
setting_accessible_name_id); setting_accessible_name_id);
...@@ -426,7 +424,7 @@ views::Button* TrayDetailsView::CreateSettingsButton( ...@@ -426,7 +424,7 @@ views::Button* TrayDetailsView::CreateSettingsButton(
return button; return button;
} }
views::Button* TrayDetailsView::CreateHelpButton() { views::Button* TrayDetailedView::CreateHelpButton() {
SystemMenuButton* button = SystemMenuButton* button =
new SystemMenuButton(this, kSystemMenuHelpIcon, IDS_ASH_STATUS_TRAY_HELP); new SystemMenuButton(this, kSystemMenuHelpIcon, IDS_ASH_STATUS_TRAY_HELP);
// Help opens a web page, so treat it like Web UI settings. // Help opens a web page, so treat it like Web UI settings.
...@@ -435,29 +433,29 @@ views::Button* TrayDetailsView::CreateHelpButton() { ...@@ -435,29 +433,29 @@ views::Button* TrayDetailsView::CreateHelpButton() {
return button; return button;
} }
void TrayDetailsView::HandleViewClicked(views::View* view) { void TrayDetailedView::HandleViewClicked(views::View* view) {
NOTREACHED(); NOTREACHED();
} }
void TrayDetailsView::HandleButtonPressed(views::Button* sender, void TrayDetailedView::HandleButtonPressed(views::Button* sender,
const ui::Event& event) { const ui::Event& event) {
NOTREACHED(); NOTREACHED();
} }
void TrayDetailsView::CreateExtraTitleRowButtons() {} void TrayDetailedView::CreateExtraTitleRowButtons() {}
void TrayDetailsView::TransitionToDefaultView() { void TrayDetailedView::TransitionToDefaultView() {
if (back_button_ && back_button_->HasFocus()) if (back_button_ && back_button_->HasFocus())
owner_->set_restore_focus(true); owner_->set_restore_focus(true);
transition_delay_timer_.Start( transition_delay_timer_.Start(
FROM_HERE, FROM_HERE,
base::TimeDelta::FromMilliseconds(kTrayDetailedViewTransitionDelayMs), base::TimeDelta::FromMilliseconds(kTrayDetailedViewTransitionDelayMs),
this, &TrayDetailsView::DoTransitionToDefaultView); this, &TrayDetailedView::DoTransitionToDefaultView);
} }
void TrayDetailsView::DoTransitionToDefaultView() { void TrayDetailedView::DoTransitionToDefaultView() {
// Cache pointer to owner in this function scope. TrayDetailsView will be // Cache pointer to owner in this function scope. TrayDetailedView will be
// deleted after called ShowDefaultView. // deleted after called ShowDefaultView.
SystemTrayItem* owner = owner_; SystemTrayItem* owner = owner_;
owner->system_tray()->ShowDefaultView(BUBBLE_USE_EXISTING, owner->system_tray()->ShowDefaultView(BUBBLE_USE_EXISTING,
...@@ -465,19 +463,19 @@ void TrayDetailsView::DoTransitionToDefaultView() { ...@@ -465,19 +463,19 @@ void TrayDetailsView::DoTransitionToDefaultView() {
owner->set_restore_focus(false); owner->set_restore_focus(false);
} }
views::Button* TrayDetailsView::CreateBackButton() { views::Button* TrayDetailedView::CreateBackButton() {
SystemMenuButton* button = new SystemMenuButton( SystemMenuButton* button = new SystemMenuButton(
this, kSystemMenuArrowBackIcon, IDS_ASH_STATUS_TRAY_PREVIOUS_MENU); this, kSystemMenuArrowBackIcon, IDS_ASH_STATUS_TRAY_PREVIOUS_MENU);
return button; return button;
} }
void TrayDetailsView::Layout() { void TrayDetailedView::Layout() {
views::View::Layout(); views::View::Layout();
if (scroller_ && !scroller_->is_bounded()) if (scroller_ && !scroller_->is_bounded())
scroller_->ClipHeightTo(0, scroller_->height()); scroller_->ClipHeightTo(0, scroller_->height());
} }
int TrayDetailsView::GetHeightForWidth(int width) const { int TrayDetailedView::GetHeightForWidth(int width) const {
if (bounds().IsEmpty()) if (bounds().IsEmpty())
return views::View::GetHeightForWidth(width); return views::View::GetHeightForWidth(width);
......
...@@ -2,8 +2,8 @@ ...@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
#ifndef ASH_SYSTEM_TRAY_TRAY_DETAILS_VIEW_H_ #ifndef ASH_SYSTEM_TRAY_TRAY_DETAILED_VIEW_H_
#define ASH_SYSTEM_TRAY_TRAY_DETAILS_VIEW_H_ #define ASH_SYSTEM_TRAY_TRAY_DETAILED_VIEW_H_
#include <memory> #include <memory>
...@@ -33,12 +33,12 @@ class ScrollBorder; ...@@ -33,12 +33,12 @@ class ScrollBorder;
class SystemTrayItem; class SystemTrayItem;
class TriView; class TriView;
class ASH_EXPORT TrayDetailsView : public views::View, class ASH_EXPORT TrayDetailedView : public views::View,
public ViewClickListener, public ViewClickListener,
public views::ButtonListener { public views::ButtonListener {
public: public:
explicit TrayDetailsView(SystemTrayItem* owner); explicit TrayDetailedView(SystemTrayItem* owner);
~TrayDetailsView() override; ~TrayDetailedView() override;
// ViewClickListener: // ViewClickListener:
// Don't override this --- override HandleViewClicked. // Don't override this --- override HandleViewClicked.
...@@ -115,7 +115,7 @@ class ASH_EXPORT TrayDetailsView : public views::View, ...@@ -115,7 +115,7 @@ class ASH_EXPORT TrayDetailsView : public views::View,
views::View* scroll_content() const { return scroll_content_; } views::View* scroll_content() const { return scroll_content_; }
private: private:
friend class TrayDetailsViewTest; friend class TrayDetailedViewTest;
// Overridden to handle clicks on subclass-specific views. // Overridden to handle clicks on subclass-specific views.
virtual void HandleViewClicked(views::View* view); virtual void HandleViewClicked(views::View* view);
...@@ -160,9 +160,9 @@ class ASH_EXPORT TrayDetailsView : public views::View, ...@@ -160,9 +160,9 @@ class ASH_EXPORT TrayDetailsView : public views::View,
// Used to delay the transition to the default view. // Used to delay the transition to the default view.
base::OneShotTimer transition_delay_timer_; base::OneShotTimer transition_delay_timer_;
DISALLOW_COPY_AND_ASSIGN(TrayDetailsView); DISALLOW_COPY_AND_ASSIGN(TrayDetailedView);
}; };
} // namespace ash } // namespace ash
#endif // ASH_SYSTEM_TRAY_TRAY_DETAILS_VIEW_H_ #endif // ASH_SYSTEM_TRAY_TRAY_DETAILED_VIEW_H_
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
#include "ash/system/tray/tray_details_view.h" #include "ash/system/tray/tray_detailed_view.h"
#include "ash/ash_view_ids.h" #include "ash/ash_view_ids.h"
#include "ash/strings/grit/ash_strings.h" #include "ash/strings/grit/ash_strings.h"
...@@ -25,9 +25,9 @@ namespace ash { ...@@ -25,9 +25,9 @@ namespace ash {
namespace { namespace {
class TestDetailsView : public TrayDetailsView { class TestDetailsView : public TrayDetailedView {
public: public:
explicit TestDetailsView(SystemTrayItem* owner) : TrayDetailsView(owner) { explicit TestDetailsView(SystemTrayItem* owner) : TrayDetailedView(owner) {
// Uses bluetooth label for testing purpose. It can be changed to any // Uses bluetooth label for testing purpose. It can be changed to any
// string_id. // string_id.
CreateTitleRow(IDS_ASH_STATUS_TRAY_BLUETOOTH); CreateTitleRow(IDS_ASH_STATUS_TRAY_BLUETOOTH);
...@@ -38,7 +38,7 @@ class TestDetailsView : public TrayDetailsView { ...@@ -38,7 +38,7 @@ class TestDetailsView : public TrayDetailsView {
void CreateScrollerViews() { CreateScrollableList(); } void CreateScrollerViews() { CreateScrollableList(); }
views::View* scroll_content() const { views::View* scroll_content() const {
return TrayDetailsView::scroll_content(); return TrayDetailedView::scroll_content();
} }
private: private:
...@@ -86,10 +86,10 @@ class TestItem : public SystemTrayItem { ...@@ -86,10 +86,10 @@ class TestItem : public SystemTrayItem {
} // namespace } // namespace
class TrayDetailsViewTest : public AshTestBase { class TrayDetailedViewTest : public AshTestBase {
public: public:
TrayDetailsViewTest() = default; TrayDetailedViewTest() = default;
~TrayDetailsViewTest() override = default; ~TrayDetailedViewTest() override = default;
void TransitionFromDetailedToDefaultView(TestDetailsView* detailed) { void TransitionFromDetailedToDefaultView(TestDetailsView* detailed) {
detailed->TransitionToDefaultView(); detailed->TransitionToDefaultView();
...@@ -118,10 +118,10 @@ class TrayDetailsViewTest : public AshTestBase { ...@@ -118,10 +118,10 @@ class TrayDetailsViewTest : public AshTestBase {
std::unique_ptr<base::ScopedMockTimeMessageLoopTaskRunner> std::unique_ptr<base::ScopedMockTimeMessageLoopTaskRunner>
scoped_task_runner_; scoped_task_runner_;
DISALLOW_COPY_AND_ASSIGN(TrayDetailsViewTest); DISALLOW_COPY_AND_ASSIGN(TrayDetailedViewTest);
}; };
TEST_F(TrayDetailsViewTest, TransitionToDefaultViewTest) { TEST_F(TrayDetailedViewTest, TransitionToDefaultViewTest) {
SystemTray* tray = GetPrimarySystemTray(); SystemTray* tray = GetPrimarySystemTray();
ASSERT_TRUE(tray->GetWidget()); ASSERT_TRUE(tray->GetWidget());
...@@ -171,7 +171,7 @@ TEST_F(TrayDetailsViewTest, TransitionToDefaultViewTest) { ...@@ -171,7 +171,7 @@ TEST_F(TrayDetailsViewTest, TransitionToDefaultViewTest) {
EXPECT_FALSE(test_item_2->default_view()->HasFocus()); EXPECT_FALSE(test_item_2->default_view()->HasFocus());
} }
TEST_F(TrayDetailsViewTest, ScrollContentsTest) { TEST_F(TrayDetailedViewTest, ScrollContentsTest) {
SystemTray* tray = GetPrimarySystemTray(); SystemTray* tray = GetPrimarySystemTray();
TestItem* test_item = new TestItem; TestItem* test_item = new TestItem;
tray->AddTrayItem(base::WrapUnique(test_item)); tray->AddTrayItem(base::WrapUnique(test_item));
......
...@@ -63,8 +63,8 @@ class TrayPopupUtils { ...@@ -63,8 +63,8 @@ class TrayPopupUtils {
// can grow into the CENTER container if space is required and available. The // can grow into the CENTER container if space is required and available. The
// CENTER container has a flexible width. // CENTER container has a flexible width.
// //
// TODO(mohsen): Merge this into TrayDetailsView::AddScrollListSubHeader() // TODO(mohsen): Merge this into TrayDetailedView::AddScrollListSubHeader()
// once network and VPN also use TrayDetailsView::AddScrollListSubHeader(). // once network and VPN also use TrayDetailedView::AddScrollListSubHeader().
static TriView* CreateSubHeaderRowView(bool start_visible); static TriView* CreateSubHeaderRowView(bool start_visible);
// Creates a container view to be used by system menu rows that want to embed // Creates a container view to be used by system menu rows that want to embed
......
...@@ -19,7 +19,7 @@ ...@@ -19,7 +19,7 @@
#include "ash/system/tray/hover_highlight_view.h" #include "ash/system/tray/hover_highlight_view.h"
#include "ash/system/tray/system_tray.h" #include "ash/system/tray/system_tray.h"
#include "ash/system/tray/system_tray_controller.h" #include "ash/system/tray/system_tray_controller.h"
#include "ash/system/tray/tray_details_view.h" #include "ash/system/tray/tray_detailed_view.h"
#include "ash/system/tray/tray_item_more.h" #include "ash/system/tray/tray_item_more.h"
#include "ash/system/tray/tray_popup_utils.h" #include "ash/system/tray/tray_popup_utils.h"
#include "ash/system/tray/tri_view.h" #include "ash/system/tray/tri_view.h"
...@@ -131,7 +131,7 @@ class DefaultAccessibilityView : public TrayItemMore { ...@@ -131,7 +131,7 @@ class DefaultAccessibilityView : public TrayItemMore {
// ash::tray::AccessibilityDetailedView // ash::tray::AccessibilityDetailedView
AccessibilityDetailedView::AccessibilityDetailedView(SystemTrayItem* owner) AccessibilityDetailedView::AccessibilityDetailedView(SystemTrayItem* owner)
: TrayDetailsView(owner) { : TrayDetailedView(owner) {
Reset(); Reset();
AppendAccessibilityList(); AppendAccessibilityList();
CreateTitleRow(IDS_ASH_STATUS_TRAY_ACCESSIBILITY_TITLE); CreateTitleRow(IDS_ASH_STATUS_TRAY_ACCESSIBILITY_TITLE);
......
...@@ -9,7 +9,7 @@ ...@@ -9,7 +9,7 @@
#include "ash/accessibility/accessibility_delegate.h" #include "ash/accessibility/accessibility_delegate.h"
#include "ash/accessibility/accessibility_observer.h" #include "ash/accessibility/accessibility_observer.h"
#include "ash/system/tray/tray_details_view.h" #include "ash/system/tray/tray_detailed_view.h"
#include "ash/system/tray/tray_image_item.h" #include "ash/system/tray/tray_image_item.h"
#include "base/macros.h" #include "base/macros.h"
#include "ui/gfx/font.h" #include "ui/gfx/font.h"
...@@ -35,7 +35,7 @@ class TrayAccessibilityTest; ...@@ -35,7 +35,7 @@ class TrayAccessibilityTest;
namespace tray { namespace tray {
// Create the detailed view of accessibility tray. // Create the detailed view of accessibility tray.
class AccessibilityDetailedView : public TrayDetailsView { class AccessibilityDetailedView : public TrayDetailedView {
public: public:
explicit AccessibilityDetailedView(SystemTrayItem* owner); explicit AccessibilityDetailedView(SystemTrayItem* owner);
~AccessibilityDetailedView() override {} ~AccessibilityDetailedView() override {}
...@@ -47,7 +47,7 @@ class AccessibilityDetailedView : public TrayDetailsView { ...@@ -47,7 +47,7 @@ class AccessibilityDetailedView : public TrayDetailsView {
friend class ::ash::TrayAccessibilityTest; friend class ::ash::TrayAccessibilityTest;
friend class chromeos::TrayAccessibilityTest; friend class chromeos::TrayAccessibilityTest;
// TrayDetailsView: // TrayDetailedView:
void HandleViewClicked(views::View* view) override; void HandleViewClicked(views::View* view) override;
void HandleButtonPressed(views::Button* sender, void HandleButtonPressed(views::Button* sender,
const ui::Event& event) override; const ui::Event& event) override;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment