Extensions: Match search on extension ID as well as name

Bug: 1158048
Change-Id: I68b7a7ecacd407bde2a331681ad36a53f74f159c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572676
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836345}

chrome/browser/resources/extensions/item_list.js

@@ -99,9 +99,12 @@ Polymer({
    */
   computeFilter_() {
     const formattedFilter = this.filter.trim().toLowerCase();
-    return formattedFilter ?
-        i => i.name.toLowerCase().includes(formattedFilter) :
-        null;
+    if (!formattedFilter) {
+      return null;
+    }
+
+    return i => [i.name, i.id].some(
+               s => s.toLowerCase().includes(formattedFilter));
   },
 
   /** @private */

chrome/test/data/webui/extensions/item_list_test.js

@@ -35,7 +35,7 @@ suite(extension_item_list_tests.suiteName, function() {
     const extensionItems = [
       createExt({name: 'Alpha', id: 'a'.repeat(32)}),
       createExt({name: 'Bravo', id: 'b'.repeat(32)}),
-      createExt({name: 'Charlie', id: 'c'.repeat(32)})
+      createExt({name: 'Charlie', id: 'c'.repeat(29) + 'wxy'})
     ];
     const appItems = [
       createExt({name: 'QQ', id: 'q'.repeat(32)}),
@@ -83,6 +83,11 @@ suite(extension_item_list_tests.suiteName, function() {
     // A filter of 'q' should should show just the apps item.
     itemList.filter = 'q';
     itemLengthEquals(1);
+    // A filter of 'xy' should show just the 'Charlie' item since its id
+    // matches.
+    itemList.filter = 'xy';
+    itemLengthEquals(1);
+    expectEquals('Charlie', itemList.$$('extensions-item').data.name);
   });
 
   test(assert(extension_item_list_tests.TestNames.NoItemsMsg), function() {