Commit bb8bb4ec authored by Eugene But's avatar Eugene But Committed by Commit Bot

Remove google_toolbox_unittest.mm as unnecessary.

The test was calling gtm_dictionaryWithHttpArgumentsString method
to verify that method exists. Chrome does not call this
method, so there is no need to test method existence.

Bug: 933827
Change-Id: I86200d3d8bbb9096f12277b7e951422b07672d8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500628
Auto-Submit: Eugene But <eugenebut@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: default avatarRohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638420}
parent d2688e66
...@@ -97,19 +97,6 @@ source_set("run_all_unittests") { ...@@ -97,19 +97,6 @@ source_set("run_all_unittests") {
] ]
} }
source_set("unit_tests") {
configs += [ "//build/config/compiler:enable_arc" ]
testonly = true
sources = [
"google_toolbox_unittest.mm",
]
deps = [
"//base",
"//testing/gtest",
"//third_party/google_toolbox_for_mac",
]
}
test("ios_chrome_perftests") { test("ios_chrome_perftests") {
deps = [ deps = [
# Ensure that all perf tests are run, use fake hooks and pack resources. # Ensure that all perf tests are run, use fake hooks and pack resources.
...@@ -134,7 +121,6 @@ test("ios_chrome_unittests") { ...@@ -134,7 +121,6 @@ test("ios_chrome_unittests") {
ios_packed_resources_target, ios_packed_resources_target,
# Add unit_tests target here. # Add unit_tests target here.
":unit_tests",
"//ios/chrome/app:unit_tests", "//ios/chrome/app:unit_tests",
"//ios/chrome/app/application_delegate:unit_tests", "//ios/chrome/app/application_delegate:unit_tests",
"//ios/chrome/app/spotlight:unit_tests", "//ios/chrome/app/spotlight:unit_tests",
......
// Copyright (c) 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#import <Foundation/Foundation.h>
#include "base/logging.h"
#import "testing/gtest_mac.h"
#include "testing/platform_test.h"
#import "third_party/google_toolbox_for_mac/src/Foundation/GTMNSDictionary+URLArguments.h"
#if !defined(__has_feature) || !__has_feature(objc_arc)
#error "This file requires ARC support."
#endif
using GoogleToolboxForMacTest = PlatformTest;
// TODO(crbug.com/933827): Remove this pragma.
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
// [NSDictionary gtm_dictionaryWithHttpArgumentsString] is used downstream.
// This test ensures that we keep compiling the file.
TEST_F(GoogleToolboxForMacTest, dictionaryWithHttpArgumentsString) {
NSDictionary* dict = [NSDictionary gtm_dictionaryWithHttpArgumentsString:@""];
EXPECT_EQ(0u, [dict count]);
}
#pragma clang diagnostic pop
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment