Commit bb93fe71 authored by Gauthier Ambard's avatar Gauthier Ambard Committed by Commit Bot

Revert "[iOS] Disable failing Content Suggestions test"

This reverts commit e04c9b25.

Reason for revert: It was probably failing because of the device being in landscape

Original change's description:
> [iOS] Disable failing Content Suggestions test
>
> Disables ContentSuggestionsTestCase/testReloadPage which is failing on
> iphone-device.
>
> TBR=gambard@chromium.org
>
> Bug: 1046258
> Change-Id: I8688122f2daab124b063059b6187f5fe0a7a6026
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024888
> Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#735815}

TBR=gambard@chromium.org,javierrobles@chromium.org

Change-Id: I7508c1b2b3d983c426855b194eb075972625f7f7
Bug: 1046258
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027412Reviewed-by: default avatarJavier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: default avatarGauthier Ambard <gambard@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736326}
parent b702d363
...@@ -175,13 +175,6 @@ GREYElementInteraction* CellWithMatcher(id<GREYMatcher> matcher) { ...@@ -175,13 +175,6 @@ GREYElementInteraction* CellWithMatcher(id<GREYMatcher> matcher) {
// Tests that when the page is reloaded using the tools menu, the suggestions // Tests that when the page is reloaded using the tools menu, the suggestions
// are updated. // are updated.
- (void)testReloadPage { - (void)testReloadPage {
// TODO(crbug.com/1046258): fix for iphone-device and reenable.
#if !TARGET_IPHONE_SIMULATOR
if (![ChromeEarlGrey isIPadIdiom]) {
EARL_GREY_TEST_DISABLED(@"Test disabled on iPhone devices.");
}
#endif
// Add 2 suggestions, persisted accross page loads. // Add 2 suggestions, persisted accross page loads.
[ContentSuggestionsAppInterface addNumberOfSuggestions:2 [ContentSuggestionsAppInterface addNumberOfSuggestions:2
additionalSuggestionsURL:nil]; additionalSuggestionsURL:nil];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment