Commit bba578c3 authored by ch.dumez@samsung.com's avatar ch.dumez@samsung.com

Clarify comments for methods added in r178921

Clarify comments for methods added in r178921 as per follow-up review comments.

R=pdr@chromium.org

Review URL: https://codereview.chromium.org/423823005

git-svn-id: svn://svn.chromium.org/blink/trunk@179044 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 122203e5
...@@ -67,7 +67,7 @@ private: ...@@ -67,7 +67,7 @@ private:
Attr(Element&, const QualifiedName&); Attr(Element&, const QualifiedName&);
Attr(Document&, const QualifiedName&, const AtomicString& value); Attr(Document&, const QualifiedName&, const AtomicString& value);
bool isElementNode() const WTF_DELETED_FUNCTION; // Hide to catch useless calls. bool isElementNode() const WTF_DELETED_FUNCTION; // This will catch anyone doing an unnecessary check.
void createTextChild(); void createTextChild();
......
...@@ -76,8 +76,8 @@ private: ...@@ -76,8 +76,8 @@ private:
virtual bool offsetInCharacters() const OVERRIDE FINAL; virtual bool offsetInCharacters() const OVERRIDE FINAL;
void setDataAndUpdate(const String&, unsigned offsetOfReplacedData, unsigned oldLength, unsigned newLength, RecalcStyleBehavior = DoNotRecalcStyle); void setDataAndUpdate(const String&, unsigned offsetOfReplacedData, unsigned oldLength, unsigned newLength, RecalcStyleBehavior = DoNotRecalcStyle);
bool isContainerNode() const WTF_DELETED_FUNCTION; // Hide to catch useless calls. bool isContainerNode() const WTF_DELETED_FUNCTION; // This will catch anyone doing an unnecessary check.
bool isElementNode() const WTF_DELETED_FUNCTION; // Hide to catch useless calls. bool isElementNode() const WTF_DELETED_FUNCTION; // This will catch anyone doing an unnecessary check.
}; };
DEFINE_NODE_TYPE_CASTS(CharacterData, isCharacterDataNode()); DEFINE_NODE_TYPE_CASTS(CharacterData, isCharacterDataNode());
......
...@@ -186,8 +186,8 @@ protected: ...@@ -186,8 +186,8 @@ protected:
void setLastChild(Node* child) { m_lastChild = child; } void setLastChild(Node* child) { m_lastChild = child; }
private: private:
bool isContainerNode() const WTF_DELETED_FUNCTION; // Hide to catch useless calls. bool isContainerNode() const WTF_DELETED_FUNCTION; // This will catch anyone doing an unnecessary check.
bool isTextNode() const WTF_DELETED_FUNCTION; // Hide to catch useless calls. bool isTextNode() const WTF_DELETED_FUNCTION; // This will catch anyone doing an unnecessary check.
void removeBetween(Node* previousChild, Node* nextChild, Node& oldChild); void removeBetween(Node* previousChild, Node* nextChild, Node& oldChild);
void insertBeforeCommon(Node& nextChild, Node& oldChild); void insertBeforeCommon(Node& nextChild, Node& oldChild);
......
...@@ -1073,9 +1073,9 @@ private: ...@@ -1073,9 +1073,9 @@ private:
friend class Node; friend class Node;
friend class IgnoreDestructiveWriteCountIncrementer; friend class IgnoreDestructiveWriteCountIncrementer;
bool isDocumentFragment() const WTF_DELETED_FUNCTION; // Hide to catch useless calls. bool isDocumentFragment() const WTF_DELETED_FUNCTION; // This will catch anyone doing an unnecessary check.
bool isDocumentNode() const WTF_DELETED_FUNCTION; // Hide to catch useless calls. bool isDocumentNode() const WTF_DELETED_FUNCTION; // This will catch anyone doing an unnecessary check.
bool isElementNode() const WTF_DELETED_FUNCTION; // Hide to catch useless calls. bool isElementNode() const WTF_DELETED_FUNCTION; // This will catch anyone doing an unnecessary check.
ScriptedAnimationController& ensureScriptedAnimationController(); ScriptedAnimationController& ensureScriptedAnimationController();
virtual SecurityContext& securityContext() OVERRIDE FINAL { return *this; } virtual SecurityContext& securityContext() OVERRIDE FINAL { return *this; }
......
...@@ -48,7 +48,7 @@ private: ...@@ -48,7 +48,7 @@ private:
virtual PassRefPtrWillBeRawPtr<Node> cloneNode(bool deep = true) OVERRIDE; virtual PassRefPtrWillBeRawPtr<Node> cloneNode(bool deep = true) OVERRIDE;
virtual bool childTypeAllowed(NodeType) const OVERRIDE; virtual bool childTypeAllowed(NodeType) const OVERRIDE;
bool isDocumentFragment() const WTF_DELETED_FUNCTION; // Hide to catch useless calls. bool isDocumentFragment() const WTF_DELETED_FUNCTION; // This will catch anyone doing an unnecessary check.
}; };
DEFINE_NODE_TYPE_CASTS(DocumentFragment, isDocumentFragment()); DEFINE_NODE_TYPE_CASTS(DocumentFragment, isDocumentFragment());
......
...@@ -561,9 +561,9 @@ private: ...@@ -561,9 +561,9 @@ private:
void clearElementFlag(ElementFlags); void clearElementFlag(ElementFlags);
bool hasElementFlagInternal(ElementFlags) const; bool hasElementFlagInternal(ElementFlags) const;
bool isElementNode() const WTF_DELETED_FUNCTION; // Hide to catch useless calls. bool isElementNode() const WTF_DELETED_FUNCTION; // This will catch anyone doing an unnecessary check.
bool isDocumentFragment() const WTF_DELETED_FUNCTION; // Hide to catch useless calls. bool isDocumentFragment() const WTF_DELETED_FUNCTION; // This will catch anyone doing an unnecessary check.
bool isDocumentNode() const WTF_DELETED_FUNCTION; // Hide to catch useless calls. bool isDocumentNode() const WTF_DELETED_FUNCTION; // This will catch anyone doing an unnecessary check.
void styleAttributeChanged(const AtomicString& newStyleString, AttributeModificationReason); void styleAttributeChanged(const AtomicString& newStyleString, AttributeModificationReason);
......
...@@ -70,7 +70,7 @@ private: ...@@ -70,7 +70,7 @@ private:
virtual String nodeName() const OVERRIDE; virtual String nodeName() const OVERRIDE;
virtual PassRefPtrWillBeRawPtr<Node> cloneNode(bool deep = true) OVERRIDE FINAL; virtual PassRefPtrWillBeRawPtr<Node> cloneNode(bool deep = true) OVERRIDE FINAL;
bool isTextNode() const WTF_DELETED_FUNCTION; // Hide to catch useless calls. bool isTextNode() const WTF_DELETED_FUNCTION; // This will catch anyone doing an unnecessary check.
bool needsWhitespaceRenderer(); bool needsWhitespaceRenderer();
......
...@@ -78,7 +78,7 @@ protected: ...@@ -78,7 +78,7 @@ protected:
virtual void willRecalcStyle(StyleRecalcChange) OVERRIDE; virtual void willRecalcStyle(StyleRecalcChange) OVERRIDE;
private: private:
bool isInsertionPoint() const WTF_DELETED_FUNCTION; // Hide to catch useless calls. bool isInsertionPoint() const WTF_DELETED_FUNCTION; // This will catch anyone doing an unnecessary check.
ContentDistribution m_distribution; ContentDistribution m_distribution;
bool m_registeredWithShadowRoot; bool m_registeredWithShadowRoot;
......
...@@ -115,8 +115,8 @@ protected: ...@@ -115,8 +115,8 @@ protected:
private: private:
virtual String nodeName() const OVERRIDE FINAL; virtual String nodeName() const OVERRIDE FINAL;
bool isHTMLElement() const WTF_DELETED_FUNCTION; // Hide to catch useless calls. bool isHTMLElement() const WTF_DELETED_FUNCTION; // This will catch anyone doing an unnecessary check.
bool isStyledElement() const WTF_DELETED_FUNCTION; // Hide to catch useless calls. bool isStyledElement() const WTF_DELETED_FUNCTION; // This will catch anyone doing an unnecessary check.
void mapLanguageAttributeToLocale(const AtomicString&, MutableStylePropertySet*); void mapLanguageAttributeToLocale(const AtomicString&, MutableStylePropertySet*);
......
...@@ -234,8 +234,8 @@ private: ...@@ -234,8 +234,8 @@ private:
// https://bugs.webkit.org/show_bug.cgi?id=77938 // https://bugs.webkit.org/show_bug.cgi?id=77938
virtual bool areAuthorShadowsAllowed() const OVERRIDE FINAL { return false; } virtual bool areAuthorShadowsAllowed() const OVERRIDE FINAL { return false; }
bool isSVGElement() const WTF_DELETED_FUNCTION; // Hide to catch useless calls. bool isSVGElement() const WTF_DELETED_FUNCTION; // This will catch anyone doing an unnecessary check.
bool isStyledElement() const WTF_DELETED_FUNCTION; // Hide to catch useless calls. bool isStyledElement() const WTF_DELETED_FUNCTION; // This will catch anyone doing an unnecessary check.
RenderStyle* computedStyle(PseudoId = NOPSEUDO); RenderStyle* computedStyle(PseudoId = NOPSEUDO);
virtual RenderStyle* virtualComputedStyle(PseudoId pseudoElementSpecifier = NOPSEUDO) OVERRIDE FINAL { return computedStyle(pseudoElementSpecifier); } virtual RenderStyle* virtualComputedStyle(PseudoId pseudoElementSpecifier = NOPSEUDO) OVERRIDE FINAL { return computedStyle(pseudoElementSpecifier); }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment