Remove dependency on //components/feedback on iOS

iOS does not use //components/feedback to report feedback so remove
the unused dependencies.

BUG=None

Review URL: https://codereview.chromium.org/1009943004

Cr-Commit-Position: refs/heads/master@{#320891}

chrome/browser/BUILD.gn

@@ -94,7 +94,6 @@ static_library("browser") {
     "//components/enhanced_bookmarks",
     "//components/favicon_base",
     "//components/favicon/core/browser",
-    "//components/feedback",
     "//components/gcm_driver",
     "//components/google/core/browser",
     "//components/handoff",
@@ -586,6 +585,7 @@ static_library("browser") {
                            ".",
                            "//chrome")
     deps += [
+      "//components/feedback",
       "//device/core",
       "//device/usb",
     ]
@@ -605,7 +605,6 @@ static_library("browser") {
     ]
     deps -= [
       "//third_party/libaddressinput",
-      "//components/feedback",
       "//components/storage_monitor",
       "//components/web_modal",
     ]

chrome/browser/ui/BUILD.gn

@@ -48,7 +48,6 @@ static_library("ui") {
     "//components/app_modal",
     "//components/auto_login_parser",
     "//components/dom_distiller/webui",
-    "//components/feedback/proto",
     "//components/invalidation",
     "//components/onc",
     "//components/password_manager/core/browser",
@@ -134,6 +133,7 @@ static_library("ui") {
                     "//chrome")
     deps += [
       "//components/copresence",
+      "//components/feedback/proto",
       "//device/bluetooth",
       "//third_party/libusb",
     ]
@@ -333,7 +333,6 @@ static_library("ui") {
     ]
     deps -= [
       "//chrome/browser/ui/views",
-      "//components/feedback/proto",
       "//ui/events",
     ]
     sources += rebase_path(gypi_values.chrome_browser_ui_android_sources,

chrome/chrome_browser.gypi

@@ -2922,7 +2922,6 @@
         '../components/components.gyp:enhanced_bookmarks',
         '../components/components.gyp:favicon_base',
         '../components/components.gyp:favicon_core_browser',
-        '../components/components.gyp:feedback_component',
         '../components/components.gyp:gcm_driver',
         '../components/components.gyp:google_core_browser',
         '../components/components.gyp:handoff',
@@ -3400,6 +3399,7 @@
         }, {  # OS!="android" and OS!="ios"
           'sources': [ '<@(chrome_browser_non_mobile_sources)' ],
           'dependencies': [
+            '../components/components.gyp:feedback_component',
             '../device/core/core.gyp:device_core',
             '../device/usb/usb.gyp:device_usb',
             '../net/net.gyp:net_browser_services',
@@ -3417,7 +3417,6 @@
             'chrome_browser_jni_headers',
           ],
           'dependencies!': [
-            '../components/components.gyp:feedback_component',
             '../components/components.gyp:storage_monitor',
             '../components/components.gyp:web_modal',
             '../third_party/libaddressinput/libaddressinput.gyp:libaddressinput',

chrome/chrome_browser_ui.gypi

@@ -2693,7 +2693,6 @@
         '../components/components.gyp:device_event_log_component',
         '../components/components.gyp:dom_distiller_core',
         '../components/components.gyp:dom_distiller_webui',
-        '../components/components.gyp:feedback_proto',
         '../components/components.gyp:invalidation',
         '../components/components.gyp:onc_component',
         '../components/components.gyp:password_manager_core_browser',
@@ -2973,7 +2972,6 @@
             'chrome_browser_jni_headers',
           ],
           'dependencies!': [
-             '../components/components.gyp:feedback_proto',
              '../ui/events/events.gyp:events',
              'chrome_browser_ui_views.gyp:browser_ui_views',
           ],
@@ -3167,6 +3165,7 @@
         }],
         ['OS!="android" and OS!="ios"', {
           'dependencies': [
+            '../components/components.gyp:feedback_proto',
             '../device/bluetooth/bluetooth.gyp:device_bluetooth',
             '../third_party/libusb/libusb.gyp:libusb',
           ],

components/components.gyp

@@ -28,7 +28,6 @@
     'enhanced_bookmarks.gypi',
     'error_page.gypi',
     'favicon_base.gypi',
-    'feedback.gypi',
     'google.gypi',
     'handoff.gypi',
     'infobars.gypi',
@@ -92,6 +91,7 @@
       'includes': [
         'audio_modem.gypi',
         'copresence.gypi',
+        'feedback.gypi',
         'proximity_auth.gypi',
         'storage_monitor.gypi',
       ]

components/components_tests.gyp

@@ -589,9 +589,6 @@
             '<@(domain_reliability_unittest_sources)',
             '<@(enhanced_bookmarks_unittest_sources)',
             '<@(favicon_base_unittest_sources)',
-            # This should be in the !android && !ios list, but has to be here
-            # due to a test bug making them order-dependent. crbug.com/462352
-            '<@(feedback_unittest_sources)',
             '<@(gcm_driver_unittest_sources)',
             '<@(google_unittest_sources)',
             '<@(history_unittest_sources)',
@@ -679,7 +676,6 @@
             'components.gyp:enhanced_bookmarks',
             'components.gyp:enhanced_bookmarks_test_support',
             'components.gyp:favicon_base',
-            'components.gyp:feedback_component',
             'components.gyp:gcm_driver',
             'components.gyp:gcm_driver_test_support',
             'components.gyp:google_core_browser',
@@ -811,9 +807,6 @@
               'sources!': [
                 'metrics/gpu/gpu_metrics_provider_unittest.cc',
                 'signin/core/browser/mutable_profile_oauth2_token_service_unittest.cc',
-                # This shouldn't be necessary, but the tests have to be in the main list
-                # due to a test bug making them order-dependent. crbug.com/462352
-                '<@(feedback_unittest_sources)',
               ],
               'sources/': [
                 # Exclude all tests that depends on //content (based on layered-
@@ -880,9 +873,6 @@
                 'invalidation/invalidation_service_android_unittest.cc',
               ],
               'sources!': [
-                # This shouldn't be necessary, but the tests have to be in the main list
-                # due to a test bug making them order-dependent. crbug.com/462352
-                '<@(feedback_unittest_sources)',
                 'gcm_driver/gcm_account_mapper_unittest.cc',
                 'gcm_driver/gcm_channel_status_request_unittest.cc',
                 'gcm_driver/gcm_client_impl_unittest.cc',
@@ -901,7 +891,6 @@
                 '../testing/android/native_test.gyp:native_test_native_code',
               ],
               'dependencies!': [
-                'components.gyp:feedback_component',
                 'components.gyp:storage_monitor',
                 'components.gyp:storage_monitor_test_support',
                 'components.gyp:web_modal',
@@ -917,6 +906,7 @@
               'sources': [
                 '<@(audio_modem_unittest_sources)',
                 '<@(copresence_unittest_sources)',
+                '<@(feedback_unittest_sources)',
                 '<@(proximity_auth_unittest_sources)',
               ],
               'dependencies': [
@@ -928,6 +918,7 @@
                 'components.gyp:copresence',
                 'components.gyp:copresence_test_support',
                 'components.gyp:cryptauth',
+                'components.gyp:feedback_component',
                 'components.gyp:proximity_auth',
               ],
             }],