[signin] Add test for back button in the profile creation signin promo

Bug: 1105865

Change-Id: I0f1091e2068e4a1cfff0e6eee9b2898a74e4a945
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308416
Commit-Queue: Diana Zagidullina <dizg@google.com>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Monica Basta <msalama@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790806}

chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

@@ -726,11 +726,9 @@ WebUIFactoryFunction GetWebUIFactoryFunction(WebUI* web_ui,
   }
 #endif  // defined(OS_ANDROID)
 #if !defined(OS_CHROMEOS) && !defined(OS_ANDROID)
-  if (url.host_piece() == chrome::kChromeUIProfilePickerHost &&
-      base::FeatureList::IsEnabled(features::kNewProfilePicker)) {
+  if (url.host_piece() == chrome::kChromeUIProfilePickerHost) {
     return &NewWebUI<ProfilePickerUI>;
   }
-
   if (url.host_piece() == chrome::kChromeUIMdUserManagerHost)
     return &NewWebUI<UserManagerUI>;
   if (url.host_piece() == chrome::kChromeUISigninErrorHost &&

chrome/test/data/webui/signin/BUILD.gn

@@ -8,11 +8,13 @@ js_type_check("closure_compile") {
   is_polymer3 = true
   closure_flags = default_closure_args + [
                     "browser_resolver_prefix_replacements=\"chrome://signin-dice-web-intercept/=../../chrome/browser/resources/signin/dice_web_signin_intercept/\"",
+                    "browser_resolver_prefix_replacements=\"chrome://profile-picker/=../../chrome/browser/resources/signin/profile_picker/profile_creation_flow/\"",
                     "js_module_root=../../chrome/test/data/webui/",
                     "js_module_root=./gen/chrome/test/data/webui/",
                   ]
   deps = [
     ":dice_web_signin_intercept_test",
+    ":profile_creation_flow_test",
     ":test_dice_web_signin_intercept_browser_proxy",
   ]
 }
@@ -27,6 +29,14 @@ js_library("dice_web_signin_intercept_test") {
   externs_list = [ "$externs_path/mocha-2.5.js" ]
 }
 
+js_library("profile_creation_flow_test") {
+  deps = [
+    "..:chai_assert",
+    "..:test_util.m",
+    "//chrome/browser/resources/signin/profile_picker/profile_creation_flow:profile_type_choice",
+  ]
+}
+
 js_library("test_dice_web_signin_intercept_browser_proxy") {
   deps = [
     "..:test_browser_proxy.m",

chrome/test/data/webui/signin/profile_creation_flow_test.js

+// Copyright 2020 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import 'chrome://profile-picker/profile_creation_flow/profile_type_choice.js';
+
+import {assertTrue} from '../chai_assert.js';
+import {isChildVisible} from '../test_util.m.js';
+
+suite('ProfileCreationFlowTest', function() {
+  /** @type {!ProfileTypeChoiceElement} */
+  let choice;
+
+  setup(function() {
+    document.body.innerHTML = '';
+    choice = /** @type {!ProfileTypeChoiceElement} */(
+        document.createElement('profile-type-choice'));
+    document.body.append(choice);
+  });
+
+  test('BackButton', function() {
+    assertTrue(isChildVisible(choice, '#backButton'));
+  });
+});

chrome/test/data/webui/signin/signin_browsertest.js

@@ -83,3 +83,20 @@ var DiceWebSigninInterceptTest = class extends SigninBrowserTest {
 TEST_F('DiceWebSigninInterceptTest', 'Bubble', function() {
   mocha.run();
 });
+
+/**
+ * Test fixture for
+ * chrome/browser/resources/signin/profile_picker/profile_creation_flow/profile_type_choice.html.
+ * This has to be declared as a variable for TEST_F to find it correctly.
+ */
+// eslint-disable-next-line no-var
+var ProfileCreationFlowTest = class extends SigninBrowserTest {
+  /** @override */
+  get browsePreload() {
+    return 'chrome://profile-picker/test_loader.html?module=signin/profile_creation_flow_test.js';
+  }
+};
+
+TEST_F('ProfileCreationFlowTest', 'BackButton', function() {
+  mocha.run();
+});