Commit bc0d5d56 authored by Marina Ciocea's avatar Marina Ciocea Committed by Commit Bot

Temporary disable audio quality tests failing on Mac.

Disable tests to unblock audio service process sandbox testing on Mac bots
while reproducing the bot setup locally to debug test failures. Tests disabled:
WebRtcAudioQualityBrowserTest.MANUAL_TestAutoGainControlOnLowAudio
WebRtcAudioQualityBrowserTest.MANUAL_TestAutoGainIsOffWithAudioProcessingOff
WebRtcAudioQualityBrowserTest.MANUAL_TestCallQualityWithAudioFromFakeDevice

Bug: 882780
Change-Id: I352d3a2cb396c2f1f04bd69bec105444a591aca5
Reviewed-on: https://chromium-review.googlesource.com/1251541Reviewed-by: default avatarPatrik Höglund <phoglund@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595393}
parent c8d74f84
...@@ -702,7 +702,7 @@ void WebRtcAudioQualityBrowserTest::TestWithFakeDeviceGetUserMedia( ...@@ -702,7 +702,7 @@ void WebRtcAudioQualityBrowserTest::TestWithFakeDeviceGetUserMedia(
DeleteFileUnlessTestFailed(recording, false); DeleteFileUnlessTestFailed(recording, false);
} }
#if defined(OS_LINUX) || defined(OS_MACOSX) || defined(OS_WIN) #if defined(OS_LINUX) || defined(OS_WIN)
#define MAYBE_MANUAL_TestCallQualityWithAudioFromFakeDevice \ #define MAYBE_MANUAL_TestCallQualityWithAudioFromFakeDevice \
MANUAL_TestCallQualityWithAudioFromFakeDevice MANUAL_TestCallQualityWithAudioFromFakeDevice
#else #else
...@@ -720,7 +720,8 @@ IN_PROC_BROWSER_TEST_F(WebRtcAudioQualityBrowserTest, ...@@ -720,7 +720,8 @@ IN_PROC_BROWSER_TEST_F(WebRtcAudioQualityBrowserTest,
#define MAYBE_MANUAL_TestCallQualityWithAudioFromWebAudio \ #define MAYBE_MANUAL_TestCallQualityWithAudioFromWebAudio \
MANUAL_TestCallQualityWithAudioFromWebAudio MANUAL_TestCallQualityWithAudioFromWebAudio
#else #else
// Not implemented on Android, ChromeOS etc. // Not implemented on Android, ChromeOS etc. Temporary disabled on Mac
// (https://crbug.com/882780).
#define MAYBE_MANUAL_TestCallQualityWithAudioFromWebAudio \ #define MAYBE_MANUAL_TestCallQualityWithAudioFromWebAudio \
DISABLED_MANUAL_TestCallQualityWithAudioFromWebAudio DISABLED_MANUAL_TestCallQualityWithAudioFromWebAudio
#endif #endif
...@@ -835,12 +836,12 @@ void WebRtcAudioQualityBrowserTest::TestAutoGainControl( ...@@ -835,12 +836,12 @@ void WebRtcAudioQualityBrowserTest::TestAutoGainControl(
DeleteFileUnlessTestFailed(actual_files_dir, true); DeleteFileUnlessTestFailed(actual_files_dir, true);
} }
#if defined(OS_LINUX) || defined(OS_MACOSX) #if defined(OS_LINUX)
#define MAYBE_MANUAL_TestAutoGainControlOnLowAudio \ #define MAYBE_MANUAL_TestAutoGainControlOnLowAudio \
MANUAL_TestAutoGainControlOnLowAudio MANUAL_TestAutoGainControlOnLowAudio
#else #else
// Not implemented on Android, ChromeOS etc. Temporary disabled on Windows // Not implemented on Android, ChromeOS etc. Temporary disabled on Windows
// (https://crbug.com/850936). // (https://crbug.com/850936) and on Mac (https://crbug.com/882780).
#define MAYBE_MANUAL_TestAutoGainControlOnLowAudio \ #define MAYBE_MANUAL_TestAutoGainControlOnLowAudio \
DISABLED_MANUAL_TestAutoGainControlOnLowAudio DISABLED_MANUAL_TestAutoGainControlOnLowAudio
#endif #endif
...@@ -855,12 +856,12 @@ IN_PROC_BROWSER_TEST_F(WebRtcAudioQualityBrowserTest, ...@@ -855,12 +856,12 @@ IN_PROC_BROWSER_TEST_F(WebRtcAudioQualityBrowserTest,
TestAutoGainControl(kAudioCallWithoutEchoCancellation, "_with_agc")); TestAutoGainControl(kAudioCallWithoutEchoCancellation, "_with_agc"));
} }
#if defined(OS_LINUX) || defined(OS_MACOSX) #if defined(OS_LINUX)
#define MAYBE_MANUAL_TestAutoGainIsOffWithAudioProcessingOff \ #define MAYBE_MANUAL_TestAutoGainIsOffWithAudioProcessingOff \
MANUAL_TestAutoGainIsOffWithAudioProcessingOff MANUAL_TestAutoGainIsOffWithAudioProcessingOff
#else #else
// Not implemented on Android, ChromeOS etc. Temporary disabled on Windows // Not implemented on Android, ChromeOS etc. Temporary disabled on Windows
// (https://crbug.com/850936). // (https://crbug.com/850936) and on Mac (https://crbug.com/882780).
#define MAYBE_MANUAL_TestAutoGainIsOffWithAudioProcessingOff \ #define MAYBE_MANUAL_TestAutoGainIsOffWithAudioProcessingOff \
DISABLED_MANUAL_TestAutoGainIsOffWithAudioProcessingOff DISABLED_MANUAL_TestAutoGainIsOffWithAudioProcessingOff
#endif #endif
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment