Commit bc15f9b5 authored by Taylor Brandstetter's avatar Taylor Brandstetter Committed by Commit Bot

Add more logging around FilteringNetworkManager and IpcNetworkManager.

There's an infrequently-occurring issue where webrtc never receives a
network update from FilteringNetworkManager, but it's not clear whether
the issue is related to FilteringNetworkManager interacting with the
permission service, or IpcNetworkManager underneath getting the actual
network list.

So, this CL adds some logging to FilteringNetworkManager and
IpcNetworkManager that will help pinpoint the cause, next time someone
is able to reproduce the issue and provide a log.

Bug: chromium:699973
Change-Id: I5eecf668c89963dd31ef66fc29687fe91dd2ac49
Reviewed-on: https://chromium-review.googlesource.com/587509Reviewed-by: default avatarHenrik Boström <hbos@chromium.org>
Commit-Queue: Taylor Brandstetter <deadbeef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491173}
parent 0ed279ba
...@@ -98,6 +98,7 @@ void FilteringNetworkManager::CheckPermission() { ...@@ -98,6 +98,7 @@ void FilteringNetworkManager::CheckPermission() {
started_permission_check_ = true; started_permission_check_ = true;
pending_permission_checks_ = 2; pending_permission_checks_ = 2;
VLOG(1) << "FilteringNetworkManager checking permission status.";
// Request for media permission asynchronously. // Request for media permission asynchronously.
media_permission_->HasPermission( media_permission_->HasPermission(
media::MediaPermission::AUDIO_CAPTURE, requesting_origin_, media::MediaPermission::AUDIO_CAPTURE, requesting_origin_,
...@@ -110,7 +111,8 @@ void FilteringNetworkManager::CheckPermission() { ...@@ -110,7 +111,8 @@ void FilteringNetworkManager::CheckPermission() {
void FilteringNetworkManager::OnPermissionStatus(bool granted) { void FilteringNetworkManager::OnPermissionStatus(bool granted) {
DCHECK(thread_checker_.CalledOnValidThread()); DCHECK(thread_checker_.CalledOnValidThread());
DCHECK_GT(pending_permission_checks_, 0); DCHECK_GT(pending_permission_checks_, 0);
VLOG(3) << "OnPermissionStatus: " << granted; VLOG(1) << "FilteringNetworkManager received permission status: "
<< (granted ? "granted" : "denied");
IPPermissionStatus old_status = GetIPPermissionStatus(); IPPermissionStatus old_status = GetIPPermissionStatus();
--pending_permission_checks_; --pending_permission_checks_;
......
...@@ -62,6 +62,9 @@ void IpcNetworkManager::StartUpdating() { ...@@ -62,6 +62,9 @@ void IpcNetworkManager::StartUpdating() {
base::ThreadTaskRunnerHandle::Get()->PostTask( base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE, base::Bind(&IpcNetworkManager::SendNetworksChangedSignal, FROM_HERE, base::Bind(&IpcNetworkManager::SendNetworksChangedSignal,
weak_factory_.GetWeakPtr())); weak_factory_.GetWeakPtr()));
} else {
VLOG(1) << "IpcNetworkManager::StartUpdating called; still waiting for "
"network list from browser process.";
} }
++start_count_; ++start_count_;
} }
...@@ -76,8 +79,11 @@ void IpcNetworkManager::OnNetworkListChanged( ...@@ -76,8 +79,11 @@ void IpcNetworkManager::OnNetworkListChanged(
const net::IPAddress& default_ipv4_local_address, const net::IPAddress& default_ipv4_local_address,
const net::IPAddress& default_ipv6_local_address) { const net::IPAddress& default_ipv6_local_address) {
// Update flag if network list received for the first time. // Update flag if network list received for the first time.
if (!network_list_received_) if (!network_list_received_) {
VLOG(1) << "IpcNetworkManager received network list from browser process "
"for the first time.";
network_list_received_ = true; network_list_received_ = true;
}
// Default addresses should be set only when they are in the filtered list of // Default addresses should be set only when they are in the filtered list of
// network addresses. // network addresses.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment