Commit bc17e6a3 authored by Denis Kuznetsov's avatar Denis Kuznetsov Committed by Commit Bot

Remove unused android property on oobe elements.

This is a cleanup that removes unused "android" attribute:

1) cr_button does not support this attribute anymore, so
it does not have sense to have it in oobe_buttons.

2) There is no code that uses this attribute for oobe dialogs,
so it can be safely removed.

android attribute was introduced to make sure Assistant buttons
were looking android-like about 2 years ago.

TBR=alemate@chromium.org

Bug: 1000606
Change-Id: I97f1988de91c8945f915110c705e9cc2b83697e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789706
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: default avatarRoman Sorokin [CET] <rsorokin@chromium.org>
Auto-Submit: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695575}
parent e49901e9
......@@ -33,7 +33,7 @@
disabled="[[buttonsDisabled]]">
<div i18n-content="assistantOptinSkipButton"></div>
</oobe-text-button>
<oobe-text-button id="retry-button" inverse android
<oobe-text-button id="retry-button" inverse
on-tap="onRetryTap_" disabled="[[buttonsDisabled]]">
<div i18n-content="assistantOptinRetryButton"></div>
</oobe-text-button>
......
......@@ -59,7 +59,7 @@
<link rel="stylesheet" href="oobe_text_buttons.css">
<cr-button id="textButton" on-tap="onClick_" disabled="[[disabled]]"
inverse$="[[inverse]]" aria-label$="[[labelForAria]]"
border$="[[border]]" android$="[[android]]">
border$="[[border]]">
<div id="container"
class="flex layout horizontal center center-justified self-stretch">
<slot></slot>
......
......@@ -15,8 +15,6 @@ Polymer({
border: Boolean,
android: {type: Boolean, value: false},
/* Note that we are not using "aria-label" property here, because
* we want to pass the label value but not actually declare it as an
* ARIA property anywhere but the actual target element.
......
......@@ -77,18 +77,6 @@
padding: unset;
}
#oobe-bottom[android] {
box-shadow: 0 -1px 1px rgba(0, 0, 0, 0.14);
}
#oobe-bottom[android][hideShadow] {
box-shadow: unset;
}
#oobe-bottom[android] {
height: 60px;
}
#oobe-bottom ::slotted(*) {
width: 100%;
}
......
......@@ -58,7 +58,7 @@
<link rel="stylesheet" href="oobe_dialog.css">
<link rel="stylesheet" href="oobe_flex_layout.css">
<style include="cr-shared-style"></style>
<div id="header-container" hidden="[[noHeader]]" android$="[[android]]">
<div id="header-container" hidden="[[noHeader]]">
<div id="oobe-icon-div">
<slot name="oobe-icon"></slot>
</div>
......@@ -77,7 +77,7 @@
<slot name="footer"></slot>
</div>
<template is="dom-if" if="[[hasButtons]]">
<div id="oobe-bottom" hideShadow$="[[hideShadow]]" android$="[[android]]"
<div id="oobe-bottom" hideShadow$="[[hideShadow]]"
no-buttons-padding$="[[noButtonsPadding]]"
class="layout horizontal center">
<slot name="bottom-buttons"></slot>
......
......@@ -55,11 +55,6 @@ Polymer({
reflectToAttribute: true,
observer: 'onfullScreenDialogChanged_',
},
android: {
type: Boolean,
value: false,
},
},
focus: function() {
......
......@@ -22,8 +22,3 @@
border-radius: 4px;
box-shadow: 0 24px 24px rgba(0, 0, 0, .24), 0 0 24px rgba(0, 0, 0, .12);
}
:host([android]) {
min-height: 480px;
min-width: 576px;
}
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment