Commit bc3b7be7 authored by Mikel Astiz's avatar Mikel Astiz Committed by Commit Bot

Do not instantiate base::FieldTrialList explicitly in tests

The test suite already instantiates a FieldTrialList as per
https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so
it's no longer necessary to do so explicitly in tests.

This patch addresses unit tests under:
/chrome/browser/extensions

This CL was uploaded by git cl split.

R=finnur@chromium.org

Bug: 1018667
Change-Id: I086571be2512e726282a47d3f957beeb8d6a0dd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917761
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: default avatarFinnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716023}
parent 4e6910ea
......@@ -14,9 +14,7 @@
#include "base/files/file_util.h"
#include "base/memory/ptr_util.h"
#include "base/memory/weak_ptr.h"
#include "base/metrics/field_trial.h"
#include "base/stl_util.h"
#include "base/test/mock_entropy_provider.h"
#include "base/test/scoped_feature_list.h"
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/extensions/api/webstore_private/webstore_private_api.h"
......@@ -1761,8 +1759,7 @@ class ExtensionServiceTestSupervised
: public ExtensionServiceSyncCustomGalleryTest,
public SupervisedUserService::Delegate {
public:
ExtensionServiceTestSupervised()
: field_trial_list_(std::make_unique<base::MockEntropyProvider>()) {}
ExtensionServiceTestSupervised() {}
void TearDown() override {
supervised_user_service()->SetDelegate(nullptr);
......@@ -1915,7 +1912,6 @@ class ExtensionServiceTestSupervised
return base_path().AppendASCII("permissions.pem");
}
base::FieldTrialList field_trial_list_;
base::test::ScopedFeatureList scoped_feature_list_;
};
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment