Commit bc47faf4 authored by Rayan Kanso's avatar Rayan Kanso Committed by Commit Bot

Disable failing serial port tests on Android.

The tests are consistently failing on Android tablet testers.

TBR=reillyg@chromium.org

Bug: 928712
Change-Id: I2e4426f922a1966d13ced292f2beaaf2ae4f059e
Reviewed-on: https://chromium-review.googlesource.com/c/1454362Reviewed-by: default avatarRayan Kanso <rayankans@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629120}
parent 33c78b62
...@@ -7,6 +7,7 @@ ...@@ -7,6 +7,7 @@
#include "base/command_line.h" #include "base/command_line.h"
#include "base/unguessable_token.h" #include "base/unguessable_token.h"
#include "build/build_config.h"
#include "content/public/browser/content_browser_client.h" #include "content/public/browser/content_browser_client.h"
#include "content/public/browser/serial_chooser.h" #include "content/public/browser/serial_chooser.h"
#include "content/public/browser/serial_delegate.h" #include "content/public/browser/serial_delegate.h"
...@@ -125,7 +126,13 @@ class SerialTest : public ContentBrowserTest { ...@@ -125,7 +126,13 @@ class SerialTest : public ContentBrowserTest {
} // namespace } // namespace
IN_PROC_BROWSER_TEST_F(SerialTest, GetPorts) { // https://crbug.com/928712 tracks failure on Android tablets.
#if defined(OS_ANDROID)
#define MAYBE_GetPorts DISABLED_GetPorts
#else
#define MAYBE_GetPorts GetPorts
#endif
IN_PROC_BROWSER_TEST_F(SerialTest, MAYBE_GetPorts) {
NavigateToURL(shell(), GetTestUrl(nullptr, "simple_page.html")); NavigateToURL(shell(), GetTestUrl(nullptr, "simple_page.html"));
// Three ports are added but only two will have permission granted. // Three ports are added but only two will have permission granted.
...@@ -151,7 +158,13 @@ IN_PROC_BROWSER_TEST_F(SerialTest, GetPorts) { ...@@ -151,7 +158,13 @@ IN_PROC_BROWSER_TEST_F(SerialTest, GetPorts) {
EXPECT_EQ(2, result); EXPECT_EQ(2, result);
} }
IN_PROC_BROWSER_TEST_F(SerialTest, RequestPort) { // https://crbug.com/928712 tracks failure on Android tablets.
#if defined(OS_ANDROID)
#define MAYBE_RequestPort DISABLED_RequestPort
#else
#define MAYBE_RequestPort RequestPort
#endif
IN_PROC_BROWSER_TEST_F(SerialTest, MAYBE_RequestPort) {
NavigateToURL(shell(), GetTestUrl(nullptr, "simple_page.html")); NavigateToURL(shell(), GetTestUrl(nullptr, "simple_page.html"));
auto port = device::mojom::SerialPortInfo::New(); auto port = device::mojom::SerialPortInfo::New();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment