Revert "TabSearch: Enable/Disable feedback button based on a config"

This reverts commit 218a19d8afddea116cf66cd2764fa5fb1988716a.

Reason for revert: Has test failures

Change-Id: I8c2faf5cc691c9bd041f02aeac5cbeb71f4e2e66
Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3291232Reviewed-by: Roman Arora <romanarora@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819617}

chrome/browser/resources/tab_search_merge/app.html

@@ -80,10 +80,8 @@
 <div id="no-results" hidden="[[filteredOpenTabs_.length]]">
   $i18n{noResultsFound}
 </div>
-<template is="dom-if" if="[[feedbackButtonEnabled_]]">
-  <button id="feedback-footer" class="mwb-list-item" on-click="onFeedbackClick_"
-      on-focus="onFeedbackFocus_">
-    <iron-icon id="feedback-icon" icon="ts:feedback"></iron-icon>
-    <div id="feedback-text">$i18n{submitFeedback}</div>
-  </button>
-</template>
+<button id="feedback-footer" class="mwb-list-item" on-click="onFeedbackClick_"
+    on-focus="onFeedbackFocus_">
+  <iron-icon id="feedback-icon" icon="ts:feedback"></iron-icon>
+  <div id="feedback-text">$i18n{submitFeedback}</div>
+</button>

chrome/browser/resources/tab_search_merge/app.js

@@ -88,12 +88,6 @@ export class TabSearchAppElement extends PolymerElement {
           ],
         },
       },
-
-      /** @private {boolean} */
-      feedbackButtonEnabled_: {
-        type: Boolean,
-        value: () => loadTimeData.getBoolean('submitFeedbackEnabled'),
-      },
     };
   }
 

chrome/browser/resources/tab_search_merge/test/tab_search_app_test.js

@@ -2,7 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import {loadTimeData} from 'chrome://resources/js/load_time_data.m.js';
 import {keyDownOn} from 'chrome://resources/polymer/v3_0/iron-test-helpers/mock-interactions.js';
 import {TabSearchAppElement} from 'chrome://tab-search/app.js';
 import {TabSearchApiProxy, TabSearchApiProxyImpl} from 'chrome://tab-search/tab_search_api_proxy.js'
@@ -38,19 +37,11 @@ suite('TabSearchAppTest', () => {
     return tabSearchApp.shadowRoot.querySelectorAll('tab-search-item');
   }
 
-  /**
-   * @param {tabSearch.mojom.ProfileTabs} sampleData
-   * @param {Object=} loadTimeOverridenData
-   */
-  async function setupTest(sampleData, loadTimeOverridenData) {
+  async function setupTest(sampleData) {
     testProxy = new TestTabSearchApiProxy();
     testProxy.setProfileTabs(sampleData);
     TabSearchApiProxyImpl.instance_ = testProxy;
 
-    if (loadTimeOverridenData) {
-      loadTimeData.overrideValues(loadTimeOverridenData);
-    }
-
     tabSearchApp = /** @type {!TabSearchAppElement} */
         (document.createElement('tab-search-app'));
 
@@ -328,14 +319,8 @@ suite('TabSearchAppTest', () => {
     assertEquals(1, testProxy.getCallCount('showUI'));
   });
 
-  test('Submit feeedback footer disabled by default', async () => {
-    await setupTest(sampleData());
-    assertTrue(
-        tabSearchApp.shadowRoot.querySelector('#feedback-footer') === null);
-  });
-
   test('Click on Sumit Feedback footer triggers action', async () => {
-    await setupTest(sampleData(), {'submitFeedbackEnabled': true});
+    await setupTest(sampleData());
 
     const feedbackButton = /** @type {!HTMLButtonElement} */
         (tabSearchApp.shadowRoot.querySelector('#feedback-footer'));
@@ -372,7 +357,7 @@ suite('TabSearchAppTest', () => {
   });
 
   test('Escape key triggers close UI API', async () => {
-    await setupTest(sampleData(), {'submitFeedbackEnabled': true});
+    await setupTest(sampleData());
 
     const elements = [
       tabSearchApp.shadowRoot.querySelector('#searchField'),