Commit bc7f86fd authored by Sebastien Lalancette's avatar Sebastien Lalancette Committed by Commit Bot

[iOS] Change Copy Link Action String on New Context Menus

Updated the string as per UX's guidance.

Bug: 1093302
Change-Id: Ia179f7e4d069d63cd84b25381f513e46c75f84b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360326Reviewed-by: default avatarTommy Martino <tmartino@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798892}
parent 57abb538
...@@ -357,6 +357,9 @@ locale. The strings in this file are specific to iOS. ...@@ -357,6 +357,9 @@ locale. The strings in this file are specific to iOS.
<message name="IDS_IOS_AUTOFILL_SET_UP_SCREENLOCK_CONTENT" desc="Message informing the user that in order to use the password, a screen lock needs to be set up on the device. This is shown as an alert message after the user tries to view or copy the password from a settings page. [CHAR_LIMIT=100]"> <message name="IDS_IOS_AUTOFILL_SET_UP_SCREENLOCK_CONTENT" desc="Message informing the user that in order to use the password, a screen lock needs to be set up on the device. This is shown as an alert message after the user tries to view or copy the password from a settings page. [CHAR_LIMIT=100]">
To use passwords, you must first set a passcode on your device. To use passwords, you must first set a passcode on your device.
</message> </message>
<message name="IDS_IOS_COPY_LINK_ACTION_TITLE" desc="Title of the action used to copy a link to the pasteboard. [iOS only]">
Copy Link
</message>
<message name="IDS_IOS_DELETE_ACTION_TITLE" desc="Title of the action used to delete a selected item. Item types include, for example, a Bookmark or an History Entry. [iOS only]"> <message name="IDS_IOS_DELETE_ACTION_TITLE" desc="Title of the action used to delete a selected item. Item types include, for example, a Bookmark or an History Entry. [iOS only]">
Delete Delete
</message> </message>
......
df6f3e9b4c9d955e1d810ad5ca9118bde82045d7
\ No newline at end of file
...@@ -59,13 +59,13 @@ ...@@ -59,13 +59,13 @@
} }
- (UIAction*)actionToCopyURL:(const GURL)URL { - (UIAction*)actionToCopyURL:(const GURL)URL {
return return [self
[self actionWithTitle:l10n_util::GetNSString(IDS_IOS_CONTENT_CONTEXT_COPY) actionWithTitle:l10n_util::GetNSString(IDS_IOS_COPY_LINK_ACTION_TITLE)
image:[UIImage imageNamed:@"copy_link_url"] image:[UIImage imageNamed:@"copy_link_url"]
type:MenuActionType::Copy type:MenuActionType::Copy
block:^{ block:^{
StoreURLInPasteboard(URL); StoreURLInPasteboard(URL);
}]; }];
} }
- (UIAction*)actionToShareWithBlock:(ProceduralBlock)block { - (UIAction*)actionToShareWithBlock:(ProceduralBlock)block {
......
...@@ -98,7 +98,7 @@ TEST_F(ActionFactoryTest, CopyAction) { ...@@ -98,7 +98,7 @@ TEST_F(ActionFactoryTest, CopyAction) {
UIImage* expectedImage = [UIImage imageNamed:@"copy_link_url"]; UIImage* expectedImage = [UIImage imageNamed:@"copy_link_url"];
NSString* expectedTitle = NSString* expectedTitle =
l10n_util::GetNSString(IDS_IOS_CONTENT_CONTEXT_COPY); l10n_util::GetNSString(IDS_IOS_COPY_LINK_ACTION_TITLE);
GURL testURL = GURL("https://example.com"); GURL testURL = GURL("https://example.com");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment